From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f181.google.com (mail-pg1-f181.google.com [209.85.215.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7142B155A4D for ; Thu, 7 Aug 2025 06:17:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754547433; cv=none; b=YqtFbG1nsTMB75jvS9m2LrYdgXheXvlJo/8vQto6JkJwreSfwOZOyLj2NnpYgwaq5vP8pEhMQHG7LESGY2Isl6g6Ry/nOfZHjfIjlkHHY5pS1B/SWM4myLsvmTtVE1bsrQ/lc8T9t2xkdXkxeZiUBQXmmbFm+E9RECzG5rlgt1w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754547433; c=relaxed/simple; bh=aTI7KRMb+mTuV/VHOg0lvKzCQkP79foiGNftYWWJCNg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=BcK+J3iPSmD8asu3CUZKkgVDPm5wfTDB4htdobwlakOpRu86IHaJewl3qO8Gd7wz+E4aNKXhZduhsIeKfctcNTMFPrmTJ+N8j0Nub2D14rx0KqCUS5WmDvXNdAjyytVDWgsKmBuZKmYkeRm8c0ib5labjKfp/p/fZ2j8x5RFTeY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=furiosa.ai; spf=none smtp.mailfrom=furiosa.ai; dkim=pass (1024-bit key) header.d=furiosa.ai header.i=@furiosa.ai header.b=XFurapCN; arc=none smtp.client-ip=209.85.215.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=furiosa.ai Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=furiosa.ai Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=furiosa.ai header.i=@furiosa.ai header.b="XFurapCN" Received: by mail-pg1-f181.google.com with SMTP id 41be03b00d2f7-af51596da56so448936a12.0 for ; Wed, 06 Aug 2025 23:17:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=furiosa.ai; s=google; t=1754547432; x=1755152232; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=Ce659OtSUkmpdV6NFKc1K9485Iy6jSsKTUwN0rRmfcw=; b=XFurapCNEZTdArLKizqI2uckQ6MwjfbfXjKuUmaP/r4ksrCj+Cnn9kITcGjGMrv47r noueJKpFrIGCynhLQFB4GsS1ncTSRcbHpQcfwP5mfk1pDjCFBJDoS2nkPH6VowtU+phj WJ+57AduyykJpShz3Hp2uMOrlwE960sRX5sXY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754547432; x=1755152232; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Ce659OtSUkmpdV6NFKc1K9485Iy6jSsKTUwN0rRmfcw=; b=FWRMEijh9LIAGHA2uNF8TlP/v8EqJ6Mh8srNe7NtCnpdRrnG1r7r8v/bcWdt95cKpT gUL8zHgEiHH0RICr6IdYH/mfjIMQ5a0djA5gLXMNn2ZIvQ/DCgryPauXX6fcU2wZzFjE juY/ETbAAFs4DsC3PZ/ug1dI2XAxzDGdX1H95N8pbGdDkLebPT+s9bdioZQmeYW609Tt Jo07K/grOr/fNRlvWZhUw1mAYROvEkXSdGVEYm47igxDxnf0sGmpWxND9HM0bygde03b Z0wwNY87ACQ1x9ZIPuyf0m6u0qa49Sb7tWBHCSmM/ije/FQqkBnWq2Pu83Lo170pg25i N+KA== X-Forwarded-Encrypted: i=1; AJvYcCW0GIEUECJiinC92HNODpBagU0OqeQSDVmrLGJtpKRFx1mXTFc9gfqIBKwH74ydNm9yBRFKXtq94IB2y4frOA==@vger.kernel.org X-Gm-Message-State: AOJu0Yw2GcgO8w4pHZ/gCN4sKcethHzlK+V7IAbXEkB4uXXkMxXlJpBX o6ux6OvGyyX+kqNcFjPeq0g71P4izTTD+JyKVJ8/x4j9M5Tyz7pw1aVWbZbm4x66YlE= X-Gm-Gg: ASbGnct0z4bEMP26zUVEzYVQyIBgC3ObHHRprh1hjSc+KerGdBw9/+L7JfyvtIf3/jn vgYyF8S3YaaTrGjZp8YzZbsDdvrcehRkKSj6APef1HN0xwiSBVhiIrhRvvaGJ1bySX+HtAaxWVr ffny3bIq2DtrrZdIXiL8lVegqpeKFoaSfiLOKMCoxP3PL8JWOIQIfz5UVN31RYH6PPGnoI/TAxu sjJeslYBiWDPm32dXp3KOfviuif1phog85g1XIxV5kXnXe5B367oj8G/szQss0C2IVVCqzP3OS3 Jk8NJp1bsIpykixeAJ5CiO3dbAiYmlOCcaeay88WUw4E7GEXdsrv6MkD3fZF0/ntuQv2BKGqniZ mWUavkIm7y+yRj7gFOIRiksiIMhprJvwsIFgR1KKTPCEconB6WQaUGUlv X-Google-Smtp-Source: AGHT+IH0frrBX/8KPXvenJx9gfme9Uust8UCZ54LaxAoHIwgcXp84/Tzc+gQadT1iW0DZKCuiadR2Q== X-Received: by 2002:a17:902:d551:b0:240:5523:6658 with SMTP id d9443c01a7336-242a0b874b6mr70085135ad.29.1754547431644; Wed, 06 Aug 2025 23:17:11 -0700 (PDT) Received: from sidongui-MacBookPro.local ([175.195.128.78]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-241d1f0f76bsm175262285ad.59.2025.08.06.23.17.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Aug 2025 23:17:11 -0700 (PDT) Date: Thu, 7 Aug 2025 15:17:02 +0900 From: Sidong Yang To: Daniel Almeida Cc: Caleb Sander Mateos , Benno Lossin , Miguel Ojeda , Arnd Bergmann , Jens Axboe , Greg Kroah-Hartman , rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, io-uring@vger.kernel.org Subject: Re: [RFC PATCH v2 0/4] rust: miscdevice: abstraction for uring-cmd Message-ID: References: <20250727150329.27433-1-sidong.yang@furiosa.ai> <60A6421A-813F-4A93-88AF-4AE3027E1FA3@collabora.com> Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <60A6421A-813F-4A93-88AF-4AE3027E1FA3@collabora.com> On Fri, Aug 01, 2025 at 11:13:29AM -0300, Daniel Almeida wrote: > Hi Sidong, > > > On 27 Jul 2025, at 12:03, Sidong Yang wrote: > > > > This patch series implemens an abstraction for io-uring sqe and cmd and > > adds uring_cmd callback for miscdevice. Also there is an example that use > > uring_cmd in rust-miscdevice sample. > > > > I received a email from kernel bot that `io_tw_state` is not FFI-safe. > > It seems that the struct has no field how can I fix this? > > > > Changelog: > > v2: > > * use pinned &mut for IoUringCmd > > * add missing safety comments > > * use write_volatile for read uring_cmd in sample > > Why is v2 an RFC when v1 wasn´t? Can you mention it on the changelog? It was just miss. v1 should be also RFC. I'll mention it for next v3. Thanks, Sidong > > > > > Sidong Yang (4): > > rust: bindings: add io_uring headers in bindings_helper.h > > rust: io_uring: introduce rust abstraction for io-uring cmd > > rust: miscdevice: add uring_cmd() for MiscDevice trait > > samples: rust: rust_misc_device: add uring_cmd example > > > > rust/bindings/bindings_helper.h | 2 + > > rust/kernel/io_uring.rs | 183 +++++++++++++++++++++++++++++++ > > rust/kernel/lib.rs | 1 + > > rust/kernel/miscdevice.rs | 41 +++++++ > > samples/rust/rust_misc_device.rs | 34 ++++++ > > 5 files changed, 261 insertions(+) > > create mode 100644 rust/kernel/io_uring.rs > > > > -- > > 2.43.0 > > > > > > - Daniel