From: Alice Ryhl <aliceryhl@google.com>
To: Andreas Hindborg <a.hindborg@kernel.org>
Cc: "Boqun Feng" <boqun.feng@gmail.com>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Trevor Gross" <tmgross@umich.edu>,
"Danilo Krummrich" <dakr@kernel.org>,
"Jens Axboe" <axboe@kernel.dk>,
linux-block@vger.kernel.org, rust-for-linux@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 04/15] rust: str: introduce `NullTerminatedFormatter`
Date: Wed, 13 Aug 2025 07:21:20 +0000 [thread overview]
Message-ID: <aJw88P7K_6GFmWvW@google.com> (raw)
In-Reply-To: <20250812-rnull-up-v6-16-v4-4-ed801dd3ba5c@kernel.org>
On Tue, Aug 12, 2025 at 10:44:22AM +0200, Andreas Hindborg wrote:
> Add `NullTerminatedFormatter`, a formatter that writes a null terminated
> string to an array or slice buffer. Because this type needs to manage the
> trailing null marker, the existing formatters cannot be used to implement
> this type.
>
> Signed-off-by: Andreas Hindborg <a.hindborg@kernel.org>
Reviewed-by: Alice Ryhl <aliceryhl@google.com>
> + #[expect(dead_code)]
> + pub(crate) fn from_array<const N: usize>(
Don't you delete this function in the next patch?
Alice
next prev parent reply other threads:[~2025-08-13 7:21 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-12 8:44 [PATCH v4 00/15] rnull: add configfs, remote completion to rnull Andreas Hindborg
2025-08-12 8:44 ` [PATCH v4 01/15] rust: str: normalize imports in `str.rs` Andreas Hindborg
2025-08-12 8:44 ` [PATCH v4 02/15] rust: str: allow `str::Formatter` to format into `&mut [u8]` Andreas Hindborg
2025-08-13 7:18 ` Alice Ryhl
2025-08-12 8:44 ` [PATCH v4 03/15] rust: str: expose `str::{Formatter, RawFormatter}` publicly Andreas Hindborg
2025-08-13 7:18 ` Alice Ryhl
2025-08-12 8:44 ` [PATCH v4 04/15] rust: str: introduce `NullTerminatedFormatter` Andreas Hindborg
2025-08-13 7:21 ` Alice Ryhl [this message]
2025-08-13 12:34 ` Andreas Hindborg
2025-08-12 8:44 ` [PATCH v4 05/15] rust: block: normalize imports for `gen_disk.rs` Andreas Hindborg
2025-08-12 8:44 ` [PATCH v4 06/15] rust: block: use `NullTerminatedFormatter` Andreas Hindborg
2025-08-13 7:22 ` Alice Ryhl
2025-08-12 8:44 ` [PATCH v4 07/15] rust: block: remove `RawWriter` Andreas Hindborg
2025-08-12 8:44 ` [PATCH v4 08/15] rust: block: remove trait bound from `mq::Request` definition Andreas Hindborg
2025-08-12 8:44 ` [PATCH v4 09/15] rust: block: add block related constants Andreas Hindborg
2025-08-13 7:22 ` Alice Ryhl
2025-08-12 8:44 ` [PATCH v4 10/15] rnull: move driver to separate directory Andreas Hindborg
2025-08-12 8:44 ` [PATCH v4 11/15] rnull: enable configuration via `configfs` Andreas Hindborg
2025-08-13 7:27 ` Alice Ryhl
2025-08-13 12:47 ` Andreas Hindborg
2025-08-13 13:54 ` Alice Ryhl
2025-08-13 17:36 ` Andreas Hindborg
2025-08-13 18:05 ` Alice Ryhl
2025-08-14 7:40 ` Andreas Hindborg
2025-08-14 8:58 ` Alice Ryhl
2025-08-12 8:44 ` [PATCH v4 12/15] rust: block: add `GenDisk` private data support Andreas Hindborg
2025-08-13 7:30 ` Alice Ryhl
2025-08-13 12:56 ` Andreas Hindborg
2025-08-13 13:50 ` Alice Ryhl
2025-08-12 8:44 ` [PATCH v4 13/15] rust: block: mq: fix spelling in a safety comment Andreas Hindborg
2025-08-12 8:44 ` [PATCH v4 14/15] rust: block: add remote completion to `Request` Andreas Hindborg
2025-08-12 8:44 ` [PATCH v4 15/15] rnull: add soft-irq completion support Andreas Hindborg
2025-08-13 7:32 ` Alice Ryhl
2025-08-14 18:28 ` Andreas Hindborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aJw88P7K_6GFmWvW@google.com \
--to=aliceryhl@google.com \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=axboe@kernel.dk \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=gary@garyguo.net \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).