From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f170.google.com (mail-qk1-f170.google.com [209.85.222.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7CEDF2D0298 for ; Wed, 10 Sep 2025 19:17:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757531844; cv=none; b=FSwPt945zJi/27OzAQOYAJJcmXlk8XB95Yhppq7BW6r5KGa0U8EsQdZRm7yYL5htcd0AdNkdUoTBwbkCj1j7GNpb1CQ8oeIGtYwXuC4Pl35psOYQlIEyhFz/s7Du7aUtzqH2S/xp1P3J6D8t2kzF3Peg4t1c4KxBL86ExIjecYA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757531844; c=relaxed/simple; bh=SCwHNEdMA8MEn00BiFAEH+58S7M3dIzW3LxE3UwmJtE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ey13OF6OFE7hW8s4c65wLyNYcnJpQmwdIn+FPb9vjsKMBWSaYITTsX40HfwoOsLyEi1HnNupqD5jBmq/gtaNojLWRjelIwqps/b/hN2chGKk822Ht392mHh4XHgHDq122EGSYlxYSpo5ADdK2uuH7v4paRSJMASR/BXu2++8fPU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CH06cekx; arc=none smtp.client-ip=209.85.222.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CH06cekx" Received: by mail-qk1-f170.google.com with SMTP id af79cd13be357-80a59f06a4fso1057026385a.2 for ; Wed, 10 Sep 2025 12:17:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1757531840; x=1758136640; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:feedback-id:from:to:cc:subject:date :message-id:reply-to; bh=7snMmseLVBcfubyQhVWOsGdoU6rRK3K5ZVTv8Xsb4Kw=; b=CH06cekxPOyCvZx6yIU5SYzBawHUX7+Ou9ol6PsbLwgQMoxVU/XSh5CCgN4hFYWiOf anUv3FzI2ew7vmF2m6/M5LEWmQuVo8ri6AhRqBL7L7o6yr4NxAFfBg6lvAOWynrhsCXB Kiq0OfhRAa/gLlZLDrWduev0vokcxAu5cifZX8A4B76uQqZs3wpuv9xuqLyL/6XSGo84 7bS8rPRw5Xm//UADI0zPEusNm3gj7DJv1tWZsCRkqHM7RLXClDmNIPewLje2KvcG3A/g vbwrREuN1aDQwzBnXaa741+z1/D57fOVQBdMLAzSXtPwx94a7yk4Nqou5OOpx207vnHS EcEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757531840; x=1758136640; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:feedback-id:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7snMmseLVBcfubyQhVWOsGdoU6rRK3K5ZVTv8Xsb4Kw=; b=fgN0O+9VQYBrL2ZGTeWbTnG2d8ASTM3LnGxTUhFg+93HG2wbzAmMy1vfojgsyw+HsY 5rqGQokj8ReUY1JiQGHl+mQqH22TFu7arNievdEcCy+hZAeoK3j6CdtY+1NXtcRWMf54 K9nSm7pyfK29cuNhNVc7thRDJKADW5gfw7klxHcGSW2Deap1iPEjSzKYW4d7sUDsPtiS SXguJPjPAEssT9j3AixaKUFFzasKcxh8MCWu6Rw/tzT/k/vTLY2rQXbTJzVluZs3ZmI8 Rfewd4K4Uy4GB5o9fYRCtiNKJnpu8AFnnzHCnH/IZQa0dMfnELvu2ehi8oEuvrfng8S2 W4jw== X-Forwarded-Encrypted: i=1; AJvYcCUjOwtYqwWqWArJ0Tyt2/03tYI0e5OXPA6crE8mN3PY3i2YCu3G5hWi9e2rfPR+Bbo55mrfXF4QDQfaiB4rSw==@vger.kernel.org X-Gm-Message-State: AOJu0Yx13+Tng5ptX40jtj8FBzT2bD5hx0roAjvUs3evvfeNRFzxpD8l zlq4PcbGxafCSJ9lZvzCoO1J095yKG4EAGFCAW7g4tA5JkQybB1rdWK0 X-Gm-Gg: ASbGncuuq8dOJnrBTpTg7V+r2uCZXcPBT27TMF8aEM4e73bjG3r4p5qYfT5ReKLCgpg DZE3nDKvSTGzXuAV+d+PucCqzaI1LuIGzbSFXg9ZkS3aOyMOErZ8hsaGBgNi+lN6sFnlBOCLxgm hvX9ZZIuj2eKXstbK44nUiQ3PqBfefTMYb8KKESFC3farYjZ9bFHNTp13YPo45/5RBEB1111X0n mtkUpbKeLjSGgEbACaTD/e1AuJti9wEIQa0dq0+ktiW1C/M5q0BC73cpwLM3gzemnb6d+0rx3d0 eHxkIcSAA6VSIfB3UYRLOK2CuS36nt8ts38RrK9ijFtx6W6dSoo95CxjxRfwpwug1TTHwkV5545 8uU/uPehfIJE1HERDg5GGbKQzMGRAMau6ZKVcfHbESzJByP+/lAFWWzOaVHc3xUu7IvWkG4Wwym YcAgNFM9yCeuSm03Scruf7sqH5b9QB8wUm9g== X-Google-Smtp-Source: AGHT+IFLKs6Z9Get2FJtBN4ng6d/qG2NCMDW+y5NcESyPYI9AIJUrHThVuklIbRDXM58AvJuPVzh/A== X-Received: by 2002:a05:620a:1aa0:b0:81f:65ec:81c4 with SMTP id af79cd13be357-81f65ec834cmr243699785a.30.1757531840153; Wed, 10 Sep 2025 12:17:20 -0700 (PDT) Received: from fauth-a2-smtp.messagingengine.com (fauth-a2-smtp.messagingengine.com. [103.168.172.201]) by smtp.gmail.com with ESMTPSA id af79cd13be357-81b5f715c0bsm339500585a.61.2025.09.10.12.17.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Sep 2025 12:17:19 -0700 (PDT) Received: from phl-compute-03.internal (phl-compute-03.internal [10.202.2.43]) by mailfauth.phl.internal (Postfix) with ESMTP id 0ABE3F40068; Wed, 10 Sep 2025 15:17:19 -0400 (EDT) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-03.internal (MEProxy); Wed, 10 Sep 2025 15:17:19 -0400 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdeggddvgedutdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjug hrpeffhffvvefukfhfgggtuggjsehttdertddttddunecuhfhrohhmpeeuohhquhhnucfh vghnghcuoegsohhquhhnrdhfvghnghesghhmrghilhdrtghomheqnecuggftrfgrthhtvg hrnhepieffjeehjeeludekfeeikefgteevjeeitdevkefghfetkedvieejfeegtdffvefg necuffhomhgrihhnpehkvghrnhgvlhdrohhrghenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpegsohhquhhnodhmvghsmhhtphgruhhthhhpvghr shhonhgrlhhithihqdeiledvgeehtdeigedqudejjeekheehhedvqdgsohhquhhnrdhfvg hngheppehgmhgrihhlrdgtohhmsehfihigmhgvrdhnrghmvgdpnhgspghrtghpthhtohep udelpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopegurghnihgvlhdrrghlmhgvih gurgestgholhhlrggsohhrrgdrtghomhdprhgtphhtthhopehmthhurhhquhgvthhtvges sggrhihlihgsrhgvrdgtohhmpdhrtghpthhtohepshgsohihugeskhgvrhhnvghlrdhorh hgpdhrtghpthhtohepohhjvggurgeskhgvrhhnvghlrdhorhhgpdhrtghpthhtoheprghl vgigrdhgrgihnhhorhesghhmrghilhdrtghomhdprhgtphhtthhopehgrghrhiesghgrrh ihghhuohdrnhgvthdprhgtphhtthhopegsjhhorhhnfegpghhhsehprhhothhonhhmrghi lhdrtghomhdprhgtphhtthhopehlohhsshhinheskhgvrhhnvghlrdhorhhgpdhrtghpth htoheprgdrhhhinhgusghorhhgsehkvghrnhgvlhdrohhrgh X-ME-Proxy: Feedback-ID: iad51458e:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 10 Sep 2025 15:17:18 -0400 (EDT) Date: Wed, 10 Sep 2025 12:17:17 -0700 From: Boqun Feng To: Daniel Almeida Cc: Michael Turquette , Stephen Boyd , Miguel Ojeda , Alex Gaynor , Gary Guo , =?iso-8859-1?Q?Bj=F6rn?= Roy Baron , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , "Rafael J. Wysocki" , Viresh Kumar , linux-clk@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH v2 1/2] rust: clk: implement Send and Sync Message-ID: References: <20250910-clk-type-state-v2-0-1b97c11bb631@collabora.com> <20250910-clk-type-state-v2-1-1b97c11bb631@collabora.com> <3D936C1B-FBA9-4964-859C-84BB665BBE3B@collabora.com> Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <3D936C1B-FBA9-4964-859C-84BB665BBE3B@collabora.com> On Wed, Sep 10, 2025 at 03:47:30PM -0300, Daniel Almeida wrote: > Hi Boqun, > > > On 10 Sep 2025, at 14:49, Boqun Feng wrote: > > > > On Wed, Sep 10, 2025 at 02:28:27PM -0300, Daniel Almeida wrote: > >> From: Alice Ryhl > >> > >> These traits are required for drivers to embed the Clk type in their own > >> data structures because driver data structures are usually required to > >> be Send. See e.g. [1] for the kind of workaround that drivers currently > >> need due to lacking this annotation. > >> > >> Link: https://lore.kernel.org/rust-for-linux/20250812-tyr-v2-1-9e0f3dc9da95@collabora.com/ [1] > >> Signed-off-by: Daniel Almeida > >> Signed-off-by: Alice Ryhl > >> Reviewed-by: Danilo Krummrich > >> Acked-by: Viresh Kumar > >> Reviewed-by: Daniel Almeida > > > > This tag list looks a bit weird to me. Why is there a SoB from you > > before Alice's SoB? At least for the usage I'm familiar with, outside > > the case of Co-developed-bys, multiple SoBs is used for recording how > > the patches are routed. For example, if I have a patch that has my SoB > > and I send it to you, you queue in your tree and then send out to other > > maintainers for merging, in general you would put your SoB after mine in > > that case. But I don't think that's case here? Alice's patch has only > > her SoB: > > > > https://lore.kernel.org/rust-for-linux/20250904-clk-send-sync-v1-1-48d023320eb8@google.com/ > > > > What's the intention of the SoB tag here? > > > > Otherwise the patch looks good to me. If we get the tag list resolved, > > feel free to add: > > > > Reviewed-by: Boqun Feng > > > > Regards, > > Boqun > > > > You have to include your SOB when submitting patches from others. > > This is something I tend to forget often, so I made sure it was there. The > order may be indeed off though. > I mean you can just use `b4 shazam -s` to apply the patch and add your SoB at the end ;-) Regards, Boqun > - Daniel >