From: Alice Ryhl <aliceryhl@google.com>
To: Danilo Krummrich <dakr@kernel.org>
Cc: gregkh@linuxfoundation.org, rafael@kernel.org, ojeda@kernel.org,
alex.gaynor@gmail.com, boqun.feng@gmail.com, gary@garyguo.net,
bjorn3_gh@protonmail.com, lossin@kernel.org,
a.hindborg@kernel.org, tmgross@umich.edu, mmaurer@google.com,
rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/7] rust: debugfs: support for binary large objects
Date: Sun, 19 Oct 2025 09:44:51 +0000 [thread overview]
Message-ID: <aPSzE7DpA7DxTHmm@google.com> (raw)
In-Reply-To: <DDKOLD1897SY.84W93E6L8ITR@kernel.org>
On Fri, Oct 17, 2025 at 04:53:09PM +0200, Danilo Krummrich wrote:
> On Fri Oct 17, 2025 at 4:37 PM CEST, Danilo Krummrich wrote:
> > The reason I went with a trait is because that's consistent within the file.
> >
> > Otherwise, I don't mind one or the other. If we always want to use a struct, I'm
> > fine with that. :)
>
> Actually, there's another reason I forgot about since I sent the series. :)
>
> We need it because we derive it from blanket implementations:
>
> impl<T: BinaryWriter + Sync> BinaryReadFile<T> for T
> impl<T: BinaryReader + Sync> BinaryWriteFile<T> for T
> impl<T: BinaryWriter + BinaryReader + Sync> BinaryReadWriteFile<T> for T
You can still use a struct:
struct BinaryWriterVtable<T: BinaryWriter + Sync>;
impl<T: BinaryWriter + Sync> BinaryWriterVtable<T> {
const VTABLE: bindings::foo = ...;
}
next prev parent reply other threads:[~2025-10-19 9:44 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-03 22:26 [PATCH 0/7] Binary Large Objects for Rust DebugFS Danilo Krummrich
2025-10-03 22:26 ` [PATCH 1/7] rust: uaccess: add UserSliceReader::read_slice_partial() Danilo Krummrich
2025-10-17 11:11 ` Alice Ryhl
2025-10-17 11:50 ` Danilo Krummrich
2025-10-03 22:26 ` [PATCH 2/7] rust: uaccess: add UserSliceWriter::write_slice_partial() Danilo Krummrich
2025-10-03 22:26 ` [PATCH 3/7] rust: debugfs: support for binary large objects Danilo Krummrich
2025-10-17 12:59 ` Alice Ryhl
2025-10-17 14:37 ` Danilo Krummrich
2025-10-17 14:53 ` Danilo Krummrich
2025-10-19 9:44 ` Alice Ryhl [this message]
2025-10-19 12:01 ` Danilo Krummrich
2025-10-20 8:12 ` Alice Ryhl
2025-10-20 9:40 ` Danilo Krummrich
2025-10-20 9:42 ` Alice Ryhl
2025-10-20 9:49 ` Danilo Krummrich
2025-10-19 9:50 ` Alice Ryhl
2025-10-19 11:24 ` Danilo Krummrich
2025-10-20 8:13 ` Alice Ryhl
2025-10-20 9:35 ` Danilo Krummrich
2025-10-20 9:39 ` Alice Ryhl
2025-10-20 9:41 ` Danilo Krummrich
2025-10-03 22:26 ` [PATCH 4/7] rust: debugfs: support blobs from smart pointers Danilo Krummrich
2025-10-03 23:12 ` Matthew Maurer
2025-10-03 23:26 ` Danilo Krummrich
2025-10-03 23:36 ` Matthew Maurer
2025-10-03 22:26 ` [PATCH 5/7] samples: rust: debugfs: add example for blobs Danilo Krummrich
2025-10-20 10:01 ` Alice Ryhl
2025-10-03 22:26 ` [PATCH 6/7] rust: debugfs: support binary large objects for ScopedDir Danilo Krummrich
2025-10-17 13:00 ` Alice Ryhl
2025-10-17 14:55 ` Danilo Krummrich
2025-10-03 22:26 ` [PATCH 7/7] samples: rust: debugfs_scoped: add example for blobs Danilo Krummrich
2025-10-20 10:02 ` Alice Ryhl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aPSzE7DpA7DxTHmm@google.com \
--to=aliceryhl@google.com \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=gary@garyguo.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=mmaurer@google.com \
--cc=ojeda@kernel.org \
--cc=rafael@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).