From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-179.mta0.migadu.com (out-179.mta0.migadu.com [91.218.175.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A711327B4E8 for ; Wed, 29 Oct 2025 01:00:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761699606; cv=none; b=BOs033C91vSNRoCs9PKyACiDjrG5/R0z1gk4/Lg+zgdfqYap09ftky7EHIOTU79Deottq77X7g7U7hFpeGoktQHa2mflwuHNrQYUaeKHk+Hfb72/PMea7kp0XUpVCVHBLX8H2JoFRzG/aCeiJ+kRIiHkL0vzwrzh8AMgK9LgYCc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761699606; c=relaxed/simple; bh=m2TntnE29Ayjgb90lea7jgHxSXwtxhfaO+9MYo3cUqA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=IlPckdgV6Ovjxe3DrlRCa20tkv59mfcV9blFm/1+gbSGeVEKHTbDKpQYgr7heeMlfKKfdESdpb2mEv7OLREZjAejcP8GJspHyvFEU8hK6srkSw0H2obIWxgZC2i2F15By7c6I3ra/yvV0wRC+9o4zK4pGpAnKQ8v2UGqK2dVvoI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=C+uHI4yJ; arc=none smtp.client-ip=91.218.175.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="C+uHI4yJ" Date: Wed, 29 Oct 2025 08:59:49 +0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1761699600; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=axfy//ogFDe/yGbFMo1sZMCFPL+4baIeWWIdu2LpDI8=; b=C+uHI4yJrnTWHNX09+K4A6XEe9JSPPUru03wyNSgVfHv61E7wLAa4TZ331QLDUnPoQ1P6E VjUIg4YW3JXeZ4EO+p4elnyhBy5vg944BCDQMdxymYkrakt5HKwr3RRDjZBvBZO2zy4wqQ Odu3Jg8x6KTSeZ3PTZpwj1+hNJQKZC4= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Troy Mitchell To: Michal Wilczynski , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?iso-8859-1?Q?Bj=F6rn?= Roy Baron , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Drew Fustini , Guo Ren , Fu Wei , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: Stephen Rothwell , rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org, linux-riscv@lists.infradead.org, Troy Mitchell Subject: Re: [PATCH 3/4] pwm: th1520: Use module_pwm_platform_driver! macro Message-ID: References: <20251028-pwm_fixes-v1-0-25a532d31998@samsung.com> <20251028-pwm_fixes-v1-3-25a532d31998@samsung.com> Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251028-pwm_fixes-v1-3-25a532d31998@samsung.com> X-Migadu-Flow: FLOW_OUT On Tue, Oct 28, 2025 at 01:22:34PM +0100, Michal Wilczynski wrote: > The `pwm_th1520` Rust driver calls C functions from the `PWM` namespace, > triggering `modpost` warnings due to missing namespace import > declarations in its `.modinfo` section. > > Fix these warnings and simplify the module declaration by switching from > the generic `kernel::module_platform_driver!` macro to the newly > introduced PWM-specific `kernel::module_pwm_platform_driver!` macro. > The new macro automatically handles the required `imports_ns: ["PWM"]` > declaration. > > Signed-off-by: Michal Wilczynski Reviewed-by: Troy Mitchell