From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f73.google.com (mail-ed1-f73.google.com [209.85.208.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4CED73081A5 for ; Mon, 10 Nov 2025 11:47:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.73 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762775235; cv=none; b=Cn13vhOtDjUaFKVhkAqlJTvb+g6Ex2Zc+WgI0wTfUjd+pMh6U5XklfFUArZG0dil/L4fON1hsyySIfqAXz+Sz8V7LJj1Tr9tTufzspR8SANRTfMHj0apKO61O6TQv7jKS8CFu0t5rwSUXjJexLCFXYwl+bKRlrOlFB2me3Eb22M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762775235; c=relaxed/simple; bh=UHsZ8mNOG8p7kZWeRQbdvDX87iavcoicnA0ph7mCQpM=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=U1sChejIWzk5MgqQrZxt7xMKF4aKYuoDvrW8wmVFkl0XoB1MaTbvkeoHmTboX+vE+iTqO7/s8lfsroay7AqnMUiFKJ6SVV3H2zj6R9IRyn7aYkCdRLT0rKlrXda4LsCu2oGgl63R1LuK8sRVgg04DrY/W7Gt4grtCDCXdBNq/ao= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--aliceryhl.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=DddieZtr; arc=none smtp.client-ip=209.85.208.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--aliceryhl.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="DddieZtr" Received: by mail-ed1-f73.google.com with SMTP id 4fb4d7f45d1cf-64091bef2ecso2878940a12.3 for ; Mon, 10 Nov 2025 03:47:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1762775232; x=1763380032; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=wUCZuS6iBZ+Cb2EbxYt/LbW22Q1kNekqfCyN5WYEYrk=; b=DddieZtr+YcRU6AGymXQ6+qbjn4EqfaO1LTBmOwgNdwd2GljS7zyb1RqN14kryvqia N4CCnwoDamx2Y13a+sxDntiCwG14T10uI1J2PP2gs/++M8u8KmFDWeVPTkhGVJkd7MnX /oPPoPxWLKuq2A52BHO8bifmzBZtHc3liXMbi/+mGONJAWn7rZvdMPNGtvI33lz2xU6u ysPgqzNiiCIF6TMslrx6yVp6I+MC/7t7lzsZtPs0OPXVU7TcmmQeLvkTdztdQx04qOp3 vFq+6Tapi87i1kL1hJdKBMxmoC7UO9aI5evD46DVTYrG6830K8SRDB/frUImVwp3+4NW P3dA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762775232; x=1763380032; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wUCZuS6iBZ+Cb2EbxYt/LbW22Q1kNekqfCyN5WYEYrk=; b=NuL5kOUBSJpo/aCEuOGZvkdUOnAv7r77XqutVcPKkss3khlp10JhH/ANCRf8df3mlS J6c9BTlKWsf6C14VWKWWT2gWRLRxl5mNXaifkX3+aXYvBuuDGQANpG0wbGCpQPGsm5s+ P+Se6PvQQEHv/G9kgx/cZJA2BraAoKdxdn4B/E7Ui6CCBtwFYcL/SzZfDTW7n7/TiyLX d5FSHpslIra6F8vqHJkWXa1HSxc3/FDydmHp4GxFrMkEZfMvx6nWJdiOlAsexLVVdjy8 KX/IvwC5nhxPWF3/s8cfT5o44MG2DcdkhJ+tWi8Kh+LgfI6//SGrJo4+9r5/zquwkQFE 63ow== X-Forwarded-Encrypted: i=1; AJvYcCWU/6X+lCtrVVzoucUoJ2Baxr2L2jtihs3qV7FY5F0ftMAzj9LM88aSTeikPdu43F+LhY3BfuKYD2U0617p1g==@vger.kernel.org X-Gm-Message-State: AOJu0Yy/oZ3oI6WQSvvn0hhn1q12EzOUmw9Pcb23fxENSB03PnfURtBW HLfCjNf8M09n3CcKT5aNd/ukHY+tgDcs3yyXmVQGUEz4znCTJXn+4U0uUUgHMDnBV6bg4vjr4ZA 9xY0QDIoHy1M8ySpspA== X-Google-Smtp-Source: AGHT+IHn/ARWRXnaz/QbEvpiXa66T27fjTbhbGtpITormFJQJJtBcOuO5FmSZ0Htawn8t+iKKDuDiXxfGYOF77I= X-Received: from edbin4.prod.google.com ([2002:a05:6402:2084:b0:641:8e3a:1196]) (user=aliceryhl job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6402:2106:b0:640:ef03:82c9 with SMTP id 4fb4d7f45d1cf-6415dc11781mr6885792a12.11.1762775232291; Mon, 10 Nov 2025 03:47:12 -0800 (PST) Date: Mon, 10 Nov 2025 11:47:11 +0000 In-Reply-To: <20251110095025.1475896-17-ojeda@kernel.org> Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20251110095025.1475896-1-ojeda@kernel.org> <20251110095025.1475896-17-ojeda@kernel.org> Message-ID: Subject: Re: [PATCH 16/18] rust: syn: remove `unicode-ident` dependency From: Alice Ryhl To: Miguel Ojeda Cc: Alex Gaynor , Nathan Chancellor , Nicolas Schier , Boqun Feng , Gary Guo , "=?utf-8?B?QmrDtnJu?= Roy Baron" , Benno Lossin , Andreas Hindborg , Trevor Gross , Danilo Krummrich , rust-for-linux@vger.kernel.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, patches@lists.linux.dev Content-Type: text/plain; charset="utf-8" On Mon, Nov 10, 2025 at 10:50:21AM +0100, Miguel Ojeda wrote: > The `syn` crate depends on the `unicode-ident` crate to determine whether > characters have the XID_Start or XID_Continue properties according to > Unicode Standard Annex #31. > > However, we only need ASCII identifiers in the kernel, thus we can > simplify the check and remove completely that dependency. > > Signed-off-by: Miguel Ojeda Reviewed-by: Alice Ryhl