From: Marko Turk <marko@markoturk.info>
To: Dirk Behme <dirk.behme@de.bosch.com>
Cc: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>,
dakr@kernel.org, bhelgaas@google.com, kwilczynski@kernel.org,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
rust-for-linux@vger.kernel.org
Subject: Re: [PATCH] samples: rust: fix endianness issue in rust_driver_pci
Date: Wed, 12 Nov 2025 11:24:10 +0100 [thread overview]
Message-ID: <aRRgSsOFGlt76E7o@vps.markoturk.info> (raw)
In-Reply-To: <7f3bb267-7cff-45e1-84a7-15245cffd99f@de.bosch.com>
On Wed, Nov 12, 2025 at 11:16:40AM +0100, Dirk Behme wrote:
> On 12/11/2025 10:37, Miguel Ojeda wrote:
> > On Wed, Nov 12, 2025 at 9:47 AM Marko Turk <mt@markoturk.info> wrote:
> > >
> > > On Sat, Nov 01, 2025 at 10:46:54PM +0100, Marko Turk wrote:
> > > > QEMU PCI test device specifies all registers as little endian. OFFSET
> > > > register is converted properly, but the COUNT register is not.
> > > >
> > > > Apply the same conversion to the COUNT register also.
> > > >
> > > > Signed-off-by: Marko Turk <mt@markoturk.info>
> > > > Fixes: 685376d18e9a ("samples: rust: add Rust PCI sample driver")
> > >
> > > Can someone take a look?
> >
> > Your message was in my spam folder -- that may be affecting who saw it.
> >
> > > From https://www.qemu.org/docs/master/specs/pci-testdev.html:
> >
> > "All registers are little endian."
> >
> > So this seems right. A couple tags:
> >
> > Cc: stable@vger.kernel.org
> > Link: https://www.qemu.org/docs/master/specs/pci-testdev.html
> >
> > Cc'ing Dirk, since he tested the sample originally.
>
>
> Hmm, I can't find the initial patch in my Inbox. Even
>
> https://lore.kernel.org/rust-for-linux/aRRJPZVkCv2i7kt2@vps.markoturk.info/
>
> doesn't seem to have it?
Initially I didn't send to rust-for-linux mailing list. It's here on lkml:
https://lore.kernel.org/lkml/20251101214629.10718-1-mt@markoturk.info/
Marko
next prev parent reply other threads:[~2025-11-12 10:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20251101214629.10718-1-mt@markoturk.info>
2025-11-12 8:45 ` [PATCH] samples: rust: fix endianness issue in rust_driver_pci Marko Turk
2025-11-12 9:37 ` Miguel Ojeda
2025-11-12 9:56 ` Miguel Ojeda
2025-11-13 8:22 ` Danilo Krummrich
2025-11-13 8:27 ` Miguel Ojeda
2025-11-13 8:36 ` Danilo Krummrich
2025-11-12 10:16 ` Dirk Behme
2025-11-12 10:24 ` Marko Turk [this message]
2025-11-12 10:24 ` Miguel Ojeda
2025-11-13 5:48 ` Dirk Behme
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aRRgSsOFGlt76E7o@vps.markoturk.info \
--to=marko@markoturk.info \
--cc=bhelgaas@google.com \
--cc=dakr@kernel.org \
--cc=dirk.behme@de.bosch.com \
--cc=kwilczynski@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=rust-for-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).