From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f180.google.com (mail-yw1-f180.google.com [209.85.128.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7F6B8306B3D for ; Wed, 12 Nov 2025 15:36:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762961799; cv=none; b=BLB6GcTsrkELQtFQAgq1XSxlTyWg7xetj4UoODFDpBL8yhxV0VhpnUQzl0J8vSUpKAov0kIl9QRotd0zhf+ixUBU7DOlcWi6o7uYpzB3UcEA26LGDevVFRpZij7A2n7QKhw3xUUnfgqT5OfpvNY7KyxrdpmnR4ES6Re+8gcbfAY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762961799; c=relaxed/simple; bh=gWt4GhgaA7NHHEj0scQGRtObc6Quxh/aMrfj5cn9fG8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=boJ4t7igTKutmXJhmhjB1Y+vNNpde/7sN1mavsEdph6JHo69h5sYZgXh62oWfA1PSUvxIXqyuVPVFsDK+KMzOdJ7FTegv/ppQQ0hNVwzVUxQIRyDfv3BSoCjSa5oL3hAgvCzzYeYa0vPDutmtTT1ZIWZxgr99RJbkDIf1RU7kpA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WLGJkeOb; arc=none smtp.client-ip=209.85.128.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WLGJkeOb" Received: by mail-yw1-f180.google.com with SMTP id 00721157ae682-787d5555274so10825067b3.1 for ; Wed, 12 Nov 2025 07:36:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1762961796; x=1763566596; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=4kqvDDCShqiS2PpLwW/nzEFL/oQKmShltN7b0zyK/U0=; b=WLGJkeOb6gscStONMZhQI6HpTRY3JJv4bKpP8Csf8MGESGbc85n0u99OiiPwEo10Tx w+Gbiowqu+/pzbvL2sAyLpnZq/rEOOYUo/jVG9GEGXFYAjL5DRMnMJnE9WMdyFHyYRHN c7S1+3C0zDfEzg8E5NfXDXKWJuBHReQOtV72FLn7X9hvFRg+1ooh/HvfBrrThfjaypU7 ubUWf1gdulhNZH1lNTlq5fLqZsUwWQxDDOIMfw2RUagl4Pj9AdtBWWOvS7UEh9DYLYSC pd5pCTRQoNRQjHOVf258yUM1AjYD6S4GI57o+prt5wBfF7OmCkpNWRMhnJKmxphoCm2k r79w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762961796; x=1763566596; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4kqvDDCShqiS2PpLwW/nzEFL/oQKmShltN7b0zyK/U0=; b=RTP0bQQy1IwJ5L5BcoaiLPX9Delc5HWtxpBLIK1R9wCH8/ARa7KIhxN6NyS+dmCN9f cD2NWO477VyDgx6P30kf99/TnJLvT+0QJvjbNHkG9Ub2EPzrHVlT5S4J8uJeLBwfdvfm 0ysjPlwAgcGM2cM8uMpVpQAOzoomg2fiG25Za9WHE/g8ml+vcaVfAaKTsTg9MK+LJ59B Riwr6kvanvxp76NHjMYSOoxvneAmavXYTqq+ldpOCMPHDxR0ZkQCyvmps817hJUV8FCh CPr6We+QVmnlMJ2TN1LcizUqyOK3v9of3D720jxM0ezHVfnKr30dhNLbRiR2dQElb8jZ Xbyg== X-Forwarded-Encrypted: i=1; AJvYcCVHhGdetVjysihoSaFBMlHluHdtPOQc4inQlxCYym3yXCXctD9Wz8zeo+0Qoh6zyeLH82nUMKIdiqP83p3q0w==@vger.kernel.org X-Gm-Message-State: AOJu0YwsZnEfPr8cB1AOOHaSGT2Yb3A6Nk13t1U3TCL1Joi7qPipkqC+ lBKwSbVcFVCdcaY8nV71mUn8cGaSJItFle2fS3iYS8p/Hn4lGFGfTqDs X-Gm-Gg: ASbGncsnRAWM9F1rbL4vGkCggV2dzE/vtwVtSNzHojkCUoYnB641LmzAfDyZbrQK69K cgX9reFWZCHitvl2pdMEV5qgirY983a7BcM619CkhGWb5J4avFGmpNEEAGeY07ahCx12utYa4GA wgIk2xKg+a98lpEQFy90BXrBwsmqM7Rv+pLSzkIqiCEXSwNbgoYddYEbVBWbwb6+ttc+4uUiUjz yxB1eJFRUIKcYgSUQFxxiRXJ3ezr5tpEInKrXRviVb4QYJk7WdSGvS4dRvQWPg9axo1IsMUtgjd r9GKLIl5DNruMt6WgdCervoELV2WvvjH8TF6QI6wBKSKLYSWQm8nj/p2tSIsLfvhsQOr/Hu7k7l 2nyKE1cG+/okyE6ChweohpFyH0PPlG9UlVAY4aufynFXBIat2EF8wj3eRiewoFn9KEvCEBfFGTW +60t8MmpGf9G7I/vcHWI0Kz5MDi4RxCWmt X-Google-Smtp-Source: AGHT+IF/7lMWkBQORDv0epmRSiUZ5L0YKXN3VP/iEjX/rkuf3OPjhQ99lzIb2UMOyMdVet7zqIVIiQ== X-Received: by 2002:a05:690c:4008:b0:786:433:1674 with SMTP id 00721157ae682-788136ee80emr24887777b3.54.1762961796498; Wed, 12 Nov 2025 07:36:36 -0800 (PST) Received: from localhost (c-73-105-0-253.hsd1.fl.comcast.net. [73.105.0.253]) by smtp.gmail.com with ESMTPSA id 00721157ae682-787d687e26esm42526157b3.27.2025.11.12.07.36.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Nov 2025 07:36:35 -0800 (PST) Date: Wed, 12 Nov 2025 10:36:33 -0500 From: Yury Norov To: Alice Ryhl Cc: Greg Kroah-Hartman , Arve =?iso-8859-1?B?SGr4bm5lduVn?= , Todd Kjos , Martijn Coenen , Joel Fernandes , Christian Brauner , Carlos Llamas , Suren Baghdasaryan , Burak Emir , Miguel Ojeda , Boqun Feng , Gary Guo , =?iso-8859-1?Q?Bj=F6rn?= Roy Baron , Benno Lossin , Andreas Hindborg , Trevor Gross , Danilo Krummrich , rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 2/6] rust: bitmap: add BitmapVec::new_inline() Message-ID: References: <20251112-binder-bitmap-v5-0-8b9d7c7eca82@google.com> <20251112-binder-bitmap-v5-2-8b9d7c7eca82@google.com> Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251112-binder-bitmap-v5-2-8b9d7c7eca82@google.com> On Wed, Nov 12, 2025 at 12:47:20PM +0000, Alice Ryhl wrote: > This constructor is useful when you just want to create a BitmapVec > without allocating but don't care how large it is. > > Acked-by: Yury Norov (NVIDIA) > Reviewed-by: Burak Emir > Reviewed-by: Danilo Krummrich > Signed-off-by: Alice Ryhl > --- > rust/kernel/bitmap.rs | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/rust/kernel/bitmap.rs b/rust/kernel/bitmap.rs > index 0705646c6251a49f213a45f1f013cb9eb2ed81de..bbbf0f9e5d9251953584581af57042143447b996 100644 > --- a/rust/kernel/bitmap.rs > +++ b/rust/kernel/bitmap.rs > @@ -230,6 +230,16 @@ impl BitmapVec { > /// The maximum length that uses the inline representation. > pub const MAX_INLINE_LEN: usize = usize::BITS as usize; > > + /// Construct a longest possible inline [`BitmapVec`]. > + #[inline] > + pub fn new_inline() -> Self { > + // INVARIANT: `nbits <= NO_ALLOC_MAX_LEN`, so an inline bitmap is the right repr. > + BitmapVec { > + repr: BitmapRepr { bitmap: 0 }, > + nbits: BitmapVec::NO_ALLOC_MAX_LEN, This should be MAX_INLINE_LEN, I guess? > + } > + } > + > /// Constructs a new [`BitmapVec`]. > /// > /// Fails with [`AllocError`] when the [`BitmapVec`] could not be allocated. This > > -- > 2.51.2.1041.gc1ab5b90ca-goog