From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f74.google.com (mail-wr1-f74.google.com [209.85.221.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C07F431B817 for ; Fri, 14 Nov 2025 13:50:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.74 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763128251; cv=none; b=C0B9fKwmGsEn6U0ExTLfOQUKGfi4JRxxh2/ziV9ZfYPkeU3ViZH7yuBBf5Wp0cUKWTk/QdiN+JYOPbQHeR+0wQIml92FzNMMR7DcO4cgnlF3ns/p/AnzdFkSP0cHRTXJxFUuGoy7AK7hpv7EFopuivhscYWCDW2CZoDj2Qhluak= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763128251; c=relaxed/simple; bh=CsIEbKP1oj7XlTEG+3Uocz8o2caJW9JzXXh9HJQrUiQ=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=cRt0ihAQAD1EZi6D04yCccMwbKwEbmhEsamZrnAsECEx6/Ln9dUI/WLAGifPIzRvy4+bllt1rPGTx0o8NgarHzo9JoVj3/DD/9xJ8wsqogTggSlh3urs75Jk4bKR2uquXNhjnYr4bu2vSg4tDi5ADPtxzNxKuz+uoZNEn3CwaZI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--aliceryhl.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=D0t10MRZ; arc=none smtp.client-ip=209.85.221.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--aliceryhl.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="D0t10MRZ" Received: by mail-wr1-f74.google.com with SMTP id ffacd0b85a97d-42b478551a6so1118370f8f.1 for ; Fri, 14 Nov 2025 05:50:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1763128248; x=1763733048; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=aRrI+zvBboCdfdse/X2BfoaixhuDzfAQTP9joVyOmZM=; b=D0t10MRZsMzAagfAcY0YldrrYNcStrIq8CuCwLgFCwF8CgnIdPtjNc2x5+DS3Gj9UU 7NGGkHRLG2TSprcCC40G6UZwTFOVvjKWfc27KPHafSDSM8p5nZHgmXuIGpP6G/x70yBt inGFdVn+AGo9cf9IB/3k6iwllkNPchP77IRglZBq+DZJCNe6U7aXZJzYyf9WK/Xlwd0A oJFzbSytCx5UobDRXYADa1iQ6zzE6KFMrzUNM4ZgEmGizRRmuJHfwJys1RN8BlxDen1Q mwgjWYawACQiSjBUMVGMVkG1yFpVstxmWMPYjLRLOR5e+x76hSq/a25zSK3Vg/gn8ZyN Euew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763128248; x=1763733048; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=aRrI+zvBboCdfdse/X2BfoaixhuDzfAQTP9joVyOmZM=; b=aMng4hfmBfVlbNkez9TmXP+wmsiUAnTGOROm77PmOGIpBCLq10K+w9IGXPr8eXKEBN fTI1BG/R9lLF3H+s12RtaMXSBupmlYjvhTSe/IPpNjUVvbgOPJBMBgYycWjt2GEJaoDY 6p+ttMI4XYLmsduIvDhHsS2sp+6WwK+KDFRuWWhhYl7W7HEyF5BrV3HnT3g8u5aI4BEp SbNOJSMZbyxVn8gPkqSAUE0MisNAZ0pPyeM9RIjhanz0St+DvZIHfYCkLCY8tTltr6Td YS28IRas7Hr0osUVPvk9EA1UcGDYHAj0flkMfWNMkp22Llq7tsst8BflMCwRWsKxY9fZ 22bg== X-Forwarded-Encrypted: i=1; AJvYcCW3XsIDpl6GdshDuJOLwM76DcEUgANgGVuSyURTwyxDuJPLrlkkJwlQaAQRuxdQFLr2xSRz+5Z2/HTAFLfsaA==@vger.kernel.org X-Gm-Message-State: AOJu0YzMX/jeTP9TP0eeZQhJddTP320Wxht7SjKxRWUruhf5kzJ0jC26 xcS10FQ8s1wPARRqhA0LHET3RiG/P+0cClONg9oRqcP8VgsPzqin5OaEILk4ptldnjYBtuXwC3l 96VklPxOE6c0aWoPdSA== X-Google-Smtp-Source: AGHT+IEy1IzfqWatibDXEefRnIBkZupbkLV4W34pV9YXz3HKgkrUUbyPksPnt2imV3NkIkiiyQrvQWIxaug0o/A= X-Received: from wrrn3.prod.google.com ([2002:adf:fe03:0:b0:42b:585e:3ca8]) (user=aliceryhl job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6000:144c:b0:42b:39ee:2889 with SMTP id ffacd0b85a97d-42b59374c26mr2988918f8f.48.1763128247691; Fri, 14 Nov 2025 05:50:47 -0800 (PST) Date: Fri, 14 Nov 2025 13:50:45 +0000 In-Reply-To: <6289d60b6731ea7a111c87c87fb8486881151c25.1763126447.git.lorenzo.stoakes@oracle.com> Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <6289d60b6731ea7a111c87c87fb8486881151c25.1763126447.git.lorenzo.stoakes@oracle.com> Message-ID: Subject: Re: [PATCH v2 1/4] mm: declare VMA flags by bit From: Alice Ryhl To: Lorenzo Stoakes Cc: Andrew Morton , Muchun Song , Oscar Salvador , David Hildenbrand , "Liam R . Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Axel Rasmussen , Yuanchu Xie , Wei Xu , Peter Xu , Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , Kees Cook , Matthew Wilcox , Jason Gunthorpe , John Hubbard , Leon Romanovsky , Zi Yan , Baolin Wang , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , Xu Xin , Chengming Zhou , Jann Horn , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , Pedro Falcato , Shakeel Butt , David Rientjes , Rik van Riel , Harry Yoo , Kemeng Shi , Kairui Song , Nhat Pham , Baoquan He , Chris Li , Johannes Weiner , Qi Zheng , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , Bjorn Roy Baron , Benno Lossin , Andreas Hindborg , Trevor Gross , Danilo Krummrich , rust-for-linux@vger.kernel.org Content-Type: text/plain; charset="utf-8" On Fri, Nov 14, 2025 at 01:26:08PM +0000, Lorenzo Stoakes wrote: > diff --git a/rust/bindings/bindings_helper.h b/rust/bindings/bindings_helper.h > index 2e43c66635a2..4c327db01ca0 100644 > --- a/rust/bindings/bindings_helper.h > +++ b/rust/bindings/bindings_helper.h > @@ -108,7 +108,32 @@ const xa_mark_t RUST_CONST_HELPER_XA_PRESENT = XA_PRESENT; > > const gfp_t RUST_CONST_HELPER_XA_FLAGS_ALLOC = XA_FLAGS_ALLOC; > const gfp_t RUST_CONST_HELPER_XA_FLAGS_ALLOC1 = XA_FLAGS_ALLOC1; > + > const vm_flags_t RUST_CONST_HELPER_VM_MERGEABLE = VM_MERGEABLE; > +const vm_flags_t RUST_CONST_HELPER_VM_READ = VM_READ; > +const vm_flags_t RUST_CONST_HELPER_VM_WRITE = VM_WRITE; > +const vm_flags_t RUST_CONST_HELPER_VM_EXEC = VM_EXEC; > +const vm_flags_t RUST_CONST_HELPER_VM_SHARED = VM_SHARED; > +const vm_flags_t RUST_CONST_HELPER_VM_MAYREAD = VM_MAYREAD; > +const vm_flags_t RUST_CONST_HELPER_VM_MAYWRITE = VM_MAYWRITE; > +const vm_flags_t RUST_CONST_HELPER_VM_MAYEXEC = VM_MAYEXEC; > +const vm_flags_t RUST_CONST_HELPER_VM_MAYSHARE = VM_MAYEXEC; > +const vm_flags_t RUST_CONST_HELPER_VM_PFNMAP = VM_PFNMAP; > +const vm_flags_t RUST_CONST_HELPER_VM_IO = VM_IO; > +const vm_flags_t RUST_CONST_HELPER_VM_DONTCOPY = VM_DONTCOPY; > +const vm_flags_t RUST_CONST_HELPER_VM_DONTEXPAND = VM_DONTEXPAND; > +const vm_flags_t RUST_CONST_HELPER_VM_LOCKONFAULT = VM_LOCKONFAULT; > +const vm_flags_t RUST_CONST_HELPER_VM_ACCOUNT = VM_ACCOUNT; > +const vm_flags_t RUST_CONST_HELPER_VM_NORESERVE = VM_NORESERVE; > +const vm_flags_t RUST_CONST_HELPER_VM_HUGETLB = VM_HUGETLB; > +const vm_flags_t RUST_CONST_HELPER_VM_SYNC = VM_SYNC; > +const vm_flags_t RUST_CONST_HELPER_VM_ARCH_1 = VM_ARCH_1; > +const vm_flags_t RUST_CONST_HELPER_VM_WIPEONFORK = VM_WIPEONFORK; > +const vm_flags_t RUST_CONST_HELPER_VM_DONTDUMP = VM_DONTDUMP; > +const vm_flags_t RUST_CONST_HELPER_VM_SOFTDIRTY = VM_SOFTDIRTY; > +const vm_flags_t RUST_CONST_HELPER_VM_MIXEDMAP = VM_MIXEDMAP; > +const vm_flags_t RUST_CONST_HELPER_VM_HUGEPAGE = VM_HUGEPAGE; > +const vm_flags_t RUST_CONST_HELPER_VM_NOHUGEPAGE = VM_NOHUGEPAGE; I got this error: error[E0428]: the name `VM_SOFTDIRTY` is defined multiple times --> rust/bindings/bindings_generated.rs:115967:1 | 13440 | pub const VM_SOFTDIRTY: u32 = 0; | -------------------------------- previous definition of the value `VM_SOFTDIRTY` here ... 115967 | pub const VM_SOFTDIRTY: vm_flags_t = 0; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ `VM_SOFTDIRTY` redefined here | = note: `VM_SOFTDIRTY` must be defined only once in the value namespace of this module Please add the constants in rust/bindgen_parameters next to ARCH_KMALLOC_MINALIGN to avoid this error. This ensures that only the version from bindings_helper.h is generated. Alice