From: Guangbo Cui <jckeep.cuiguangbo@gmail.com>
To: Danilo Krummrich <dakr@kernel.org>
Cc: "Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
rust-for-linux@vger.kernel.org, linux-pci@vger.kernel.org
Subject: Re: [RFC PATCH v1 0/2] rust: pci: Introduce PCIe error handler support and sample usage
Date: Sat, 15 Nov 2025 08:01:27 +0000 [thread overview]
Message-ID: <aRgzVyEMj2dnsSvM@2a2a0ba7cec8> (raw)
In-Reply-To: <DE5Q13AXWVZC.1NRFHPA8CSO0T@kernel.org>
On Tue, Nov 11, 2025 at 07:26:42PM +1100, Danilo Krummrich wrote:
> Thanks for the series, I will have a detailed look in a few weeks.
>
> I think this will be useful in the nova-core driver for instance. However, I
> wonder if you have another use-case you wrote this code for?
Hi Danilo,
Thanks for the feedback.
At the moment I don’t have a production driver making use of these
callbacks, only a few toy-level drivers I wrote for experimentation.
The main motivation for this RFC was that the Rust PCI layer currently lacks
parity with the C pci_error_handlers interface. Some parts of the PCI
subsystem (AER, recovery paths) need these callbacks, so having the Rust
side prepared seems useful for future drivers.
The sample driver is only meant to demonstrate the API surface and help discuss
the interface design. If the approach looks reasonable, I’m happy to iterate on
it or refine the API based on the feedback.
Best regards,
Guangbo
prev parent reply other threads:[~2025-11-15 8:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-08 16:55 [RFC PATCH v1 0/2] rust: pci: Introduce PCIe error handler support and sample usage Guangbo Cui
2025-11-08 16:55 ` [RFC PATCH v1 1/2] rust: pci: add PCIe bus error handler support Guangbo Cui
2025-11-08 16:55 ` [RFC PATCH v1 2/2] sample: rust: pci: implement dummy error handlers to demonstrate usage Guangbo Cui
2025-11-11 8:26 ` [RFC PATCH v1 0/2] rust: pci: Introduce PCIe error handler support and sample usage Danilo Krummrich
2025-11-15 8:01 ` Guangbo Cui [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aRgzVyEMj2dnsSvM@2a2a0ba7cec8 \
--to=jckeep.cuiguangbo@gmail.com \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=bhelgaas@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=gary@garyguo.net \
--cc=gregkh@linuxfoundation.org \
--cc=kwilczynski@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).