From: Alice Ryhl <aliceryhl@google.com>
To: Siddhesh Poyarekar <siddhesh@gotplt.org>
Cc: rust-for-linux@vger.kernel.org, Kees Cook <kees@kernel.org>,
Miguel Ojeda <ojeda@kernel.org>,
Boqun Feng <boqun.feng@gmail.com>, Gary Guo <gary@garyguo.net>
Subject: Re: [PATCH] rust: Add -fdiagnostics-show-context to bindgen_skip_c_flags
Date: Wed, 17 Dec 2025 20:46:49 +0000 [thread overview]
Message-ID: <aUMWuezmBHFnZUaM@google.com> (raw)
In-Reply-To: <20251217150010.665153-1-siddhesh@gotplt.org>
On Wed, Dec 17, 2025 at 10:00:10AM -0500, Siddhesh Poyarekar wrote:
> This got added with:
>
> 7454048db27d6 ("kbuild: Enable GCC diagnostic context for value-tracking warnings")
>
> but clang does not have this option, so avoid passing it to bindgen.
>
> Signed-off-by: Siddhesh Poyarekar <siddhesh@gotplt.org>
Seems like this should have a fixes tag for the offending commit, and cc
stable?
Alice
> rust/Makefile | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/rust/Makefile b/rust/Makefile
> index 5d357dce1704..4dcc2eff51cb 100644
> --- a/rust/Makefile
> +++ b/rust/Makefile
> @@ -383,6 +383,7 @@ bindgen_skip_c_flags := -mno-fp-ret-in-387 -mpreferred-stack-boundary=% \
> -fno-inline-functions-called-once -fsanitize=bounds-strict \
> -fstrict-flex-arrays=% -fmin-function-alignment=% \
> -fzero-init-padding-bits=% -mno-fdpic \
> + -fdiagnostics-show-context -fdiagnostics-show-context=% \
> --param=% --param asan-% -fno-isolate-erroneous-paths-dereference
>
> # Derived from `scripts/Makefile.clang`.
> --
> 2.52.0
>
next prev parent reply other threads:[~2025-12-17 20:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-17 15:00 [PATCH] rust: Add -fdiagnostics-show-context to bindgen_skip_c_flags Siddhesh Poyarekar
2025-12-17 20:46 ` Alice Ryhl [this message]
2025-12-17 22:41 ` Siddhesh Poyarekar
2025-12-17 22:40 ` [PATCH v2] " Siddhesh Poyarekar
2026-01-04 20:53 ` Miguel Ojeda
2026-01-05 10:58 ` Siddhesh Poyarekar
2026-01-05 23:03 ` Nathan Chancellor
2026-01-06 20:01 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aUMWuezmBHFnZUaM@google.com \
--to=aliceryhl@google.com \
--cc=boqun.feng@gmail.com \
--cc=gary@garyguo.net \
--cc=kees@kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=siddhesh@gotplt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox