From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Alice Ryhl <aliceryhl@google.com>
Cc: "Petr Mladek" <pmladek@suse.com>, "Ke Sun" <sunke@kylinos.cn>,
"Dirk Behme" <dirk.behme@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Steven Rostedt" <rostedt@goodmis.org>,
"Timur Tabi" <ttabi@nvidia.com>,
"Danilo Krummrich" <dakr@kernel.org>,
"Benno Lossin" <lossin@kernel.org>,
"John Ogness" <john.ogness@linutronix.de>,
"Rasmus Villemoes" <linux@rasmusvillemoes.dk>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Trevor Gross" <tmgross@umich.edu>,
"Tamir Duberstein" <tamird@gmail.com>,
"Ke Sun" <sk.alvin.x@gmail.com>,
rust-for-linux@vger.kernel.org
Subject: Re: [PATCH v8 3/4] rust: fmt: Default raw pointer formatting to HashedPtr
Date: Tue, 6 Jan 2026 23:00:15 +0200 [thread overview]
Message-ID: <aV133_IhL91g1PuA@smile.fi.intel.com> (raw)
In-Reply-To: <aV1D8d8EyuzwQhHK@google.com>
On Tue, Jan 06, 2026 at 05:18:41PM +0000, Alice Ryhl wrote:
> On Tue, Jan 06, 2026 at 05:45:37PM +0100, Petr Mladek wrote:
> > On Mon 2026-01-05 08:19:49, Alice Ryhl wrote:
...
> If I write this code in normal Rust:
>
> let ptr = &3 as *const i32;
> println!("{:?}", ptr);
> println!("{:017?}", ptr);
> println!("{:17?}", ptr);
>
> it prints:
>
> 0x602ae0ec95d8
> 0x000602ae0ec95d8
> 0x602ae0ec95d8
>
> If we implement {:?} on a raw pointer type (and {:p} on reference type)
> to use scnprintf with a stack buffer for the string representation, then
> we lose this flexibility. (Or we need additional effort to pass through
> the various ways you can configure it to scnprintf.)
I think the field width or variations make a little sense on pointers. AFAIR
printf() in kernel ignores field width and padding modifications to a pointer.
Only size of the end buffer may cut the string in the middle.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-01-06 21:00 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-01 8:16 [PATCH v8 0/4] rust: Add safe pointer formatting support Ke Sun
2026-01-01 8:16 ` [PATCH v8 1/4] lib/vsprintf: Export ptr_to_hashval() for Rust kernel crate use Ke Sun
2026-01-02 12:15 ` Andy Shevchenko
2026-01-01 8:16 ` [PATCH v8 2/4] rust: kernel: Add pointer wrapper types for safe pointer formatting Ke Sun
2026-01-02 7:57 ` Dirk Behme
2026-01-02 11:06 ` Gary Guo
2026-01-02 11:13 ` Gary Guo
2026-01-02 12:17 ` Andy Shevchenko
2026-01-02 12:33 ` Danilo Krummrich
2026-01-02 12:43 ` Ke Sun
2026-01-01 8:16 ` [PATCH v8 3/4] rust: fmt: Default raw pointer formatting to HashedPtr Ke Sun
2026-01-02 11:17 ` Gary Guo
2026-01-02 17:39 ` Petr Mladek
2026-01-05 8:19 ` Alice Ryhl
2026-01-06 3:06 ` Ke Sun
2026-01-06 16:45 ` Petr Mladek
2026-01-06 17:18 ` Alice Ryhl
2026-01-06 21:00 ` Andy Shevchenko [this message]
2026-01-06 21:06 ` Alice Ryhl
2026-01-01 8:16 ` [PATCH v8 4/4] docs: rust: Add pointer formatting documentation Ke Sun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aV133_IhL91g1PuA@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=a.hindborg@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=aliceryhl@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=dirk.behme@gmail.com \
--cc=gary@garyguo.net \
--cc=john.ogness@linutronix.de \
--cc=linux@rasmusvillemoes.dk \
--cc=lossin@kernel.org \
--cc=ojeda@kernel.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=sk.alvin.x@gmail.com \
--cc=sunke@kylinos.cn \
--cc=tamird@gmail.com \
--cc=tmgross@umich.edu \
--cc=ttabi@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox