public inbox for rust-for-linux@vger.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: "Gary Guo" <gary@garyguo.net>,
	"Peter Zijlstra" <peterz@infradead.org>,
	"Ingo Molnar" <mingo@redhat.com>,
	"Mark Rutland" <mark.rutland@arm.com>,
	"Alexander Shishkin" <alexander.shishkin@linux.intel.com>,
	"Jiri Olsa" <jolsa@kernel.org>, "Ian Rogers" <irogers@google.com>,
	"Adrian Hunter" <adrian.hunter@intel.com>,
	"James Clark" <james.clark@linaro.org>,
	"Miguel Ojeda" <ojeda@kernel.org>,
	"Boqun Feng" <boqun.feng@gmail.com>,
	"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
	"Benno Lossin" <lossin@kernel.org>,
	"Andreas Hindborg" <a.hindborg@kernel.org>,
	"Alice Ryhl" <aliceryhl@google.com>,
	"Trevor Gross" <tmgross@umich.edu>,
	"Danilo Krummrich" <dakr@kernel.org>,
	"Nathan Chancellor" <nathan@kernel.org>,
	"Nick Desaulniers" <nick.desaulniers+lkml@gmail.com>,
	"Bill Wendling" <morbo@google.com>,
	"Justin Stitt" <justinstitt@google.com>,
	"Andi Kleen" <ak@linux.intel.com>,
	"Dmitry Vyukov" <dvyukov@google.com>,
	"Stephen Brennan" <stephen.s.brennan@oracle.com>,
	"Arnaldo Carvalho de Melo" <acme@redhat.com>,
	linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
	rust-for-linux@vger.kernel.org, llvm@lists.linux.dev
Subject: Re: [PATCH v2] perf symbol: remove Rust symbol workarounds
Date: Wed, 7 Jan 2026 10:38:40 -0300	[thread overview]
Message-ID: <aV5h4I5rRl61vFFu@x1> (raw)
In-Reply-To: <aV4TkNE_hAyByISq@google.com>

On Wed, Jan 07, 2026 at 12:04:32AM -0800, Namhyung Kim wrote:
> On Mon, Jan 05, 2026 at 12:50:15PM -0300, Arnaldo Carvalho de Melo wrote:
> > On Mon, Jan 05, 2026 at 03:00:57PM +0000, Gary Guo wrote:
> > > Due to an off-by-one error introduced in commit 73bbb94466fd ("kallsyms:
> > > support "big" kernel symbols"), long symbols (which are currently only
> > > produced by Rust) can have their symbol type being wrongly parsed by
> > > kernel/kallsyms.c.
 
> > Looks sane, applied to perf-tools-next,
   
> I'm afraid there may be some outdated kernels which don't have the fix
> yet.  Maybe make sense to wait some more time for them to disappear?

Right, I took it more as it seems to be just a blip in time, something
that came and went quickly and that most likely will not cause problems,
i.e. just a handful of extra symbols in the lookup data structures in
those particular kernels and a new 'perf test' tool with these reverts,
if run on those particular kernels would then fail for that particular
test case, for a known reason.

So with the above rationale you still feel strongly about having it
applied?

- Arnaldo

  parent reply	other threads:[~2026-01-07 13:38 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-05 15:00 [PATCH v2] perf symbol: remove Rust symbol workarounds Gary Guo
2026-01-05 15:50 ` Arnaldo Carvalho de Melo
2026-01-07  8:04   ` Namhyung Kim
2026-01-07 11:59     ` Miguel Ojeda
2026-01-07 18:22       ` Namhyung Kim
2026-01-07 18:25         ` Miguel Ojeda
2026-01-07 13:38     ` Arnaldo Carvalho de Melo [this message]
2026-01-07 18:18       ` Namhyung Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aV5h4I5rRl61vFFu@x1 \
    --to=acme@kernel.org \
    --cc=a.hindborg@kernel.org \
    --cc=acme@redhat.com \
    --cc=adrian.hunter@intel.com \
    --cc=ak@linux.intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=aliceryhl@google.com \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun.feng@gmail.com \
    --cc=dakr@kernel.org \
    --cc=dvyukov@google.com \
    --cc=gary@garyguo.net \
    --cc=irogers@google.com \
    --cc=james.clark@linaro.org \
    --cc=jolsa@kernel.org \
    --cc=justinstitt@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=llvm@lists.linux.dev \
    --cc=lossin@kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mingo@redhat.com \
    --cc=morbo@google.com \
    --cc=namhyung@kernel.org \
    --cc=nathan@kernel.org \
    --cc=nick.desaulniers+lkml@gmail.com \
    --cc=ojeda@kernel.org \
    --cc=peterz@infradead.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=stephen.s.brennan@oracle.com \
    --cc=tmgross@umich.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox