* [PATCH] rust: dma: remove incorrect safety documentation
@ 2025-12-26 16:10 Yilin Chen
2025-12-28 9:37 ` Alice Ryhl
0 siblings, 1 reply; 2+ messages in thread
From: Yilin Chen @ 2025-12-26 16:10 UTC (permalink / raw)
To: Danilo Krummrich, Miguel Ojeda; +Cc: rust-for-linux, linux-kernel, Yilin Chen
Removes a safety requirement that incorrectly states callers must
ensure the device does not access memory while the returned slice
is live, as this method doesn't return a slice.
Signed-off-by: Yilin <1479826151@qq.com>
---
rust/kernel/dma.rs | 2 --
1 file changed, 2 deletions(-)
diff --git a/rust/kernel/dma.rs b/rust/kernel/dma.rs
index 84d3c67269e8..2ac107d8f7b7 100644
--- a/rust/kernel/dma.rs
+++ b/rust/kernel/dma.rs
@@ -532,8 +532,6 @@ pub unsafe fn as_slice_mut(&mut self, offset: usize, count: usize) -> Result<&mu
///
/// # Safety
///
- /// * Callers must ensure that the device does not read/write to/from memory while the returned
- /// slice is live.
/// * Callers must ensure that this call does not race with a read or write to the same region
/// that overlaps with this write.
///
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] rust: dma: remove incorrect safety documentation
2025-12-26 16:10 [PATCH] rust: dma: remove incorrect safety documentation Yilin Chen
@ 2025-12-28 9:37 ` Alice Ryhl
0 siblings, 0 replies; 2+ messages in thread
From: Alice Ryhl @ 2025-12-28 9:37 UTC (permalink / raw)
To: Yilin Chen; +Cc: Danilo Krummrich, Miguel Ojeda, rust-for-linux, linux-kernel
On Sat, Dec 27, 2025 at 12:10:27AM +0800, Yilin Chen wrote:
> Removes a safety requirement that incorrectly states callers must
> ensure the device does not access memory while the returned slice
> is live, as this method doesn't return a slice.
>
> Signed-off-by: Yilin <1479826151@qq.com>
This patch looks good to me, but the Signed-off-by does not match
your From: line. Please update this to:
Signed-off-by: Yilin Chen <1479826151@qq.com>
so that it matches the From: line.
Alice
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-12-28 9:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-26 16:10 [PATCH] rust: dma: remove incorrect safety documentation Yilin Chen
2025-12-28 9:37 ` Alice Ryhl
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox