From: Alice Ryhl <aliceryhl@google.com>
To: FUJITA Tomonori <fujita.tomonori@gmail.com>
Cc: jpoimboe@kernel.org, peterz@infradead.org, ojeda@kernel.org,
a.hindborg@kernel.org, bjorn3_gh@protonmail.com,
boqun.feng@gmail.com, dakr@kernel.org, gary@garyguo.net,
lossin@kernel.org, tmgross@umich.edu,
linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org
Subject: Re: [PATCH v1] objtool/rust: add one more `noreturn` Rust function
Date: Sun, 28 Dec 2025 10:31:28 +0000 [thread overview]
Message-ID: <aVEHAMrk5RzSy7Yn@google.com> (raw)
In-Reply-To: <20251223113538.1016078-1-fujita.tomonori@gmail.com>
On Tue, Dec 23, 2025 at 08:35:38PM +0900, FUJITA Tomonori wrote:
> Fix the follwoing warning:
>
> rust/kernel.o: warning: objtool: _RNvXNtNtCs1ewLyjEZ7Le_6kernel3str9parse_intaNtNtB2_7private12FromStrRadix14from_str_radix()
> falls through to next function _RNvXNtNtCs1ewLyjEZ7Le_6kernel3str9parse_intaNtNtB2_7private12FromStrRadix16from_u64_negated()
>
> The commit 51d9ee90ea90 ("rust: str: add radix prefixed integer
> parsing functions") introduces u64::from_str_radix(), whose
> implementation contains a panic path for out-of-range radix values.
> The panic helper is core::num::from_ascii_radix_panic().
>
> Note that radix is derived from strip_radix() here and is always
> within the valid range, so kernel never panics.
>
> Fixes: 51d9ee90ea90 ("rust: str: add radix prefixed integer parsing functions")
> Signed-off-by: FUJITA Tomonori <fujita.tomonori@gmail.com>
Reviewed-by: Alice Ryhl <aliceryhl@google.com>
Tested-by: Alice Ryhl <aliceryhl@google.com>
next prev parent reply other threads:[~2025-12-28 10:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-23 11:35 [PATCH v1] objtool/rust: add one more `noreturn` Rust function FUJITA Tomonori
2025-12-28 10:31 ` Alice Ryhl [this message]
2026-01-04 22:55 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aVEHAMrk5RzSy7Yn@google.com \
--to=aliceryhl@google.com \
--cc=a.hindborg@kernel.org \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=fujita.tomonori@gmail.com \
--cc=gary@garyguo.net \
--cc=jpoimboe@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=ojeda@kernel.org \
--cc=peterz@infradead.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox