public inbox for rust-for-linux@vger.kernel.org
 help / color / mirror / Atom feed
From: Deborah Brouwer <deborah.brouwer@collabora.com>
To: Dirk Behme <dirk.behme@de.bosch.com>
Cc: rust-for-linux@vger.kernel.org, daniel.almeida@collabora.com,
	aliceryhl@google.com, dri-devel@lists.freedesktop.org,
	ojeda@kernel.org, boqun.feng@gmail.com, gary@garyguo.net,
	a.hindborg@kernel.org, dakr@kernel.org
Subject: Re: [PATCH] rust: drm: tyr: Fix register name in error print
Date: Mon, 19 Jan 2026 12:36:34 -0800	[thread overview]
Message-ID: <aW6V0gn4mLiCUu1q@um790> (raw)
In-Reply-To: <20260119070838.3219739-1-dirk.behme@de.bosch.com>

On Mon, Jan 19, 2026 at 08:08:38AM +0100, Dirk Behme wrote:
> The `..IRQ..` register is printed here. Not the `..INT..` one.
> Correct this.

Hi Dirk, I was hoping to get rid of this register read since it's really
just a bit of debugging, and it's the timeout error that is of more
interest.

What do you think of handling this through my read_poll_timeout changes
instead?

https://lore.kernel.org/rust-for-linux/20260119202645.362457-1-deborah.brouwer@collabora.com/

Thanks,
Deborah

> 
> Fixes: cf4fd52e3236 ("rust: drm: Introduce the Tyr driver for Arm Mali GPUs")
> Link: https://lore.kernel.org/rust-for-linux/A04F0357-896E-4ACC-BC0E-DEE8608CE518@collabora.com/
> Signed-off-by: Dirk Behme <dirk.behme@de.bosch.com>
> ---
>  drivers/gpu/drm/tyr/driver.rs | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/tyr/driver.rs b/drivers/gpu/drm/tyr/driver.rs
> index 0389c558c0367..3047fd12fd849 100644
> --- a/drivers/gpu/drm/tyr/driver.rs
> +++ b/drivers/gpu/drm/tyr/driver.rs
> @@ -76,7 +76,7 @@ fn issue_soft_reset(dev: &Device<Bound>, iomem: &Devres<IoMem>) -> Result {
>          dev_err!(dev, "GPU reset failed with errno\n");
>          dev_err!(
>              dev,
> -            "GPU_INT_RAWSTAT is {}\n",
> +            "GPU_IRQ_RAWSTAT is {}\n",
>              regs::GPU_IRQ_RAWSTAT.read(dev, iomem)?
>          );
>  
> -- 
> 2.48.0
> 

  parent reply	other threads:[~2026-01-19 20:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-19  7:08 [PATCH] rust: drm: tyr: Fix register name in error print Dirk Behme
2026-01-19  8:35 ` Miguel Ojeda
2026-01-19 20:36 ` Deborah Brouwer [this message]
2026-01-20  8:07   ` Alice Ryhl
2026-01-20  9:08 ` Alice Ryhl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aW6V0gn4mLiCUu1q@um790 \
    --to=deborah.brouwer@collabora.com \
    --cc=a.hindborg@kernel.org \
    --cc=aliceryhl@google.com \
    --cc=boqun.feng@gmail.com \
    --cc=dakr@kernel.org \
    --cc=daniel.almeida@collabora.com \
    --cc=dirk.behme@de.bosch.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gary@garyguo.net \
    --cc=ojeda@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox