From: Alice Ryhl <aliceryhl@google.com>
To: Deborah Brouwer <deborah.brouwer@collabora.com>
Cc: Dirk Behme <dirk.behme@de.bosch.com>,
rust-for-linux@vger.kernel.org, daniel.almeida@collabora.com,
dri-devel@lists.freedesktop.org, ojeda@kernel.org,
boqun.feng@gmail.com, gary@garyguo.net, a.hindborg@kernel.org,
dakr@kernel.org
Subject: Re: [PATCH] rust: drm: tyr: Fix register name in error print
Date: Tue, 20 Jan 2026 08:07:49 +0000 [thread overview]
Message-ID: <aW831WHs-O-OCWAl@google.com> (raw)
In-Reply-To: <aW6V0gn4mLiCUu1q@um790>
On Mon, Jan 19, 2026 at 12:36:34PM -0800, Deborah Brouwer wrote:
> On Mon, Jan 19, 2026 at 08:08:38AM +0100, Dirk Behme wrote:
> > The `..IRQ..` register is printed here. Not the `..INT..` one.
> > Correct this.
>
> Hi Dirk, I was hoping to get rid of this register read since it's really
> just a bit of debugging, and it's the timeout error that is of more
> interest.
>
> What do you think of handling this through my read_poll_timeout changes
> instead?
>
> https://lore.kernel.org/rust-for-linux/20260119202645.362457-1-deborah.brouwer@collabora.com/
We can always merge Dirk's change and then yours on top (removing said
piece of code). That way, if the stable team feels like backporting the
typofix, they can, and otherwise there's no harm either.
Alice
next prev parent reply other threads:[~2026-01-20 8:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-19 7:08 [PATCH] rust: drm: tyr: Fix register name in error print Dirk Behme
2026-01-19 8:35 ` Miguel Ojeda
2026-01-19 20:36 ` Deborah Brouwer
2026-01-20 8:07 ` Alice Ryhl [this message]
2026-01-20 9:08 ` Alice Ryhl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aW831WHs-O-OCWAl@google.com \
--to=aliceryhl@google.com \
--cc=a.hindborg@kernel.org \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=daniel.almeida@collabora.com \
--cc=deborah.brouwer@collabora.com \
--cc=dirk.behme@de.bosch.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gary@garyguo.net \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox