[PATCH] rust: drm: tyr: Fix register name in error print

[PATCH] rust: drm: tyr: Fix register name in error print

[Dirk Behme]

The `..IRQ..` register is printed here. Not the `..INT..` one.
Correct this.

Fixes: cf4fd52e3236 ("rust: drm: Introduce the Tyr driver for Arm Mali GPUs")
Link: https://lore.kernel.org/rust-for-linux/A04F0357-896E-4ACC-BC0E-DEE8608CE518@collabora.com/
Signed-off-by: Dirk Behme <dirk.behme@de.bosch.com>
---
 drivers/gpu/drm/tyr/driver.rs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/tyr/driver.rs b/drivers/gpu/drm/tyr/driver.rs
index 0389c558c0367..3047fd12fd849 100644
--- a/drivers/gpu/drm/tyr/driver.rs
+++ b/drivers/gpu/drm/tyr/driver.rs
@@ -76,7 +76,7 @@ fn issue_soft_reset(dev: &Device<Bound>, iomem: &Devres<IoMem>) -> Result {
         dev_err!(dev, "GPU reset failed with errno\n");
         dev_err!(
             dev,
-            "GPU_INT_RAWSTAT is {}\n",
+            "GPU_IRQ_RAWSTAT is {}\n",
             regs::GPU_IRQ_RAWSTAT.read(dev, iomem)?
         );
 
-- 
2.48.0

Re: [PATCH] rust: drm: tyr: Fix register name in error print

[Miguel Ojeda]

On Mon, Jan 19, 2026 at 8:09 AM Dirk Behme <dirk.behme@de.bosch.com> wrote:
>
> Fixes: cf4fd52e3236 ("rust: drm: Introduce the Tyr driver for Arm Mali GPUs")

Perhaps not worth backporting, but it could be, so before Greg's bot
replies I will add the tag for consideration here... :)

    Cc: stable@vger.kernel.org

Cheers,
Miguel

Re: [PATCH] rust: drm: tyr: Fix register name in error print

[Deborah Brouwer]

On Mon, Jan 19, 2026 at 08:08:38AM +0100, Dirk Behme wrote:
> The `..IRQ..` register is printed here. Not the `..INT..` one.
> Correct this.

Hi Dirk, I was hoping to get rid of this register read since it's really
just a bit of debugging, and it's the timeout error that is of more
interest.

What do you think of handling this through my read_poll_timeout changes
instead?

https://lore.kernel.org/rust-for-linux/20260119202645.362457-1-deborah.brouwer@collabora.com/

Thanks,
Deborah

> 
> Fixes: cf4fd52e3236 ("rust: drm: Introduce the Tyr driver for Arm Mali GPUs")
> Link: https://lore.kernel.org/rust-for-linux/A04F0357-896E-4ACC-BC0E-DEE8608CE518@collabora.com/
> Signed-off-by: Dirk Behme <dirk.behme@de.bosch.com>
> ---
>  drivers/gpu/drm/tyr/driver.rs | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/tyr/driver.rs b/drivers/gpu/drm/tyr/driver.rs
> index 0389c558c0367..3047fd12fd849 100644
> --- a/drivers/gpu/drm/tyr/driver.rs
> +++ b/drivers/gpu/drm/tyr/driver.rs
> @@ -76,7 +76,7 @@ fn issue_soft_reset(dev: &Device<Bound>, iomem: &Devres<IoMem>) -> Result {
>          dev_err!(dev, "GPU reset failed with errno\n");
>          dev_err!(
>              dev,
> -            "GPU_INT_RAWSTAT is {}\n",
> +            "GPU_IRQ_RAWSTAT is {}\n",
>              regs::GPU_IRQ_RAWSTAT.read(dev, iomem)?
>          );
>  
> -- 
> 2.48.0
> 

Re: [PATCH] rust: drm: tyr: Fix register name in error print

[Alice Ryhl]

On Mon, Jan 19, 2026 at 12:36:34PM -0800, Deborah Brouwer wrote:
> On Mon, Jan 19, 2026 at 08:08:38AM +0100, Dirk Behme wrote:
> > The `..IRQ..` register is printed here. Not the `..INT..` one.
> > Correct this.
> 
> Hi Dirk, I was hoping to get rid of this register read since it's really
> just a bit of debugging, and it's the timeout error that is of more
> interest.
> 
> What do you think of handling this through my read_poll_timeout changes
> instead?
> 
> https://lore.kernel.org/rust-for-linux/20260119202645.362457-1-deborah.brouwer@collabora.com/

We can always merge Dirk's change and then yours on top (removing said
piece of code). That way, if the stable team feels like backporting the
typofix, they can, and otherwise there's no harm either.

Alice

Re: [PATCH] rust: drm: tyr: Fix register name in error print

[Alice Ryhl]

On Mon, Jan 19, 2026 at 08:08:38AM +0100, Dirk Behme wrote:
> The `..IRQ..` register is printed here. Not the `..INT..` one.
> Correct this.
> 
> Fixes: cf4fd52e3236 ("rust: drm: Introduce the Tyr driver for Arm Mali GPUs")
> Link: https://lore.kernel.org/rust-for-linux/A04F0357-896E-4ACC-BC0E-DEE8608CE518@collabora.com/
> Signed-off-by: Dirk Behme <dirk.behme@de.bosch.com>

Merged into drm-rust-next, thanks!

[aliceryhl: update commit message prefix]
[aliceryhl: add cc stable as per Miguel's suggestion]