* [PATCH] rust: auxiliary: fix remove_callback invariant comment
@ 2026-01-10 11:48 Alok Tiwari
2026-01-12 9:16 ` Alice Ryhl
2026-01-13 12:09 ` Danilo Krummrich
0 siblings, 2 replies; 3+ messages in thread
From: Alok Tiwari @ 2026-01-10 11:48 UTC (permalink / raw)
To: dakr, tmgross, aliceryhl, a.hindborg, lossin, bjorn3_gh, gary,
boqun.feng, ojeda, leon, ira.weiny, david.m.ertman,
rust-for-linux, gregkh
Cc: alok.a.tiwarilinux, alok.a.tiwari
Correct copy-paste errors where remove_callback safety invariants
incorrectly referenced probe_callback().
Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
---
rust/kernel/auxiliary.rs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/rust/kernel/auxiliary.rs b/rust/kernel/auxiliary.rs
index 56f3c180e8f6..6cd7dee6c476 100644
--- a/rust/kernel/auxiliary.rs
+++ b/rust/kernel/auxiliary.rs
@@ -81,7 +81,7 @@ extern "C" fn remove_callback(adev: *mut bindings::auxiliary_device) {
// SAFETY: The auxiliary bus only ever calls the probe callback with a valid pointer to a
// `struct auxiliary_device`.
//
- // INVARIANT: `adev` is valid for the duration of `probe_callback()`.
+ // INVARIANT: `adev` is valid for the duration of `remove_callback()`.
let adev = unsafe { &*adev.cast::<Device<device::CoreInternal>>() };
// SAFETY: `remove_callback` is only ever called after a successful call to
--
2.50.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] rust: auxiliary: fix remove_callback invariant comment
2026-01-10 11:48 [PATCH] rust: auxiliary: fix remove_callback invariant comment Alok Tiwari
@ 2026-01-12 9:16 ` Alice Ryhl
2026-01-13 12:09 ` Danilo Krummrich
1 sibling, 0 replies; 3+ messages in thread
From: Alice Ryhl @ 2026-01-12 9:16 UTC (permalink / raw)
To: Alok Tiwari
Cc: dakr, tmgross, a.hindborg, lossin, bjorn3_gh, gary, boqun.feng,
ojeda, leon, ira.weiny, david.m.ertman, rust-for-linux, gregkh,
alok.a.tiwarilinux
On Sat, Jan 10, 2026 at 03:48:13AM -0800, Alok Tiwari wrote:
> Correct copy-paste errors where remove_callback safety invariants
> incorrectly referenced probe_callback().
>
> Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
Reviewed-by: Alice Ryhl <aliceryhl@google.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] rust: auxiliary: fix remove_callback invariant comment
2026-01-10 11:48 [PATCH] rust: auxiliary: fix remove_callback invariant comment Alok Tiwari
2026-01-12 9:16 ` Alice Ryhl
@ 2026-01-13 12:09 ` Danilo Krummrich
1 sibling, 0 replies; 3+ messages in thread
From: Danilo Krummrich @ 2026-01-13 12:09 UTC (permalink / raw)
To: Alok Tiwari
Cc: tmgross, aliceryhl, a.hindborg, lossin, bjorn3_gh, gary,
boqun.feng, ojeda, leon, ira.weiny, david.m.ertman,
rust-for-linux, gregkh, alok.a.tiwarilinux
On Sat Jan 10, 2026 at 12:48 PM CET, Alok Tiwari wrote:
> Correct copy-paste errors where remove_callback safety invariants
> incorrectly referenced probe_callback().
>
> Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
Applied to driver-core-testing, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-01-13 12:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-10 11:48 [PATCH] rust: auxiliary: fix remove_callback invariant comment Alok Tiwari
2026-01-12 9:16 ` Alice Ryhl
2026-01-13 12:09 ` Danilo Krummrich
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox