* [PATCH] rust: platform: fix remove_callback invariant comment
@ 2026-01-10 11:51 Alok Tiwari
2026-01-12 9:16 ` Alice Ryhl
2026-01-13 12:09 ` Danilo Krummrich
0 siblings, 2 replies; 3+ messages in thread
From: Alok Tiwari @ 2026-01-10 11:51 UTC (permalink / raw)
To: rafael, dakr, tmgross, aliceryhl, a.hindborg, lossin, bjorn3_gh,
gary, boqun.feng, ojeda, rust-for-linux, gregkh
Cc: alok.a.tiwarilinux, alok.a.tiwari
Correct copy-paste errors where remove_callback safety invariants
incorrectly referenced probe_callback().
Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
---
rust/kernel/platform.rs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/rust/kernel/platform.rs b/rust/kernel/platform.rs
index bddb593cee7b..29f00e4e54a2 100644
--- a/rust/kernel/platform.rs
+++ b/rust/kernel/platform.rs
@@ -86,7 +86,7 @@ extern "C" fn remove_callback(pdev: *mut bindings::platform_device) {
// SAFETY: The platform bus only ever calls the remove callback with a valid pointer to a
// `struct platform_device`.
//
- // INVARIANT: `pdev` is valid for the duration of `probe_callback()`.
+ // INVARIANT: `pdev` is valid for the duration of `remove_callback()`.
let pdev = unsafe { &*pdev.cast::<Device<device::CoreInternal>>() };
// SAFETY: `remove_callback` is only ever called after a successful call to
--
2.50.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] rust: platform: fix remove_callback invariant comment
2026-01-10 11:51 [PATCH] rust: platform: fix remove_callback invariant comment Alok Tiwari
@ 2026-01-12 9:16 ` Alice Ryhl
2026-01-13 12:09 ` Danilo Krummrich
1 sibling, 0 replies; 3+ messages in thread
From: Alice Ryhl @ 2026-01-12 9:16 UTC (permalink / raw)
To: Alok Tiwari
Cc: rafael, dakr, tmgross, a.hindborg, lossin, bjorn3_gh, gary,
boqun.feng, ojeda, rust-for-linux, gregkh, alok.a.tiwarilinux
On Sat, Jan 10, 2026 at 03:51:56AM -0800, Alok Tiwari wrote:
> Correct copy-paste errors where remove_callback safety invariants
> incorrectly referenced probe_callback().
>
> Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
Reviewed-by: Alice Ryhl <aliceryhl@google.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] rust: platform: fix remove_callback invariant comment
2026-01-10 11:51 [PATCH] rust: platform: fix remove_callback invariant comment Alok Tiwari
2026-01-12 9:16 ` Alice Ryhl
@ 2026-01-13 12:09 ` Danilo Krummrich
1 sibling, 0 replies; 3+ messages in thread
From: Danilo Krummrich @ 2026-01-13 12:09 UTC (permalink / raw)
To: Alok Tiwari
Cc: rafael, tmgross, aliceryhl, a.hindborg, lossin, bjorn3_gh, gary,
boqun.feng, ojeda, rust-for-linux, gregkh, alok.a.tiwarilinux
On Sat Jan 10, 2026 at 12:51 PM CET, Alok Tiwari wrote:
> Correct copy-paste errors where remove_callback safety invariants
> incorrectly referenced probe_callback().
>
> Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
Applied to driver-core-testing, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-01-13 12:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-10 11:51 [PATCH] rust: platform: fix remove_callback invariant comment Alok Tiwari
2026-01-12 9:16 ` Alice Ryhl
2026-01-13 12:09 ` Danilo Krummrich
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox