From: Boqun Feng <boqun.feng@gmail.com>
To: Tamir Duberstein <tamird@kernel.org>,
Peter Zijlstra <peterz@infradead.org>
Cc: "Miguel Ojeda" <ojeda@kernel.org>, "Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Danilo Krummrich" <dakr@kernel.org>,
rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rust: sync: replace `kernel::c_str!` with C-Strings
Date: Wed, 21 Jan 2026 09:09:33 +0800 [thread overview]
Message-ID: <aXAnTVnprfDnj7se@tardis-2.local> (raw)
In-Reply-To: <20260120-cstr-sync-again-v1-1-2a775a2a36fd@kernel.org>
[Cc Peter]
Peter, could you take this to into tip/locking/core so that it'll be
in the PR of v7.0?
On Tue, Jan 20, 2026 at 04:13:19PM -0500, Tamir Duberstein wrote:
> C-String literals were added in Rust 1.77. Replace instances of
> `kernel::c_str!` with C-String literals where possible.
>
> Signed-off-by: Tamir Duberstein <tamird@kernel.org>
Reviewed-by: Boqun Feng <boqun.feng@gmail.com>
Regards,
Boqun
> ---
> This is the same as my earlier change[0] but applies to additional
> code[1] which didn't make it to mainline in a timely manner and is now
> queued for v7.0.
>
> Link: https://lore.kernel.org/all/20251117-core-cstr-cstrings-v4-1-924886ad9f75@gmail.com/ [0]
> Link: https://lore.kernel.org/all/20250811-lock-class-key-cleanup-v3-2-b12967ee1ca2@google.com/ [1]
> ---
> rust/kernel/sync.rs | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/rust/kernel/sync.rs b/rust/kernel/sync.rs
> index b10e576221ff..993dbf2caa0e 100644
> --- a/rust/kernel/sync.rs
> +++ b/rust/kernel/sync.rs
> @@ -126,13 +126,12 @@ fn drop(self: Pin<&mut Self>) {
> /// # Examples
> ///
> /// ```
> -/// use kernel::c_str;
> /// use kernel::sync::{static_lock_class, Arc, SpinLock};
> ///
> /// fn new_locked_int() -> Result<Arc<SpinLock<u32>>> {
> /// Arc::pin_init(SpinLock::new(
> /// 42,
> -/// c_str!("new_locked_int"),
> +/// c"new_locked_int",
> /// static_lock_class!(),
> /// ), GFP_KERNEL)
> /// }
>
> ---
> base-commit: d08c85ac8894995d4b0d8fb48d2f6a3e53cd79ab
> change-id: 20260120-cstr-sync-again-5912d7479909
>
> Best regards,
> --
> Tamir Duberstein <tamird@kernel.org>
>
next prev parent reply other threads:[~2026-01-21 3:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-20 21:13 [PATCH] rust: sync: replace `kernel::c_str!` with C-Strings Tamir Duberstein
2026-01-20 21:16 ` Gary Guo
2026-01-21 1:09 ` Boqun Feng [this message]
2026-01-23 5:46 ` [GIT PULL][PATCH 0/1] Fixes for Rust synchronization PR of v7.0 Boqun Feng
2026-01-23 5:46 ` [PATCH 1/1] rust: sync: Replace `kernel::c_str!` with C-Strings Boqun Feng
2026-01-27 6:12 ` [GIT PULL][PATCH 0/1] Fixes for Rust synchronization PR of v7.0 Boqun Feng
2026-01-27 8:30 ` Peter Zijlstra
2026-01-27 14:06 ` Boqun Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aXAnTVnprfDnj7se@tardis-2.local \
--to=boqun.feng@gmail.com \
--cc=a.hindborg@kernel.org \
--cc=aliceryhl@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=dakr@kernel.org \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=ojeda@kernel.org \
--cc=peterz@infradead.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tamird@kernel.org \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox