* [PATCH 1/2] rust: iommu: fix Rust formatting
@ 2026-01-21 18:43 Miguel Ojeda
2026-01-21 18:43 ` [PATCH 2/2] rust: iommu: fix `srctree` link warning Miguel Ojeda
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Miguel Ojeda @ 2026-01-21 18:43 UTC (permalink / raw)
To: Joerg Roedel, Will Deacon, Miguel Ojeda
Cc: Robin Murphy, iommu, Boqun Feng, Gary Guo, Björn Roy Baron,
Benno Lossin, Andreas Hindborg, Alice Ryhl, Trevor Gross,
Danilo Krummrich, rust-for-linux, Mark Brown
The Rust kernel code should be kept `rustfmt`-clean [1].
Thus run the `rustfmt` target to fix the formatting issue.
Link: https://rust-for-linux.com/contributing#submit-checklist-addendum [1]
Fixes: 2e2f6b0ef855 ("rust: iommu: add io_pgtable abstraction")
Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
---
It would be nice to clean this up, so that Mark may start enforcing it
in linux-next -- thanks!
Please feel free to rebase if needed instead.
Cc: Mark Brown <broonie@kernel.org>
rust/kernel/iommu/pgtable.rs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/rust/kernel/iommu/pgtable.rs b/rust/kernel/iommu/pgtable.rs
index 6135ba141e48..916e1f509e62 100644
--- a/rust/kernel/iommu/pgtable.rs
+++ b/rust/kernel/iommu/pgtable.rs
@@ -14,7 +14,7 @@
bindings,
device::{
Bound,
- Device //
+ Device, //
},
devres::Devres,
error::to_result,
--
2.52.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 2/2] rust: iommu: fix `srctree` link warning
2026-01-21 18:43 [PATCH 1/2] rust: iommu: fix Rust formatting Miguel Ojeda
@ 2026-01-21 18:43 ` Miguel Ojeda
2026-01-22 8:19 ` [PATCH 1/2] rust: iommu: fix Rust formatting Joerg Roedel
2026-01-22 8:22 ` Alice Ryhl
2 siblings, 0 replies; 4+ messages in thread
From: Miguel Ojeda @ 2026-01-21 18:43 UTC (permalink / raw)
To: Joerg Roedel, Will Deacon, Miguel Ojeda
Cc: Robin Murphy, iommu, Boqun Feng, Gary Guo, Björn Roy Baron,
Benno Lossin, Andreas Hindborg, Alice Ryhl, Trevor Gross,
Danilo Krummrich, rust-for-linux, Mark Brown
The Rust kernel code should be kept `rustdoc`-clean [1].
Our custom `srctree` link checker in the `rustdoc` target reports:
warning: srctree/ link to include/io-pgtable.h does not exist
Thus fix it.
Link: https://rust-for-linux.com/contributing#submit-checklist-addendum [1]
Fixes: 2e2f6b0ef855 ("rust: iommu: add io_pgtable abstraction")
Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
---
It would be nice to clean this up, so that Mark may start enforcing it
in linux-next -- thanks!
Please feel free to rebase if needed instead.
Cc: Mark Brown <broonie@kernel.org>
rust/kernel/iommu/pgtable.rs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/rust/kernel/iommu/pgtable.rs b/rust/kernel/iommu/pgtable.rs
index 916e1f509e62..c88e38fd938a 100644
--- a/rust/kernel/iommu/pgtable.rs
+++ b/rust/kernel/iommu/pgtable.rs
@@ -2,7 +2,7 @@
//! IOMMU page table management.
//!
-//! C header: [`include/io-pgtable.h`](srctree/include/io-pgtable.h)
+//! C header: [`include/linux/io-pgtable.h`](srctree/include/linux/io-pgtable.h)
use core::{
marker::PhantomData,
--
2.52.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 1/2] rust: iommu: fix Rust formatting
2026-01-21 18:43 [PATCH 1/2] rust: iommu: fix Rust formatting Miguel Ojeda
2026-01-21 18:43 ` [PATCH 2/2] rust: iommu: fix `srctree` link warning Miguel Ojeda
@ 2026-01-22 8:19 ` Joerg Roedel
2026-01-22 8:22 ` Alice Ryhl
2 siblings, 0 replies; 4+ messages in thread
From: Joerg Roedel @ 2026-01-22 8:19 UTC (permalink / raw)
To: Miguel Ojeda
Cc: Will Deacon, Robin Murphy, iommu, Boqun Feng, Gary Guo,
Björn Roy Baron, Benno Lossin, Andreas Hindborg, Alice Ryhl,
Trevor Gross, Danilo Krummrich, rust-for-linux, Mark Brown
Applied both, thanks Miguel.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] rust: iommu: fix Rust formatting
2026-01-21 18:43 [PATCH 1/2] rust: iommu: fix Rust formatting Miguel Ojeda
2026-01-21 18:43 ` [PATCH 2/2] rust: iommu: fix `srctree` link warning Miguel Ojeda
2026-01-22 8:19 ` [PATCH 1/2] rust: iommu: fix Rust formatting Joerg Roedel
@ 2026-01-22 8:22 ` Alice Ryhl
2 siblings, 0 replies; 4+ messages in thread
From: Alice Ryhl @ 2026-01-22 8:22 UTC (permalink / raw)
To: Miguel Ojeda
Cc: Joerg Roedel, Will Deacon, Robin Murphy, iommu, Boqun Feng,
Gary Guo, Björn Roy Baron, Benno Lossin, Andreas Hindborg,
Trevor Gross, Danilo Krummrich, rust-for-linux, Mark Brown
On Wed, Jan 21, 2026 at 07:43:38PM +0100, Miguel Ojeda wrote:
> The Rust kernel code should be kept `rustfmt`-clean [1].
>
> Thus run the `rustfmt` target to fix the formatting issue.
>
> Link: https://rust-for-linux.com/contributing#submit-checklist-addendum [1]
> Fixes: 2e2f6b0ef855 ("rust: iommu: add io_pgtable abstraction")
> Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
Thanks Miguel. For both patches:
Acked-by: Alice Ryhl <aliceryhl@google.com>
Alice
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-01-22 8:22 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-21 18:43 [PATCH 1/2] rust: iommu: fix Rust formatting Miguel Ojeda
2026-01-21 18:43 ` [PATCH 2/2] rust: iommu: fix `srctree` link warning Miguel Ojeda
2026-01-22 8:19 ` [PATCH 1/2] rust: iommu: fix Rust formatting Joerg Roedel
2026-01-22 8:22 ` Alice Ryhl
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox