From: Boqun Feng <boqun@kernel.org>
To: FUJITA Tomonori <tomo@aliasing.net>
Cc: miguel.ojeda.sandonis@gmail.com, boqun.feng@gmail.com,
ojeda@kernel.org, peterz@infradead.org, will@kernel.org,
a.hindborg@kernel.org, aliceryhl@google.com,
bjorn3_gh@protonmail.com, dakr@kernel.org, gary@garyguo.net,
lossin@kernel.org, mark.rutland@arm.com, tmgross@umich.edu,
rust-for-linux@vger.kernel.org, fujita.tomonori@gmail.com
Subject: Re: [PATCH v2 1/2] rust: sync: atomic: Add AtomicFlag::get_mut
Date: Tue, 27 Jan 2026 19:55:39 -0800 [thread overview]
Message-ID: <aXmIu37eVGVWrPqV@tardis.local> (raw)
In-Reply-To: <20260128.124734.1765350543682525990.fujita@bee>
On Wed, Jan 28, 2026 at 12:47:34PM +0900, FUJITA Tomonori wrote:
> On Tue, 27 Jan 2026 15:32:29 +0100
> Miguel Ojeda <miguel.ojeda.sandonis@gmail.com> wrote:
>
> > On Tue, Jan 27, 2026 at 1:53 PM FUJITA Tomonori <tomo@aliasing.net> wrote:
> >>
> >> + /// Returns a mutable reference to the underlying flag as a `bool`.
> >
> > [`bool`]
>
> Oops, I'll fix.
>
> >> + /// This is safe because the mutable reference of the atomic flag guarantees exclusive access.
> >> + pub fn get_mut(&mut self) -> &mut bool {
> >
> > Should we give an example here, perhaps promoting (part of) the test below?
>
> Boqun, you prefer to have the examples of get_mut() for AtomicFlag and
> Atomic<T>?
>
Sure, that makes sense to me, thank you!
Regards,
Boqun
next prev parent reply other threads:[~2026-01-28 3:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-27 12:52 [PATCH v2 0/2] rust: add AtomicFlag::get_mut FUJITA Tomonori
2026-01-27 12:52 ` [PATCH v2 1/2] rust: sync: atomic: Add AtomicFlag::get_mut FUJITA Tomonori
2026-01-27 13:53 ` Gary Guo
2026-01-27 14:32 ` Miguel Ojeda
2026-01-28 3:47 ` FUJITA Tomonori
2026-01-28 3:55 ` Boqun Feng [this message]
2026-01-27 15:35 ` Boqun Feng
2026-01-27 15:42 ` Gary Guo
2026-01-27 15:59 ` Boqun Feng
2026-01-27 16:10 ` Gary Guo
2026-01-27 16:34 ` Boqun Feng
2026-01-28 3:32 ` FUJITA Tomonori
2026-01-28 3:38 ` Boqun Feng
2026-01-27 12:53 ` [PATCH v2 2/2] rust: list: Use AtomicFlag in AtomicTracker FUJITA Tomonori
2026-01-27 13:54 ` Gary Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aXmIu37eVGVWrPqV@tardis.local \
--to=boqun@kernel.org \
--cc=a.hindborg@kernel.org \
--cc=aliceryhl@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=fujita.tomonori@gmail.com \
--cc=gary@garyguo.net \
--cc=lossin@kernel.org \
--cc=mark.rutland@arm.com \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=ojeda@kernel.org \
--cc=peterz@infradead.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
--cc=tomo@aliasing.net \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox