From: Alice Ryhl <aliceryhl@google.com>
To: Deborah Brouwer <deborah.brouwer@collabora.com>
Cc: dri-devel@lists.freedesktop.org, rust-for-linux@vger.kernel.org,
daniel.almeida@collabora.com, boris.brezillon@collabora.com
Subject: Re: [PATCH v2] drm/tyr: Use vertical style for imports
Date: Tue, 24 Feb 2026 07:42:53 +0000 [thread overview]
Message-ID: <aZ1WfUrNVPmf6vsz@google.com> (raw)
In-Reply-To: <20260223203833.207955-1-deborah.brouwer@collabora.com>
On Mon, Feb 23, 2026 at 12:38:33PM -0800, Deborah Brouwer wrote:
> Currently Tyr uses rustfmt style for imports, but the kernel uses a
> vertical layout that makes it easier to resolve conflicts and rebase.
>
> Import guidelines are documented here:
> https://docs.kernel.org/rust/coding-guidelines.html#imports
>
> Change all of Tyr's imports to use the vertical layout. This will
> ease the introduction of additional Tyr patches upstream.
>
> There should be no functional changes in this patch.
>
> Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
> Signed-off-by: Deborah Brouwer <deborah.brouwer@collabora.com>
Applied to drm-rust-next. Thanks!
prev parent reply other threads:[~2026-02-24 7:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-23 20:38 [PATCH v2] drm/tyr: Use vertical style for imports Deborah Brouwer
2026-02-24 7:42 ` Alice Ryhl [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aZ1WfUrNVPmf6vsz@google.com \
--to=aliceryhl@google.com \
--cc=boris.brezillon@collabora.com \
--cc=daniel.almeida@collabora.com \
--cc=deborah.brouwer@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=rust-for-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox