public inbox for rust-for-linux@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] rust: time: implement `Display` for `Delta`
@ 2026-02-15 20:14 Andreas Hindborg
  2026-02-16  8:34 ` Alice Ryhl
  0 siblings, 1 reply; 2+ messages in thread
From: Andreas Hindborg @ 2026-02-15 20:14 UTC (permalink / raw)
  To: Boqun Feng, FUJITA Tomonori, Frederic Weisbecker, Lyude Paul,
	Thomas Gleixner, Anna-Maria Behnsen, John Stultz, Stephen Boyd,
	Miguel Ojeda, Gary Guo, Björn Roy Baron, Benno Lossin,
	Alice Ryhl, Trevor Gross, Danilo Krummrich
  Cc: rust-for-linux, linux-kernel, Andreas Hindborg

Implement the `Display` trait for `Delta` so that it can be displayed by a
formatter.

Signed-off-by: Andreas Hindborg <a.hindborg@kernel.org>
---
 rust/kernel/time.rs | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/rust/kernel/time.rs b/rust/kernel/time.rs
index 6ea98dfcd0278..e18fd17f38c5a 100644
--- a/rust/kernel/time.rs
+++ b/rust/kernel/time.rs
@@ -474,3 +474,9 @@ pub fn rem_nanos(self, dividend: i32) -> Self {
         }
     }
 }
+
+impl kernel::fmt::Display for Delta {
+    fn fmt(&self, f: &mut kernel::fmt::Formatter<'_>) -> kernel::fmt::Result {
+        f.write_fmt(kernel::prelude::fmt!("{}", self.as_nanos()))
+    }
+}

---
base-commit: 05f7e89ab9731565d8a62e3b5d1ec206485eeb0b
change-id: 20260215-time-delta-display-d702e7788d2d

Best regards,
-- 
Andreas Hindborg <a.hindborg@kernel.org>



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] rust: time: implement `Display` for `Delta`
  2026-02-15 20:14 [PATCH] rust: time: implement `Display` for `Delta` Andreas Hindborg
@ 2026-02-16  8:34 ` Alice Ryhl
  0 siblings, 0 replies; 2+ messages in thread
From: Alice Ryhl @ 2026-02-16  8:34 UTC (permalink / raw)
  To: Andreas Hindborg
  Cc: Boqun Feng, FUJITA Tomonori, Frederic Weisbecker, Lyude Paul,
	Thomas Gleixner, Anna-Maria Behnsen, John Stultz, Stephen Boyd,
	Miguel Ojeda, Gary Guo, Björn Roy Baron, Benno Lossin,
	Trevor Gross, Danilo Krummrich, rust-for-linux, linux-kernel

On Sun, Feb 15, 2026 at 09:14:05PM +0100, Andreas Hindborg wrote:
> Implement the `Display` trait for `Delta` so that it can be displayed by a
> formatter.
> 
> Signed-off-by: Andreas Hindborg <a.hindborg@kernel.org>
> ---
>  rust/kernel/time.rs | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/rust/kernel/time.rs b/rust/kernel/time.rs
> index 6ea98dfcd0278..e18fd17f38c5a 100644
> --- a/rust/kernel/time.rs
> +++ b/rust/kernel/time.rs
> @@ -474,3 +474,9 @@ pub fn rem_nanos(self, dividend: i32) -> Self {
>          }
>      }
>  }
> +
> +impl kernel::fmt::Display for Delta {
> +    fn fmt(&self, f: &mut kernel::fmt::Formatter<'_>) -> kernel::fmt::Result {
> +        f.write_fmt(kernel::prelude::fmt!("{}", self.as_nanos()))

I think this can just be

	self.as_nanos().fmt(f)

Though I think it would be nicer to include an 'ns' suffix here so it's
not just the number?

Alice

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-02-16  8:34 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-15 20:14 [PATCH] rust: time: implement `Display` for `Delta` Andreas Hindborg
2026-02-16  8:34 ` Alice Ryhl

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox