From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f74.google.com (mail-wm1-f74.google.com [209.85.128.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 01C161C84D7 for ; Sat, 14 Mar 2026 11:30:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.74 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773487828; cv=none; b=sytLS51dx4rcBP/WSS3MWF3VvFDKiCdFjBqDspUvmzNPE9Xe/1jHxrrYaDO+bRCmcdPd85fE2ccSwLFsj5vtA9TMoO0L5s6kslIpEY1yh4CQjI5Md7sTkbo1O53HfBpzU3nme6raHs9rHZmpwwxWgskM/y0broY+VqmkadeyUyQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773487828; c=relaxed/simple; bh=i5/Mv7r0O1xhJ0MOUYqm/aCKF2kenGBq/6wEKwTk7fY=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=P33KdfPAIfkgFefo+2J7NLkqAXLp3aQDGCLhrGgQ6qQqae1uoQQx1axCNwefhqB3nbSDzoj982zwS/9Ur1umWbw3MminAWuSUF0Zr/S406Q1LUEEoiK9+rOsI596nHvlTkKquqObpfV8H28Zh7j4A7JC69k60WF37CxSVC542J0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--aliceryhl.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=LbIFgxj6; arc=none smtp.client-ip=209.85.128.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--aliceryhl.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="LbIFgxj6" Received: by mail-wm1-f74.google.com with SMTP id 5b1f17b1804b1-48535f4d5e1so26216585e9.0 for ; Sat, 14 Mar 2026 04:30:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1773487825; x=1774092625; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=i5/Mv7r0O1xhJ0MOUYqm/aCKF2kenGBq/6wEKwTk7fY=; b=LbIFgxj6k0CEVdM1L+taNms6EN3Et/5oBwovzDcNsh47v253yCNHGJcaOKFwzsAeyd lmLJQnCz9bylRmdsfUbZgymRaGi0LwVyX+Uk5vWsJ8sJ66FLFpl/bFwWh0+9XVFcw0SP vQfEGudeGBbzTd0CNi7H+Q+ip/G5m4cFEW7WPJocDbniZCneXNq2aoR9zu2SqAuzc4nK JM+5K4RDIAWjYhI6g59NykSEQ2IeoxQ978H91wWOO4zqAfh7MVx225hENCJVJQZ/aBT5 FgTpMhs71qxso6GSopfTuEIEeHGv+sT3a41RoobKasVs1y4zVrKA9lceDqgd4RWnWjkE SkNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773487825; x=1774092625; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=i5/Mv7r0O1xhJ0MOUYqm/aCKF2kenGBq/6wEKwTk7fY=; b=alTMEMT4Btjrb9T7oKjeG9fZQaxfhc6YZjFkVbJTry5YS4bdzAxGcCdnNFTv2vEo29 DJohwyw4UH8sV/nyKA3lMvVPIVljgp1DcEXJK3N+kTq1UgOxcmakHkMMt0g6IUXiquxM Qpoe7NJrA+V5Cp5nqVQ78xYAYognBiqzDT3iDLgfoZxjrkv/qWs2T6rxLqPceUTrSxRv f1XZs/txiT0wBv2BFlH3RpdYPkTS3OO6NuqZ2No0vHm/1qjLurZgxjJAzyi6LGrCjBMP d8MmwGSLvTvTDyDnpoTV3FySCciT4PgR5VCHXuJZFeInnTqmGTfraB05D8zKx6kGEN/b 47rg== X-Forwarded-Encrypted: i=1; AJvYcCVf4WGaVXN8EKTdnT4/6uhYONeFnh4qo45kM6y/pI8DyqBFxwtF0Ii/xFpVYhxxxdaNSbKDZ2tezbtQAK3oKw==@vger.kernel.org X-Gm-Message-State: AOJu0YyS2tN1UBNzXGd71lzeexqh6bJKNKJJ0SknEhlPZsLoDUUrlhKi V/ItW0LeeOv3MGE+HpmaNjvsQLFx2HykIx9WcsxRef1Y55XYoXu/TGtDO6uhf8Br2YdA/qHR/xi S+80lYMgZzcevKQWBmw== X-Received: from wmpj3.prod.google.com ([2002:a05:600c:4883:b0:483:509d:729b]) (user=aliceryhl job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:3b25:b0:485:3a03:ceca with SMTP id 5b1f17b1804b1-485567029b6mr109864745e9.23.1773487825162; Sat, 14 Mar 2026 04:30:25 -0700 (PDT) Date: Sat, 14 Mar 2026 11:30:24 +0000 In-Reply-To: Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <202603121235.tpnRxFKO-lkp@intel.com> <20260313213638.GA147391@ax162> <2026031422-catsup-rectal-f886@gregkh> Message-ID: Subject: Re: [linux-next:master 5585/5731] error[E0277]: `*const kernel::bindings::vm_uffd_ops` cannot be shared between threads safely From: Alice Ryhl To: Greg Kroah-Hartman Cc: Miguel Ojeda , Nathan Chancellor , Mike Rapoport , kernel test robot , Andrew Morton , llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Mark Brown , rust-for-linux@vger.kernel.org, Miguel Ojeda , Danilo Krummrich , Jann Horn , "Liam R. Howlett" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Sat, Mar 14, 2026 at 12:15:30PM +0100, Alice Ryhl wrote: > On Sat, Mar 14, 2026 at 12:13=E2=80=AFPM Greg Kroah-Hartman > wrote: > > > > On Fri, Mar 13, 2026 at 11:39:14PM +0100, Miguel Ojeda wrote: > > > On Fri, Mar 13, 2026 at 10:36=E2=80=AFPM Nathan Chancellor wrote: > > > > > > > > It looks like this is a conflict between Alice's "rust_binder: chec= k ownership > > > > before using vma" [1] (currently in char-misc-linus [2]) and Mike's > > > > "userfaultfd: introduce vm_uffd_ops" [3] (currently in mm-unstable = [4]), > > > > hence why it was bisected to the -next merge commit. > > > > > > Thanks Nathan, yeah, adding a raw pointer (not function pointer) to > > > the struct makes the type `!Sync` in Rust. > > > > > > I assume this is best handled with a patch on top of char-misc-linus. > > > Perhaps creating a wrapper to assert it is `Sync`, since the > > > `BINDER_VM_OPS` contents are unused (so far). > > > > > > Cc'ing more folks related to the commit. > > > > char-misc-linus should get merged into Linus's tree "soon" and then we > > can fix up the mm-unstable change for this. >=20 > I'm working on the fix as we speak. It would be ideal if it went into > char-misc-linus, because the commit that is wrong is mine, not the one > in mm. To clarify, to avoid breaking bisection, the commit needs to land somewhere that is on top of commit 8ef2c15aeae0 ("rust_binder: check ownership before using vma"), and before the mm commit. But I guess there are several options for how to do that other than landing it through char-misc-linus right now. Alice