From: Martin Rodriguez Reboredo <yakoyoku@gmail.com>
To: Asahi Lina <lina@asahilina.net>, Alice Ryhl <aliceryhl@google.com>
Cc: alex.gaynor@gmail.com, asahi@lists.linux.dev,
benno.lossin@proton.me, bjorn3_gh@protonmail.com,
boqun.feng@gmail.com, gary@garyguo.net,
linux-kernel@vger.kernel.org, ojeda@kernel.org,
rust-for-linux@vger.kernel.org, wedsonaf@gmail.com
Subject: Re: [PATCH] rust: kernel: str: Implement Debug for CString
Date: Fri, 14 Jul 2023 10:46:56 -0300 [thread overview]
Message-ID: <abab244f-afdb-f646-ce82-c5296fe74ce6@gmail.com> (raw)
In-Reply-To: <15a21f18-485d-37d8-0a5e-417702787204@asahilina.net>
On 7/14/23 09:21, Asahi Lina wrote:
> On 14/07/2023 18.48, Alice Ryhl wrote:
>> Asahi Lina <lina@asahilina.net> writes:
>>> Trivial implementation.
>>>
>>> Signed-off-by: Asahi Lina <lina@asahilina.net>
>>
>> The commit message is a bit short, but the change itself looks fine.
>>
>> Reviewed-by: Alice Ryhl <aliceryhl@google.com>
>
> It's so trivial I just didn't know what else to write... suggestions
> welcome (for this or next time I have a patch like this) ^^
>
> ~~ Lina
>
Just describe what it does, like "cast the `CStr` to an `&str` and call
`fmt::Debug::fmt` with it". I'll add my Reviewed-by, so retain it in
case it's asked to change the commit message.
Reviewed-by: Martin Rodriguez Reboredo <yakoyoku@gmail.com>
next prev parent reply other threads:[~2023-07-14 13:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-14 9:19 [PATCH] rust: kernel: str: Implement Debug for CString Asahi Lina
2023-07-14 9:48 ` Alice Ryhl
2023-07-14 12:21 ` Asahi Lina
2023-07-14 13:46 ` Martin Rodriguez Reboredo [this message]
2023-07-14 10:05 ` Ariel Miculas
2023-07-14 14:02 ` Alice Ryhl
2023-07-14 15:01 ` Miguel Ojeda
2023-10-25 16:18 ` Ariel Miculas (amiculas)
2023-10-25 16:55 ` Miguel Ojeda
2023-07-15 10:00 ` Benno Lossin
2023-12-13 18:43 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abab244f-afdb-f646-ce82-c5296fe74ce6@gmail.com \
--to=yakoyoku@gmail.com \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=asahi@lists.linux.dev \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=gary@garyguo.net \
--cc=lina@asahilina.net \
--cc=linux-kernel@vger.kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=wedsonaf@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).