From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ECE5C3A0E8F; Mon, 27 Apr 2026 23:37:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777333042; cv=pass; b=LOjsLmuCrtqVSWmwngOitCxBj0WVql0MGzL23J4MkiEL0Fdyl9/1svD9QDhVT77iqvcjQVZxMZ27lmRj9VlgMcgWCm5O6EEkhidKQdDGbfUU+hsAYNcQcTaiWF4c6QfcNVrjt0tBS3lk1M69FGB+HOWuZK/LmBhNofLYgz0e4GE= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777333042; c=relaxed/simple; bh=Ymi0N0/w68WuLhHLhb0kd+8kLryQSEEpd5FsOwPaa0M=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=A151rmMAfG9FWW1P/v8WHLGArlkraJi8HRUXLuWeSEyLPUNWauWZzYxAcFWx0cKqUJhyJjmCWs0S1hap6fEkBByCQmlxBhWil1QuabrF9Bvc09Lv1YInhVELHSYRUs2zuFlPzATRS8s3xOovxSJ4fsgvwHd1WZdp+KX99PUp9Z4= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=deborah.brouwer@collabora.com header.b=JgQctkD9; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=deborah.brouwer@collabora.com header.b="JgQctkD9" ARC-Seal: i=1; a=rsa-sha256; t=1777333011; cv=none; d=zohomail.com; s=zohoarc; b=mVtBRvbv7KKJLThCZ6nLF1OXuXyhmQ2wCU4O6/6QsZW9AqvJv0LzsBvks5j6g9jMiFrcrgeaJGzxIdR3DgoKTupgvKJsWAXRk+vD64TKsSVTPmr9MtktZbA97EER6yatFwdf6cgeNiPb89tVQjYyvDCf2JGvIYwTzIVU3hlOzQQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1777333011; h=Content-Type:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=7hpeqhF3jnEv6T8olU96rzYxcW7mlYBS6IkFNCMTEhI=; b=TJhDd4LfhAucFUQYgLYicbRw0JUDFdVW7ny3d9G0/zFa4Wy//Af1jF87bufnalG6PZ/TBDwmb8F4pr0SM/9XKQE34ajLuCXaZDoD7JUkIi4wSVn2T9QvjIC9RQv1L3K8Pntg48/5sADNFHUxMtZcu5MX1bJqTA0g1iPIOUzONb4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=deborah.brouwer@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1777333011; s=zohomail; d=collabora.com; i=deborah.brouwer@collabora.com; h=Date:Date:From:From:To:To:Cc:Cc:Subject:Subject:Message-ID:References:MIME-Version:Content-Type:In-Reply-To:Message-Id:Reply-To; bh=7hpeqhF3jnEv6T8olU96rzYxcW7mlYBS6IkFNCMTEhI=; b=JgQctkD9snGp1HfHKxlUsUpxDdoOsC2De1qV5Nw99bPkyEIjkho9MxJuchnsgtDf pIKnyE7IphrI7eAA35g9WncjXNS11U31jDJmbutw0A8zcr2srvvQlFN9mKL3Qp6hP0T QO8JQ8u6J8SDgfiuPafk4egaQJ7kw/yxbkhgMMp8= Received: by mx.zohomail.com with SMTPS id 177733300908413.680628273178513; Mon, 27 Apr 2026 16:36:49 -0700 (PDT) Date: Mon, 27 Apr 2026 16:36:48 -0700 From: Deborah Brouwer To: Boris Brezillon Cc: Daniel Almeida , Alice Ryhl , Danilo Krummrich , David Airlie , Simona Vetter , Benno Lossin , Gary Guo , Miguel Ojeda , Boqun Feng , =?iso-8859-1?Q?Bj=F6rn?= Roy Baron , Andreas Hindborg , Trevor Gross , FUJITA Tomonori , Frederic Weisbecker , Thomas Gleixner , Anna-Maria Behnsen , John Stultz , Stephen Boyd , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, beata.michalska@arm.com, lyude@redhat.com, acourbot@nvidia.com, work@onurozkan.dev, alvin.sun@linux.dev Subject: Re: [PATCH v4 02/20] drm/tyr: select required dependencies in Kconfig Message-ID: References: <20260424-b4-fw-boot-v4-v4-0-a5d91050789d@collabora.com> <20260424-b4-fw-boot-v4-v4-2-a5d91050789d@collabora.com> <20260427092338.4e083a55@fedora> Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260427092338.4e083a55@fedora> On Mon, Apr 27, 2026 at 09:23:38AM +0200, Boris Brezillon wrote: > On Fri, 24 Apr 2026 16:38:56 -0700 > Deborah Brouwer wrote: > > > From: Boris Brezillon > > > > Tyr depends on DRM_GPUVM, RUST_DRM_GEM_SHMEM_HELPER, MMU, IOMMU_SUPPORT, > > and IOMMU_IO_PGTABLE_LPAE. Select or depend on these symbols in Kconfig so > > the required infrastructure is enabled when Tyr is built. > > > > Introduce DRM_TYR_STATIC_DEPS to keep the built-in DRM dependencies > > selected even when Tyr is built as a module. > > > > Signed-off-by: Boris Brezillon > > Signed-off-by: Deborah Brouwer > > --- > > drivers/gpu/drm/tyr/Kconfig | 14 +++++++++++++- > > 1 file changed, 13 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/tyr/Kconfig b/drivers/gpu/drm/tyr/Kconfig > > index e933e6478027..443ce988b570 100644 > > --- a/drivers/gpu/drm/tyr/Kconfig > > +++ b/drivers/gpu/drm/tyr/Kconfig > > @@ -1,5 +1,12 @@ > > # SPDX-License-Identifier: GPL-2.0 or MIT > > > > +config DRM_TYR_STATIC_DEPS > > + bool > > + select DRM_GPUVM > > IIRC, Danilo said we should have some boolean RUST_DRM_GPUVM option > selecting DRM_GPUVM for us, just like RUST_DRM_GEM_SHMEM_HELPER does. yes, I think Alice just sent that patch today. I have fixed it and will send it in the next version. > > > + help > > + Ensure required DRM infrastructure is built-in when enabling Tyr > > + even if Tyr is =m > > + > > config DRM_TYR > > tristate "Tyr (Rust DRM support for ARM Mali CSF-based GPUs)" > > depends on DRM=y > > @@ -7,6 +14,11 @@ config DRM_TYR > > depends on ARM || ARM64 || COMPILE_TEST > > depends on !GENERIC_ATOMIC64 # for IOMMU_IO_PGTABLE_LPAE > > depends on COMMON_CLK > > + depends on MMU > > + select DRM_TYR_STATIC_DEPS > > + select IOMMU_IO_PGTABLE_LPAE > > + select RUST_DRM_GEM_SHMEM_HELPER > > + depends on IOMMU_SUPPORT > > default n > > help > > Rust DRM driver for ARM Mali CSF-based GPUs. > > @@ -16,5 +28,5 @@ config DRM_TYR > > Note that the Mali-G68 and Mali-G78, while Valhall architecture, will > > be supported with the panfrost driver as they are not CSF GPUs. > > > > - if M is selected, the module will be called tyr. This driver is work > > + If M is selected, the module will be called tyr. This driver is work > > in progress and may not be functional. > > >