* [PATCH] Makefile: Remove the product of pin_init cleanly in mrporper
@ 2025-10-30 9:07 chenmiao
2025-10-30 17:41 ` Miguel Ojeda
0 siblings, 1 reply; 3+ messages in thread
From: chenmiao @ 2025-10-30 9:07 UTC (permalink / raw)
To: lossin, nathan
Cc: hust-os-kernel-patches, Dongliang Mu, Nicolas Schier,
Miguel Ojeda, Alex Gaynor, Boqun Feng, Gary Guo,
Björn Roy Baron, Andreas Hindborg, Alice Ryhl, Trevor Gross,
Danilo Krummrich, Masahiro Yamada, Thomas Weißschuh,
Tamir Duberstein, open list, open list:RUST:Keyword:b(?i:rust)b
When I enabled Rust compilation, I wanted to clean up its output, so I
used make clean and make mrproper. However, I was still able to find that
libpin_init_internal.so in the rust directory was not deleted, while
all other corresponding outputs were cleared.
If this is an intentional design, I will drop this commit.
Reviewed-by: Dongliang Mu <dzm91@hust.edu.cn>
Signed-off-by: chenmiao <chenmiao@openatom.club>
---
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index b34a1f4c03967..f43a70413a6aa 100644
--- a/Makefile
+++ b/Makefile
@@ -1590,7 +1590,7 @@ MRPROPER_FILES += include/config include/generated \
certs/x509.genkey \
vmlinux-gdb.py \
rpmbuild \
- rust/libmacros.so rust/libmacros.dylib
+ rust/libmacros.so rust/libmacros.dylib rust/libpin_init_internal.so
# clean - Delete most, but leave enough to build external modules
#
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Makefile: Remove the product of pin_init cleanly in mrporper
2025-10-30 9:07 [PATCH] Makefile: Remove the product of pin_init cleanly in mrporper chenmiao
@ 2025-10-30 17:41 ` Miguel Ojeda
2025-10-31 1:54 ` Chen Miao
0 siblings, 1 reply; 3+ messages in thread
From: Miguel Ojeda @ 2025-10-30 17:41 UTC (permalink / raw)
To: chenmiao, Tamir Duberstein, Daniel Gomez
Cc: lossin, nathan, hust-os-kernel-patches, Dongliang Mu,
Nicolas Schier, Miguel Ojeda, Alex Gaynor, Boqun Feng, Gary Guo,
Björn Roy Baron, Andreas Hindborg, Alice Ryhl, Trevor Gross,
Danilo Krummrich, Masahiro Yamada, Thomas Weißschuh,
open list, open list:RUST:Keyword:b(?i:rust)b
On Thu, Oct 30, 2025 at 10:08 AM chenmiao <chenmiao@openatom.club> wrote:
>
> - rust/libmacros.so rust/libmacros.dylib
> + rust/libmacros.so rust/libmacros.dylib rust/libpin_init_internal.so
I think we will need the `.dylib` too, given the other one is there
(for the macOS builds some people do -- Cc'ing Daniel and Tamir). Or
did you avoid it for some reason?
Thanks!
Cheers,
Miguel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Makefile: Remove the product of pin_init cleanly in mrporper
2025-10-30 17:41 ` Miguel Ojeda
@ 2025-10-31 1:54 ` Chen Miao
0 siblings, 0 replies; 3+ messages in thread
From: Chen Miao @ 2025-10-31 1:54 UTC (permalink / raw)
To: Miguel Ojeda, Tamir Duberstein, Daniel Gomez
Cc: lossin, nathan, hust-os-kernel-patches, Dongliang Mu,
Nicolas Schier, Miguel Ojeda, Alex Gaynor, Boqun Feng, Gary Guo,
Björn Roy Baron, Andreas Hindborg, Alice Ryhl, Trevor Gross,
Danilo Krummrich, Masahiro Yamada, Thomas Weißschuh,
open list, open list:RUST:Keyword:b(?i:rust)b
On 10/31/2025 1:41 AM, Miguel Ojeda wrote:
> On Thu, Oct 30, 2025 at 10:08 AM chenmiao <chenmiao@openatom.club> wrote:
>> - rust/libmacros.so rust/libmacros.dylib
>> + rust/libmacros.so rust/libmacros.dylib rust/libpin_init_internal.so
> I think we will need the `.dylib` too, given the other one is there
> (for the macOS builds some people do -- Cc'ing Daniel and Tamir). Or
> did you avoid it for some reason?
Hum, in fact I just seen the `.so` so I ignore the `.dylib`. I think should
add the `.dylib`, I'll make revision later.
Regard,
Chen Miao
>
> Thanks!
>
> Cheers,
> Miguel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-10-31 1:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-30 9:07 [PATCH] Makefile: Remove the product of pin_init cleanly in mrporper chenmiao
2025-10-30 17:41 ` Miguel Ojeda
2025-10-31 1:54 ` Chen Miao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).