Rust for Linux List
 help / color / mirror / Atom feed
From: Alice Ryhl <aliceryhl@google.com>
To: Jan Polensky <japo@linux.ibm.com>
Cc: hca@linux.ibm.com, gor@linux.ibm.com, agordeev@linux.ibm.com,
	 ojeda@kernel.org, peterz@infradead.org, jpoimboe@kernel.org,
	 jbaron@akamai.com, borntraeger@linux.ibm.com,
	svens@linux.ibm.com,  boqun@kernel.org, gary@garyguo.net,
	bjorn3_gh@protonmail.com,  lossin@kernel.org,
	a.hindborg@kernel.org, tmgross@umich.edu, dakr@kernel.org,
	 rostedt@goodmis.org, ardb@kernel.org,
	linux-s390@vger.kernel.org,  rust-for-linux@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/4] s390/jump_label: Implement ARCH_STATIC_BRANCH_JUMP_ASM and ARCH_STATIC_BRANCH_ASM macros
Date: Wed, 27 May 2026 05:57:58 +0000	[thread overview]
Message-ID: <ahaH5k0yKi9IFvv8@google.com> (raw)
In-Reply-To: <20260521165622.279953-3-japo@linux.ibm.com>

On Thu, May 21, 2026 at 06:56:20PM +0200, Jan Polensky wrote:
> Rust static branch support needs the s390 jump label instruction sequence
> and __jump_table emission in a reusable form. The current implementation
> embeds the sequence directly in the C asm goto blocks, which cannot be
> shared with Rust.
> 
> Introduce ARCH_STATIC_BRANCH_ASM and ARCH_STATIC_BRANCH_JUMP_ASM to
> describe the brcl sequences for the likely-false and likely-true cases
> and to emit the same __jump_table entries as before. Switch the existing
> C helpers to use the new macros to avoid duplication without changing
> the generated code.
> 
> Signed-off-by: Jan Polensky <japo@linux.ibm.com>

This looks right.

Reviewed-by: Alice Ryhl <aliceryhl@google.com>

Did you test it?

Alice

  reply	other threads:[~2026-05-27  5:58 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-21 16:56 [PATCH v3 0/4] s390: Enable Rust support and add required arch glue Jan Polensky
2026-05-21 16:56 ` [PATCH v3 1/4] s390/bug: Provide ARCH_WARN_ASM for Rust WARN/BUG support Jan Polensky
2026-05-27 10:54   ` Gary Guo
2026-05-21 16:56 ` [PATCH v3 2/4] s390/jump_label: Implement ARCH_STATIC_BRANCH_JUMP_ASM and ARCH_STATIC_BRANCH_ASM macros Jan Polensky
2026-05-27  5:57   ` Alice Ryhl [this message]
2026-05-27 21:06     ` Jan Polensky
2026-05-27 10:54   ` Gary Guo
2026-05-21 16:56 ` [PATCH v3 3/4] rust/bindgen_parameters: Mark s390 types as opaque to prevent repr conflicts Jan Polensky
2026-05-21 16:56 ` [PATCH v3 4/4] s390: Enable Rust support Jan Polensky
2026-05-27  5:59   ` Alice Ryhl
2026-05-27  6:53     ` Heiko Carstens
2026-05-27  8:27       ` Miguel Ojeda
2026-05-26 13:55 ` [PATCH v3 0/4] s390: Enable Rust support and add required arch glue Miguel Ojeda
2026-05-26 16:13   ` Heiko Carstens
2026-05-27 10:08     ` Miguel Ojeda
2026-05-27 10:38       ` Alice Ryhl
2026-05-27 12:10         ` Miguel Ojeda
2026-05-27 13:44           ` Heiko Carstens
2026-05-27 15:25             ` Miguel Ojeda
2026-05-27 10:53       ` Gary Guo
2026-05-27 12:13         ` Miguel Ojeda
2026-05-27 11:54       ` Gary Guo
2026-05-27 13:37         ` Heiko Carstens
2026-05-28 14:03       ` Jan Polensky
2026-05-28 14:14         ` Gary Guo
2026-05-29 15:04           ` Jan Polensky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ahaH5k0yKi9IFvv8@google.com \
    --to=aliceryhl@google.com \
    --cc=a.hindborg@kernel.org \
    --cc=agordeev@linux.ibm.com \
    --cc=ardb@kernel.org \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun@kernel.org \
    --cc=borntraeger@linux.ibm.com \
    --cc=dakr@kernel.org \
    --cc=gary@garyguo.net \
    --cc=gor@linux.ibm.com \
    --cc=hca@linux.ibm.com \
    --cc=japo@linux.ibm.com \
    --cc=jbaron@akamai.com \
    --cc=jpoimboe@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=lossin@kernel.org \
    --cc=ojeda@kernel.org \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=svens@linux.ibm.com \
    --cc=tmgross@umich.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox