From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C96431ED83 for ; Wed, 27 May 2026 22:56:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779922594; cv=pass; b=YZjjhD5anJe7kScle/WQdNYkGg90vcZ+vYCZ+FrHmOkH8NymE+Tm0pAOAQjB8JQayj4PgumWxDuY5wDWZ/LjB7H/h4NKiJ2JyMOYTlUQHzWc9J89j+I9/V9p8+RvfYB3lSrU4uh/xlZ+ZRQsZ9BZABNPDPrBhkackOTxEY5LYPU= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779922594; c=relaxed/simple; bh=nO2NgXjx0QjVQ4y6MrOrpQJS1otFvWaBbELslvQuvtI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=QQngjJs0Ws1FY9JPqwrSPXyGbZFb8OPgaWjjYUTrmDc+T76DypnTxHoEHsSSiZi7TcvBbM2ookbZ/loR7Rm7pH+LMLCmdG5vZSU/Zny/kYaNYykOdxDS1hkQ0ftSraqKQJKSznGYlknXWcKD/1xnMgx2qnMIvA2dzdtuAYRC5b8= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=deborah.brouwer@collabora.com header.b=bDveqo1T; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=deborah.brouwer@collabora.com header.b="bDveqo1T" ARC-Seal: i=1; a=rsa-sha256; t=1779922584; cv=none; d=zohomail.com; s=zohoarc; b=Ef9xFYZRLLooh2FZ5QejfmOobWzbx8OhUznwmBn2oK1zStX92gDxLuIFgjCMmWqhBt8Kb/uE5AgYmLYuX35l9DIlqnIVXWASIAlc5OIFtp9n23D7ujcV2UD+XTSHJFwqLxF4AQJu28CmRVv/joN9a+nGtufdAdKplejI+nuW/ZQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1779922584; h=Content-Type:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=kTZkwCqKrQ1RccJhZ0Ny5etxeXqz+L9rW4idmre4STo=; b=Ohy7zRbyS6Kdq3SVik13fDICo+PVt2hp5d/z1m4Ig88BZC8Xp91koBapG4LBSyEi5jhM256dXcXKhiA0tHnw6qUk38bWkw5Os9GUqpDxKkEytOkkPtCR9Dtt/OuJd9UUjcK8f3R7p0m17Mg1IzyxLctIqCn6XqSrBV5sgcitNwk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=deborah.brouwer@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1779922584; s=zohomail; d=collabora.com; i=deborah.brouwer@collabora.com; h=Date:Date:From:From:To:To:Cc:Cc:Subject:Subject:Message-ID:References:MIME-Version:Content-Type:In-Reply-To:Message-Id:Reply-To; bh=kTZkwCqKrQ1RccJhZ0Ny5etxeXqz+L9rW4idmre4STo=; b=bDveqo1TPciICYDklIQM0RM3VqoD5jUKS6fcAqJYp2G1/7OGdEjVdDfPBXDnvnc4 7iGl6h5nsnnLvO0OC3PvY+DB960JJ8eAWdO3jzeSXHdtbvQ05zPTga+PIZeE0hXkneH ynV+DGEbdVntjbNukFrKjDHtKwQvXGmrFqrPxSHc= Received: by mx.zohomail.com with SMTPS id 1779922582476218.05927782354888; Wed, 27 May 2026 15:56:22 -0700 (PDT) Date: Wed, 27 May 2026 15:56:21 -0700 From: Deborah Brouwer To: Danilo Krummrich Cc: aliceryhl@google.com, daniel.almeida@collabora.com, boris.brezillon@collabora.com, gary@garyguo.net, dri-devel@lists.freedesktop.org, rust-for-linux@vger.kernel.org Subject: Re: [PATCH 1/2] gpu: drm: tyr: separate driver type from driver data Message-ID: References: <20260525230152.277820-1-dakr@kernel.org> <20260525230152.277820-2-dakr@kernel.org> Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260525230152.277820-2-dakr@kernel.org> On Tue, May 26, 2026 at 01:01:43AM +0200, Danilo Krummrich wrote: > Introduce TyrPlatformDriver as a unit struct for the platform::Driver > trait implementation and keep TyrPlatformDriverData for the private > driver data. > > Signed-off-by: Danilo Krummrich > --- > drivers/gpu/drm/tyr/driver.rs | 10 ++++++---- > drivers/gpu/drm/tyr/tyr.rs | 4 ++-- > 2 files changed, 8 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/tyr/driver.rs b/drivers/gpu/drm/tyr/driver.rs > index 2224fdb20a51..5f4c484f671f 100644 > --- a/drivers/gpu/drm/tyr/driver.rs > +++ b/drivers/gpu/drm/tyr/driver.rs > @@ -51,6 +51,8 @@ > /// Convenience type alias for the DRM device type for this driver. > pub(crate) type TyrDrmDevice = drm::Device; > > +pub(crate) struct TyrPlatformDriver; > + > #[pin_data(PinnedDrop)] > pub(crate) struct TyrPlatformDriverData { > _device: ARef, > @@ -93,22 +95,22 @@ fn issue_soft_reset(dev: &Device, iomem: &Devres) -> Result { > kernel::of_device_table!( > OF_TABLE, > MODULE_OF_TABLE, > - ::IdInfo, > + ::IdInfo, > [ > (of::DeviceId::new(c"rockchip,rk3588-mali"), ()), > (of::DeviceId::new(c"arm,mali-valhall-csf"), ()) > ] > ); > > -impl platform::Driver for TyrPlatformDriverData { > +impl platform::Driver for TyrPlatformDriver { > type IdInfo = (); > - type Data<'bound> = Self; > + type Data<'bound> = TyrPlatformDriverData; > const OF_ID_TABLE: Option> = Some(&OF_TABLE); > > fn probe<'bound>( > pdev: &'bound platform::Device>, > _info: Option<&'bound Self::IdInfo>, > - ) -> impl PinInit + 'bound { > + ) -> impl PinInit, Error> + 'bound { > let core_clk = Clk::get(pdev.as_ref(), Some(c"core"))?; > let stacks_clk = OptionalClk::get(pdev.as_ref(), Some(c"stacks"))?; > let coregroup_clk = OptionalClk::get(pdev.as_ref(), Some(c"coregroup"))?; > diff --git a/drivers/gpu/drm/tyr/tyr.rs b/drivers/gpu/drm/tyr/tyr.rs > index 9432ddd6b5b8..95cda7b0962f 100644 > --- a/drivers/gpu/drm/tyr/tyr.rs > +++ b/drivers/gpu/drm/tyr/tyr.rs > @@ -5,7 +5,7 @@ > //! The name "Tyr" is inspired by Norse mythology, reflecting Arm's tradition of > //! naming their GPUs after Nordic mythological figures and places. > > -use crate::driver::TyrPlatformDriverData; > +use crate::driver::TyrPlatformDriver; > > mod driver; > mod file; > @@ -14,7 +14,7 @@ > mod regs; > > kernel::module_platform_driver! { > - type: TyrPlatformDriverData, > + type: TyrPlatformDriver, > name: "tyr", > authors: ["The Tyr driver authors"], > description: "Arm Mali Tyr DRM driver", > -- > 2.54.0 > Tested-by: Deborah Brouwer