From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E41AB3EFFBD for ; Thu, 28 May 2026 14:31:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779978718; cv=none; b=AVTrTT6JWmfJT0OgqLSuLxgmkx9LKyh2XkPEqlqIk+8avok1+XohaMoglx9vawmqpJ63gY9AGqAem9KnUVxYw+dZtZ2ty0EdSctbJHXeVEyu/gqJNoKGIOlIf0n1RCQlgjA2BpD9bMxux+fuPMvRu4Ks8k2bblig2QMGj4ENyNs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779978718; c=relaxed/simple; bh=DiSgb0xzS1Cb+1jztqkW0jzIomJtlcBZU/VVJkOi+fE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=imgcA9t5PpRgW75WGN/NJsE9toFT4P45dohWJGJJUMKwhmnOnqVBiGg5DpAJXNFezMSFDWI5kh2/yqYstwyl/uNincFh/veuG/UAeC/0pwy1aODzJ52q9Fyi+qWfp9SlAh3WcAshEApUK+xbQxic5+TX1gW7SWl/WuPkW7q0KaQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=m5GKoPBe; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="m5GKoPBe" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0E5011F00A3C; Thu, 28 May 2026 14:31:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1779978716; bh=r8sGBUPFq+B088npM59l8i3bvZ+rfoLE32WJ5Kqd+TU=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=m5GKoPBeuvhbuCVPHmRg7w0G4TFEMPZce49PVRyAc5XdczhluPfbc6oXll6CRYfR9 v6D9p9o2XLUR1FxQ5KCEl6bTPjs7oeEwM41TbCf7/ECmt0HlscIBhQGCJaTDvPROhD iMQVv8iXIX5PKvVgmVmQtQNbIF7cvh5kdVpE47Cnr7erciIyAKyuLbzjwK1y4NF+ft rZrm9gtuLQKZjFuaNFbeGPyqeOOkeHuSltT2HcRSCYB8MVVKQH8sRJkPUPJOV5JZJr UYVaK7NwoXyd8d0zzSj9ZH1JytjspPhesC7sMnngjaAN4t3rBcsx8kFHXSZJnXSeEa mBc81nU8o/WAw== Received: from phl-compute-04.internal (phl-compute-04.internal [10.202.2.44]) by mailfauth.phl.internal (Postfix) with ESMTP id 65A7CF4006C; Thu, 28 May 2026 10:31:54 -0400 (EDT) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-04.internal (MEProxy); Thu, 28 May 2026 10:31:54 -0400 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTFh+x5OYn8jFqDqC7Wfcfy34OS1sijeomaDwSfxCQL5ShWXDIyuF4+dB17if6fV1W XuNH0pLpYRaoxWFUOHRiglU0uQCEV7/dN5YqAXa87+3IJEn3o9kQ0tGuMZUB5OBJLK5s7U q6VUT6Lv/RaOhKG1NzlSDNHJ4AmBWaD/neZrbIHYEg01roAfUywWSelpZTbSsjC75BU+Vy v11QBGps7hxTDdVCp4G6LRpg5Jb9KVyMi6JxENUpaqdCSjcPKm9rzZ6TKjlC8RPtSpo81O KA3bMFNB6+8Jzw7xYNxA9bnMFzB2MIcHOD8uFROA7r+IKKukpunNc9S5ooFecE6RzJ+ttt rf/KWJRaBk7hXVddeQZ41joxtBH2x4CDqDMLMkq9b0KWXmUIndZGvBrFRpbl8+3VxejRc+ x1mDHpDtgwhSamwF/uOA4X79HKjJ5TiDH7rhclXEeWUou/9JRp/N9iLRpmAzRF+T5a4Du9 UqOUwqepPRlrdo5eppc2zzssD6rN5vo1gQ1qWenjfdOEP09XpTyys82w+CJH816p0o8yrU +fDkrJ9Gg4Yb7v4r6Xnk+8r+6sUw8lXFlcRbeZoPBxK685GhTd2jlvMm5bbXWxotpAtnTQ ZKSB1OoHJNT19txDu4Ybtx3lkFJre62sALVyrYkGoDERe9BfD+s5YuIUWFng X-ME-Proxy: Feedback-ID: i8dbe485b:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 28 May 2026 10:31:53 -0400 (EDT) Date: Thu, 28 May 2026 07:31:52 -0700 From: Boqun Feng To: Peter Zijlstra Cc: Catalin Marinas , Will Deacon , Jonas Bonn , Stefan Kristiansson , Stafford Horne , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Arnd Bergmann , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , K Prateek Nayak , Waiman Long , Andrew Morton , Andrii Nakryiko , Eduard Zingerman , Alexei Starovoitov , Daniel Borkmann , Martin KaFai Lau , Kumar Kartikeya Dwivedi , Song Liu , Yonghong Song , Jiri Olsa , Shuah Khan , Miguel Ojeda , Gary Guo , =?iso-8859-1?Q?Bj=F6rn?= Roy Baron , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Jinjie Ruan , Lyude Paul , Thomas Huth , Sohil Mehta , "Xin Li (Intel)" , Pawan Gupta , Nikunj A Dadhania , Joel Fernandes , Andy Shevchenko , Randy Dunlap , Yury Norov , Sebastian Andrzej Siewior , linux-kernel@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-s390@vger.kernel.org, linux-arch@vger.kernel.org, bpf@vger.kernel.org, linux-kselftest@vger.kernel.org, rust-for-linux@vger.kernel.org, Onur =?iso-8859-1?Q?=D6zkan?= , Daniel Almeida , Boqun Feng Subject: Re: [PATCH v2 07/12] locking: Switch to _irq_{disable,enable}() variants in cleanup guards Message-ID: References: <20260526152148.30514-1-boqun@kernel.org> <20260526152148.30514-8-boqun@kernel.org> <20260528104529.GG343181@noisy.programming.kicks-ass.net> Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260528104529.GG343181@noisy.programming.kicks-ass.net> On Thu, May 28, 2026 at 12:45:29PM +0200, Peter Zijlstra wrote: > On Tue, May 26, 2026 at 08:21:43AM -0700, Boqun Feng wrote: > > From: Boqun Feng > > > > The semantics of various irq disabling guards match what > > *_irq_{disable,enable}() provide, i.e. the interrupt disabling is > > properly nested, therefore it's OK to switch to use > > *_irq_{disable,enable}() primitives. > > > > Signed-off-by: Boqun Feng > > Signed-off-by: Boqun Feng > > You really need them both? ;-) Nah, I will clean this up ;-) Regards, Boqun