From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f73.google.com (mail-wr1-f73.google.com [209.85.221.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C0D87426ECD for ; Thu, 4 Jun 2026 11:49:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.73 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780573773; cv=none; b=eQQ2aS8Hx5fmzs2RiNp8QTcmuLKc2rcjxvVSAWpY9+5g3XDvwo3qE1SOwM2EiNyRpClcYt6VD4wwn4zGGWd9Cf0u+TLWAnDnFxRWvE18shnbtaY4HtsEnNVLpQ3Gi9gc3J6rwYJSXOZqfE78arYP6mfmxrlbaJs8lNKDZsnwInA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780573773; c=relaxed/simple; bh=eOJ28jQK0dMXwHg78GmVtabOBwJqVXIChB/pOF0BUW8=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=Sl/1F0BPK5ZVUSvne8Q7zEbuiPAUjVnjF81Q9MjjfCZJR9k2ok5MQdILBYIQeNt3iow9ggoqpybvIylDWMOsfSup79szVGvpFwy6TLHaN2PavbR+L47rhmFtuvK6FrUquLwDDvexYg51YDxEv/AknwrzJP42qC0Vi3J1UfrrCfw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--aliceryhl.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=P679IZHY; arc=none smtp.client-ip=209.85.221.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--aliceryhl.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="P679IZHY" Received: by mail-wr1-f73.google.com with SMTP id ffacd0b85a97d-45eecec7667so453922f8f.3 for ; Thu, 04 Jun 2026 04:49:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1780573770; x=1781178570; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=IDsisrKoiSBYw8b45wvLvNabX1p1YR55LCjFQrLjodw=; b=P679IZHYZyoPKYWl3QwucXddhueKnOUJtRKPw9yUpKYxsxqTeI9HoYO9j0V/DhYHdD YbtKGfQoj5rQ7q6kOPCZSH9CZKobzYWfzHhKbQqv8PX6iHOYfOxWMCHgWjh8al4cG3T0 6uNpKxxztgHlKlzyx30PRA3Zs8yOyosEpPvPa9TlXdOrY2ScQT/th02wl/EfLM65k+pt 8vSg4hIneziuN7lCZfpHMY5ZUenVlYq6fs2j69h+Ur0jiU2g2yLTdQdWVE3EbBh6GeC6 ToS8jYwmYS/zb4OYtPN2gGVv4xkzXAaH/7hqVyy4jUCEgOp8OkIcN5gT0uAMO4lDW/Zn 9wgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780573770; x=1781178570; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=IDsisrKoiSBYw8b45wvLvNabX1p1YR55LCjFQrLjodw=; b=BpvRl4cmmy5DamyhOK6JQgR69OLtIJ5xvJu/jRl34Wl2Dt7uL2Ki8V17WrF8IsDwFq KzCJ5NH4pLMWDRTzQEQTPZPHpN7KNeHnv+iJcygGxfjv9PoRQfZ4MT4Lr4NBvIjBYPhh PoQQK1Bd5gO/oQALjk0xe/4vc7IhmK9TWHHD+EYfRejYyI4fExu35tokNA9ooBN+qmpT RShL8Mg32OkYfnVGvqQFM+TTXLhfjIgF7zC9BWGpK89/avLFOfcomEtpFoPBkRXalYNN jRdA8eRKhpRrtLLEvX81U8YsqYdOxL8gnYMNCNt23siqSpL7XqRmIopzf8m0WxsPpYz3 Mp4A== X-Forwarded-Encrypted: i=1; AFNElJ+9LQyB0QCQOpt5IeiRhWbO81kFwgCxHlSKoEAc12JvAK3WtqcJpTiGGUaisK/CMFM4OLs7vpiU/NrWnqLAaQ==@vger.kernel.org X-Gm-Message-State: AOJu0YwnNYsyjAvB/dg4DgSCXhjSU6afkDsetmCb5QBheAY9uznod/vv HkIj8DItEaq3jDiueZdcZ4ubCD8pur3ZEcBX+Y3hdIHVWw6uH64iay5AZVjUWxMIY1KdxK0eIbu SspyWAgrrEcKkLg8aKg== X-Received: from wmbc9.prod.google.com ([2002:a7b:c009:0:b0:48a:7f8c:a95a]) (user=aliceryhl job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:1d86:b0:490:6869:46c3 with SMTP id 5b1f17b1804b1-490b5fe79f8mr132548195e9.30.1780573770264; Thu, 04 Jun 2026 04:49:30 -0700 (PDT) Date: Thu, 4 Jun 2026 11:49:29 +0000 In-Reply-To: <20260603195210.693856-2-lyude@redhat.com> Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260603195210.693856-1-lyude@redhat.com> <20260603195210.693856-2-lyude@redhat.com> Message-ID: Subject: Re: [PATCH v17 1/6] rust: drm: gem: shmem: Fix Default implementation for ObjectConfig From: Alice Ryhl To: Lyude Paul Cc: dri-devel@lists.freedesktop.org, rust-for-linux@vger.kernel.org, nouveau@lists.freedesktop.org, Alexandre Courbot , Gary Guo , "Christian =?utf-8?B?S8O2bmln?=" , driver-core@lists.linux.dev, Miguel Ojeda , Maarten Lankhorst , Simona Vetter , linux-kernel@vger.kernel.org, Sumit Semwal , linux-media@vger.kernel.org, "Rafael J . Wysocki" , Thomas Zimmermann , Maxime Ripard , David Airlie , Benno Lossin , linaro-mm-sig@lists.linaro.org, Danilo Krummrich , Mukesh Kumar Chaurasiya , Asahi Lina , Daniel Almeida , Greg Kroah-Hartman Content-Type: text/plain; charset="utf-8" On Wed, Jun 03, 2026 at 03:42:30PM -0400, Lyude Paul wrote: > I completely forgot when coming up with this type that #[derive(Default)] > only works if all generics mentioned in the type implement Default (and T > usually doesn't). This being said: We don't use `T` for anything besides > using it for a reference type, so whether or not it implements `Default` > shouldn't actually need to matter. > > So, fix this by just manually implementing Default instead of deriving it. > > Signed-off-by: Lyude Paul This one is so simple I went ahead and applied it to drm-rust-next right away. Alice