From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f73.google.com (mail-ed1-f73.google.com [209.85.208.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC9B13EA95C for ; Wed, 17 Jun 2026 11:36:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.73 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781696196; cv=none; b=RIPWtnNXOn+q/pdOejRfMnp4/dXetujTrB/lAEgMpR4o5K1+zjHnR74Xqnx2IHpyRDRiTv902jd7QL/cF0HvkgeUH5X3vUsnd8UEshm0PeasQC8NOdWb/wKht0IDOBMZKateEopCD9EFjEjZekBr+bztbGCCDMbadEN4T+aKFxQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781696196; c=relaxed/simple; bh=rOcDjKNM7agwOLTLfbY1xAQ9bt9q2fdtORORxk4X9p0=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=omnUS2y/y1KiVx45XiASDiP+6DrhDwijFNFY43BzjBL4che5J2s7LX5zSBLqwEAVP/y+OK+7/WYG0Liq1ZzxGtwh09x7UMjwxz0vwXu3Je/NlO7uyhWJtrotTTxQMRS0168XwdISeiLmzKdNCF9Fqj8kGVFPU5ur+I30ikAXZLQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--aliceryhl.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=DO0PL1lz; arc=none smtp.client-ip=209.85.208.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--aliceryhl.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="DO0PL1lz" Received: by mail-ed1-f73.google.com with SMTP id 4fb4d7f45d1cf-6959dedafe3so153847a12.1 for ; Wed, 17 Jun 2026 04:36:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1781696193; x=1782300993; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=UYicJoYFI4w4qF8sCnn+jRXzXN1/GRmTZzaGc7Ox2u4=; b=DO0PL1lz29qKPDyulPg8ifez7mjDclhJ1lmjNppxCX8OOS/xe8hvN1/XIWXHklL92+ asFHBAnT3gg97rxzzYW2ejWRkLpCJzpks6rhZVsQExYfsGOyzGby37HsAsWmx0HYU9W0 cEEDJIRqd9ybX0myXUevPrxqy4bt5RNU7LW1xsgVrGKCZwMZjDKU50PziLZfsTpjsrYd mINieITCXsvsjwsleB8Bmtiuf51VrdH/VyMW+hgqOf2hRS5MDsSvqKYN3SxTnb7+Ec6w FAQwf5rzp8gRPutt8WH3laCVwbanmd/imcEXAaD4aip6e3BKj4MrW6pB4M6IgjGimmkw Ib+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781696193; x=1782300993; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=UYicJoYFI4w4qF8sCnn+jRXzXN1/GRmTZzaGc7Ox2u4=; b=Io2k7HGlBdsil8HrCTmdQsa00XdrLNkRtkUvSKBajp/WDGLEOzAj10Dr3ginNcQeCa X4Zg4iqKK+/8aXRTTGj1N9eLg2wJaM3nD3D0+ODUURJLQaPTpUKGEuOPcXlf6GoZvQtT wfgBREmLJu6Vxrzpxmv3vxImQkbqw+E8cfo42sfuhuTVnks1B7ub+qDW8YRznDfKykXb iNx3PS54rU1Laj8vdDJC/LwEO7f46VxB03SYhsg402PbOyV8v/O0f/FODFVHNpUY0gyb wtOT+93yNk5+fEMpmBlqdiiIUZ6QteCH0QMdsLqW3irLZtPUeB07Y1yxoNWwQs4T8RnF Yzgg== X-Forwarded-Encrypted: i=1; AFNElJ80piVexXEIHBTE/Dos2XQ9LKjTbkWAEuvHkQoyBmYrZWseKokAE9r66TH/sVRSvUWnsPlVo5EWhN19BdOIdA==@vger.kernel.org X-Gm-Message-State: AOJu0Yzi2M5420bSVD+lxaCrhiWYuzk58bxUjJbVED/3JaU8bT9jkRRh +hfZ5mzOIP/BDyoBunF/wPwdiyOIURs2B9Ab6zDH74QvJYlCIq1mdpzNjB8OG5lktogSuRE1lQF j4VaygyPeO1fRvt1ZEQ== X-Received: from edea23.prod.google.com ([2002:a05:6402:a197:b0:695:72e1:a5a0]) (user=aliceryhl job=prod-delivery.src-stubby-dispatcher) by 2002:a50:cbc1:0:b0:68f:9fd9:435a with SMTP id 4fb4d7f45d1cf-69554cac360mr960260a12.17.1781696192851; Wed, 17 Jun 2026 04:36:32 -0700 (PDT) Date: Wed, 17 Jun 2026 11:36:31 +0000 In-Reply-To: <20260604-unique-ref-v17-5-7b4c3d2930b9@kernel.org> Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260604-unique-ref-v17-0-7b4c3d2930b9@kernel.org> <20260604-unique-ref-v17-5-7b4c3d2930b9@kernel.org> Message-ID: Subject: Re: [PATCH v17 05/10] rust: page: convert to `Ownable` From: Alice Ryhl To: Andreas Hindborg Cc: Miguel Ojeda , Gary Guo , "=?utf-8?B?QmrDtnJu?= Roy Baron" , Benno Lossin , Trevor Gross , Danilo Krummrich , Greg Kroah-Hartman , Dave Ertman , Ira Weiny , Leon Romanovsky , Paul Moore , Serge Hallyn , "Rafael J. Wysocki" , David Airlie , Simona Vetter , Alexander Viro , Christian Brauner , Jan Kara , Daniel Almeida , Viresh Kumar , Nishanth Menon , Stephen Boyd , Bjorn Helgaas , "Krzysztof =?utf-8?Q?Wilczy=C5=84ski?=" , Boqun Feng , Uladzislau Rezki , Lorenzo Stoakes , Vlastimil Babka , "Liam R. Howlett" , Igor Korotin , Pavel Tikhomirov , linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-block@vger.kernel.org, linux-security-module@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-pm@vger.kernel.org, linux-pci@vger.kernel.org, driver-core@lists.linux.dev, Asahi Lina Content-Type: text/plain; charset="utf-8" On Thu, Jun 04, 2026 at 10:11:17PM +0200, Andreas Hindborg wrote: > From: Asahi Lina > > This allows Page references to be returned as borrowed references, > without necessarily owning the struct page. > > Signed-off-by: Asahi Lina > [ Andreas: Fix formatting and add a safety comment. ] > Signed-off-by: Andreas Hindborg > --- > rust/kernel/page.rs | 38 +++++++++++++++++++++++++------------- > 1 file changed, 25 insertions(+), 13 deletions(-) > > diff --git a/rust/kernel/page.rs b/rust/kernel/page.rs > index 3bdcee0e16a8..844c75e54134 100644 > --- a/rust/kernel/page.rs > +++ b/rust/kernel/page.rs > @@ -10,6 +10,11 @@ > bindings, > error::code::*, > error::Result, > + types::{ > + Opaque, > + Ownable, > + Owned, // > + }, > uaccess::UserSliceReader, // > }; > use core::{ > @@ -105,7 +110,7 @@ pub const fn page_align(addr: usize) -> Option { > /// > /// [`VBox`]: kernel::alloc::VBox > /// [`Vmalloc`]: kernel::alloc::allocator::Vmalloc > -pub struct BorrowedPage<'a>(ManuallyDrop, PhantomData<&'a Page>); > +pub struct BorrowedPage<'a>(ManuallyDrop>, PhantomData<&'a Page>); BorrowedPage<'a> is no longer needed because it's just &Page. Alice