Rust for Linux List
 help / color / mirror / Atom feed
From: Alistair Popple <apopple@nvidia.com>
To: Danilo Krummrich <dakr@kernel.org>
Cc: Timur Tabi <ttabi@nvidia.com>,
	 "nova-gpu@lists.linux.dev" <nova-gpu@lists.linux.dev>,
	John Hubbard <jhubbard@nvidia.com>,
	 "gary@garyguo.net" <gary@garyguo.net>,
	Eliot Courtney <ecourtney@nvidia.com>,
	 "lossin@kernel.org" <lossin@kernel.org>,
	"airlied@gmail.com" <airlied@gmail.com>,
	 "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	 "rust-for-linux@vger.kernel.org"
	<rust-for-linux@vger.kernel.org>,
	"aliceryhl@google.com" <aliceryhl@google.com>,
	 Alexandre Courbot <acourbot@nvidia.com>,
	 "dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH 3/4] drm: nova: Add GETPARAM parameter to read the GPU chipset
Date: Thu, 9 Jul 2026 10:16:08 +1000	[thread overview]
Message-ID: <ak7lU9X4pTwx5NDB@nvdebian.thelocal> (raw)
In-Reply-To: <DJRP5QO5JKVT.Y7LCZARVCWJ8@kernel.org>

On 2026-07-07 at 04:24 +1000, Danilo Krummrich <dakr@kernel.org> wrote...
> On Mon Jul 6, 2026 at 7:35 PM CEST, Timur Tabi wrote:
> > On Mon, 2026-07-06 at 15:34 +1000, Alistair Popple wrote:
> >> @@ -38,6 +38,7 @@ pub(crate) fn get_param(
> >>  
> >>          let value = match getparam.param as u32 {
> >>              uapi::NOVA_GETPARAM_VRAM_BAR_SIZE => pdev.resource_len(1)?,
> >> +            uapi::NOVA_GETPARAM_GPU_CHIPSET => reg_data.api.chipset() as u64,
> >
> > Can we assign these IOCtl values to match Nouveau as much as possible?  I think it would make
> > everyone's life easier if we could use the same user-space tools/libraries for Nova that we do for
> > Nouveau.

I debated this, for the same reasons. However I came to the conclusion that it
wouldn't make a big difference - Nouveau only has a handful of GETPARAMs and
we already know we're going to need a lot more for Nova given the increased
scope of features it needs to support. The rest of the API also needs to be
sufficiently different so I didn't see any real practical advantage to keeping a
couple of parameters the same as tools will need updating anyway.

That said I don't know these tools well - did you have any particular examples
in mind?

 - Alistair

> I don't mind using the same numbers where it doesn't matter too much, but for
> this to work, it would also require us to retain layout compatibility with
> structures, semantics, etc., which I think we should not bother with at all.
> 
> Let's build a clean new uAPI, it will get messy over time by itself. :)

  reply	other threads:[~2026-07-09  0:16 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-06  5:34 [PATCH 0/4] gpu: nova: Export parameters from nova-core to nova-drm Alistair Popple
2026-07-06  5:34 ` [PATCH 1/4] gpu: nova-core: Add public driver API to nova-core Alistair Popple
2026-07-06 17:56   ` Danilo Krummrich
2026-07-06  5:34 ` [PATCH 2/4] gpu: nova: Add DRM registration data Alistair Popple
2026-07-06 18:01   ` Danilo Krummrich
2026-07-09  0:40     ` Alistair Popple
2026-07-06  5:34 ` [PATCH 3/4] drm: nova: Add GETPARAM parameter to read the GPU chipset Alistair Popple
2026-07-06 17:35   ` Timur Tabi
2026-07-06 18:24     ` Danilo Krummrich
2026-07-09  0:16       ` Alistair Popple [this message]
2026-07-09  0:49         ` John Hubbard
2026-07-09  4:31           ` Dave Airlie
2026-07-09 10:18           ` Danilo Krummrich
2026-07-06 18:16   ` Danilo Krummrich
2026-07-09  1:31     ` Alistair Popple
2026-07-06  5:34 ` [PATCH 4/4] drm: nova: Add a GETPARAM parameter to read usable VRAM size Alistair Popple
2026-07-06 18:26   ` Danilo Krummrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ak7lU9X4pTwx5NDB@nvdebian.thelocal \
    --to=apopple@nvidia.com \
    --cc=acourbot@nvidia.com \
    --cc=airlied@gmail.com \
    --cc=aliceryhl@google.com \
    --cc=dakr@kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=ecourtney@nvidia.com \
    --cc=gary@garyguo.net \
    --cc=jhubbard@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lossin@kernel.org \
    --cc=nova-gpu@lists.linux.dev \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=ttabi@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox