From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f73.google.com (mail-wr1-f73.google.com [209.85.221.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0B4F6385D7B for ; Sat, 11 Jul 2026 12:09:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.73 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783771758; cv=none; b=PNOgpcay9RDBAbJek8hstIMp9kJfVl+WpUY9lr+XUObi9vSeFVtgTurfQtmpsIddmFD2H8dJ0me6MRaYLpgmGIFjGceOjMveI7sJEMV+fswV301Fc5m1KxaHhgbENblecRokjrHinmt09M1z6M3B9yh+kyPAM82SJLsfoczi8j0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783771758; c=relaxed/simple; bh=NTQUTiOY6fWGJY+qqToUuWf4suAV/H32seKG+A+pnBk=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=F0TLpt2JIH582+0Jr7nqiL2RC51d4kzqjeyhmEZZQSbhVVDwPMwqdECBzQG+L5WzTybJfyoiBs/+GjmxP0U0C58Nco5SrltGupxGg3Ohdx6dKNn5rsJw7TABDjnLk0ChHBuiupaRcK+cDF5/8wuc1rHWN7/AE1ptw6pgAaKAVjw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--aliceryhl.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=o2Q4KDTp; arc=none smtp.client-ip=209.85.221.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--aliceryhl.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="o2Q4KDTp" Received: by mail-wr1-f73.google.com with SMTP id ffacd0b85a97d-4784d0fb9cfso1015224f8f.2 for ; Sat, 11 Jul 2026 05:09:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1783771755; x=1784376555; darn=vger.kernel.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=rZECiUz8iXrro/+1KsBtJNmjhFi5kdYHy3t1PHyk/II=; b=o2Q4KDTpENi27OJyUXz76+iAkjyePGLqWtRfSeYbujgi4tC0dYixHvcNwY6aI0dh/R P3KpHuNzOgT5au/9VLQawB8WxNA2xIqXGzGqpnVew9P1Dl+sZ904l3dJKPPiwUuABVYW uMZ8bclaG9bWCXfV//+EKw983xCvg4yZWlCBXGtLmI3IYP+2zQnQHiEDNjGKd0XeGJVl 4DkXnNK9g4qQi+E/1ZAwuAcJkvSH8B5hKNpxSgEm03C5qoWmap/gUmtw64/SRyU4qxrL Xjctgu5Zw+/nRPiTidPt3jiVkWlo09Cms8Jh45Gmp+jg+ihhan6O/nkjf+ebV62fOx3U RXiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783771755; x=1784376555; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=rZECiUz8iXrro/+1KsBtJNmjhFi5kdYHy3t1PHyk/II=; b=aAEDqOvDg+7gjqlaXLToJvnJQtXWgMNo7E9VQppl5rdc5HCsPF0pqNKAQSqc7HdVjq nuDTit2S6uwh3cLRsgSTZt8MZFGsaCsKz2dylez8mZxP9dgGiSao5TaKUj2bAchQtqTh ky75Q2kejgrWEihee4UZPLoB8pvKecmW1MdG85CPSc41dpON9u/k0wNAuwv18DVoX+IN b/0UHRMJDPTW6ReOWv52CE3382BNgrv80zvayNgNeJ5/3sP0g0xEuvkLduMHOtBVGKqv 4dgmN6LYDOTwP0VtzxJDch5sEIzZqaiH/lbH5pw4H6EcW2D0yIE8hG/0NDJA2mIh6djR sj3Q== X-Forwarded-Encrypted: i=1; AHgh+RoxfX/GWo7lF307BiwcU+BHalnv9Wfe+3A3L+DeErQtp5h66MwoWRmOTWcqS1P7Yw2kx5MhBQS4465A7fxZuQ==@vger.kernel.org X-Gm-Message-State: AOJu0Yxk6HVfH2c1nCF3ZGu4XH48zaVC3emDr1Uj8lmJ4zU/2yvJGDsy 0dpY6hpRaLm4FKi/pibvw6fPrX40qNXZJtHBxVM8kmng4hHmyEHwDz7aa6fbeDo1q1M5Q+gJ6vn 2LBG2gK07S1i3NyZzpQ== X-Received: from wrwq13.prod.google.com ([2002:a5d:574d:0:b0:472:3bc6:772d]) (user=aliceryhl job=prod-delivery.src-stubby-dispatcher) by 2002:a5d:588e:0:b0:47d:ee7d:c125 with SMTP id ffacd0b85a97d-47f2dce2cc2mr2261213f8f.40.1783771755149; Sat, 11 Jul 2026 05:09:15 -0700 (PDT) Date: Sat, 11 Jul 2026 12:09:13 +0000 In-Reply-To: <20260710173252.191781-1-ojeda@kernel.org> Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260710173252.191781-1-ojeda@kernel.org> Message-ID: Subject: Re: [PATCH] objtool/rust: add one more `noreturn` Rust function for Rust 1.99.0 From: Alice Ryhl To: Miguel Ojeda Cc: Josh Poimboeuf , Peter Zijlstra , Boqun Feng , Gary Guo , "=?utf-8?B?QmrDtnJu?= Roy Baron" , Benno Lossin , Andreas Hindborg , Trevor Gross , Danilo Krummrich , Daniel Almeida , Tamir Duberstein , Alexandre Courbot , "Onur =?utf-8?B?w5Z6a2Fu?=" , rust-for-linux@vger.kernel.org, stable@vger.kernel.org, Petr Pavlu Content-Type: text/plain; charset="utf-8" On Fri, Jul 10, 2026 at 07:32:52PM +0200, Miguel Ojeda wrote: > Starting with Rust 1.99.0 (expected 2026-10-01), under > `CONFIG_RUST_DEBUG_ASSERTIONS=y`, `objtool` may report: > > rust/kernel.o: warning: objtool: _R..._6kernel12module_param9set_paramaEB4_() > falls through to next function _R..._6kernel12module_param9set_paramhEB4_() > > (and many others) due to calls to the `noreturn` symbol [1]: > > core::panicking::panic_null_reference_constructed > > Thus add the mangled one to the list so that `objtool` knows it is > actually `noreturn`. > > See commit 56d680dd23c3 ("objtool/rust: list `noreturn` Rust functions") > for more details. > > Cc: stable@vger.kernel.org # Needed in 6.12.y and later (Rust is pinned in older LTSs). > Cc: Josh Poimboeuf > Cc: Peter Zijlstra > Cc: Petr Pavlu > Link: https://github.com/rust-lang/rust/pull/158796 [1] > Reported-by: Alice Ryhl > Link: https://lore.kernel.org/rust-for-linux/alEBInX9gD1M5NAr@google.com/ > Signed-off-by: Miguel Ojeda Reviewed-by: Alice Ryhl Tested-by: Alice Ryhl