From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sender4-op-o11.zoho.com (sender4-op-o11.zoho.com [136.143.188.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4A7384746D6; Tue, 28 Jul 2026 20:36:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.11 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785270973; cv=pass; b=MYyAM0bxV5Qwa/JH0vp9ntMsJ8SY74NKLudJSTSx17gklr1eNp6wkWx0id6xup1pGi6Wa7PfKdjCXTtwgJCimGxJ0HSwdLZ4gWqQ4E82Fc3ewjCnvVPsE3kAwpvEtsxJF4uUJx/aIdeHnSwyqAOmnQH+Xs0uznz8vWFibZgcows= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785270973; c=relaxed/simple; bh=KvjkKX7oP7hHEjsLwlXZ3yVw4wY3+II/1zIITC6hXyM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=aMwXNzIaU09tkSH08ipmApqg5mNrhBGeTqsXMjtqtvlSf1oPBqrevIQVxJKBbjBrnCD7e3K5ZnrfzOuJLRDi2dh58R1IT+PLLR5z6L/dxb6Gnn5PGYFOKuZ7b5/IWVsCEThX7VJKjg29bkuDt34HoOYncgIN0k69AyBId7niPqY= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=deborah.brouwer@collabora.com header.b=H1LIDzYy; arc=pass smtp.client-ip=136.143.188.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=deborah.brouwer@collabora.com header.b="H1LIDzYy" ARC-Seal: i=1; a=rsa-sha256; t=1785270928; cv=none; d=zohomail.com; s=zohoarc; b=f2/jRC+MITzs+rDlKhMHrYc3cx38Cx5UCcIzffZ8twp5YQltQEEA1imSuNP8GmGFBImSKWsTRamuleFkXLxdh/3Z1+sK8aSbvw3pQX8KBRJ2ouBm5/v/CsqOp/BF8teQo34FumXDv9nI3FnFILBwzNWsX9Elif73I4ReAhINDKE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1785270928; h=Content-Type:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To; bh=YhxTGf5YXkQYjZLE3DoklfRuPngjyDj+Ylg5ViviS+g=; b=Zokw+rmBE/8vtwEgAJtsKPycT5uqipcMQ9nCZouODuVT+foJmcYO9CTZyV8oqQc8ev3qDDU+uVeW93N7CmoSv3ykcwTAsHTqtVv9ewIapBPX0qqssDIKGhM7J5zgKXJKaW9N6FTNm6/tzCrIZEljuEZpj4y9GCLaeeOdNc8wuPw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=deborah.brouwer@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1785270928; s=zohomail; d=collabora.com; i=deborah.brouwer@collabora.com; h=Date:Date:From:From:To:To:Cc:Cc:Subject:Subject:Message-ID:MIME-Version:Content-Type:In-Reply-To:Message-Id:Reply-To; bh=YhxTGf5YXkQYjZLE3DoklfRuPngjyDj+Ylg5ViviS+g=; b=H1LIDzYyE3qnL2DpZtUbBsCMb8P+4gVaco4Asw2jesTz1aJRJ3fGtMEkpp1ZGBHm oDKN0taXlwBqvwlKfJvMssKJk5Qu8FQv7XSVHAvY/ANNY5vOo4sn57rMjn6AyR0zFWn Ut7OhLjA5rPwMyvjzMupq38Ws2U/0GvTdyrI5xMo= Received: by mx.zohomail.com with SMTPS id 1785270925370174.37285430042743; Tue, 28 Jul 2026 13:35:25 -0700 (PDT) Date: Tue, 28 Jul 2026 13:35:24 -0700 From: Deborah Brouwer To: Danilo Krummrich Cc: Daniel Almeida , Alice Ryhl , David Airlie , Simona Vetter , Benno Lossin , Gary Guo , Miguel Ojeda , Boqun Feng , =?iso-8859-1?Q?Bj=F6rn?= Roy Baron , Andreas Hindborg , Trevor Gross , Tamir Duberstein , Alexandre Courbot , Onur =?iso-8859-1?Q?=D6zkan?= , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, laura.nao@collabora.com, samitolvanen@google.com, lyude@redhat.com, beata.michalska@arm.com, boris.brezillon@collabora.com, steven.price@arm.com, alvin.sun@linux.dev Subject: Re: [PATCH v10 3/7] drm/tyr: add Memory Management Unit (MMU) support Message-ID: References: <20260728-fw-boot-b4-v10-0-9187aefa3f2f@collabora.com> <20260728-fw-boot-b4-v10-3-9187aefa3f2f@collabora.com> Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Zoho-Virus-Status: 1 X-Zoho-AV-Stamp: zmail-av-0.2.10.1.5.2/285.252.37 On Tue, Jul 28, 2026 at 09:31:50PM +0200, Danilo Krummrich wrote: > On Tue Jul 28, 2026 at 8:39 PM CEST, Deborah Brouwer wrote: > > +/// Locked wrapper for carrying out virtual memory (VM) operations on the MMU. > > +#[pin_data] > > +pub(crate) struct Mmu<'drm> { > > This shouldn't be 'drm, but 'mmu or just something generic like 'a. > > The rationale is that Mmu might be shorter lived than 'drm once we have > self-referencial pin-init. Currently it is straight forward, such as in > > struct Foo<'foo> { > dev: &'foo platform::Device, > } > > struct Data<'bound> { > foo: Foo<'bound>, > } > > where the lifetime of `dev` really ties back to 'bound. However, with > self-referencial pin-init it could looks like this: > > struct Foo<'foo> { > dev: &'foo platform::Device, > io: &'foo IoMem<'foo>, > } > > struct Data<'bound> { > foo: Foo<'io>, > io: IoMem<'bound>, > } > > Now Foo is not constrained to 'bound anymore, as this would be longer lived than > `io`, so it has to capture 'io instead in order to still compile. Danilo, would you be ok with renaming this lifetime as a follow up patch? Currently, if I understand this correctly, the mmu lifetime is still tied to the DRM registration data, so the name is not inaccurate for Tyr at least as it stands right now.