From: Alice Ryhl <aliceryhl@google.com>
To: "Joerg Roedel (AMD)" <joro@8bytes.org>
Cc: "Deborah Brouwer" <deborah.brouwer@collabora.com>,
"Will Deacon" <will@kernel.org>,
"Robin Murphy" <robin.murphy@arm.com>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Boqun Feng" <boqun@kernel.org>, "Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Trevor Gross" <tmgross@umich.edu>,
"Danilo Krummrich" <dakr@kernel.org>,
iommu@lists.linux.dev, rust-for-linux@vger.kernel.org,
linux-kernel@vger.kernel.org, samitolvanen@google.com,
laura.nao@collabora.com, boris.brezillon@collabora.com,
daniel.almeida@collabora.com
Subject: Re: [PATCH v3] rust: iommu: add device lifetime to IoPageTable
Date: Fri, 31 Jul 2026 12:48:19 +0000 [thread overview]
Message-ID: <amyZkwWyyAVSgdYP@google.com> (raw)
In-Reply-To: <amtFbx_6SN6kgHQK@8bytes.org>
On Thu, Jul 30, 2026 at 02:37:30PM +0200, Joerg Roedel (AMD) wrote:
> On Fri, Jul 03, 2026 at 05:28:44PM -0700, Deborah Brouwer wrote:
> > Currently, using a raw IoPageTable is unsafe because the returned
> > IoPageTable is not tied to the device driver binding lifetime.
> >
> > Since device drivers now receive a lifetime parameter <'bound>
> > representing the interval during which a device driver is bound to its bus
> > device, add a lifetime parameter to IoPageTable. This ensures that
> > the returned IoPageTable cannot outlive the bus device binding.
> >
> > Also remove the option to create a page table as a device resource since
> > currently Devres is not compatible with resources that have a lifetime
> > parameter. This option can be restored once the lifetime-aware
> > wrapper for devres is available and if a use-case appears for it.
> >
> > Suggested-by: Boris Brezillon <boris.brezillon@collabora.com>
> > Signed-off-by: Deborah Brouwer <deborah.brouwer@collabora.com>
> > ---
> > Changes in v3:
> > - Rename 'bound to 'a since the page table could have a shorter
> > lifetime than the whole device bound.
> > - Remove the TODO comment about restoring the devres option.
> > - Link to v2: https://lore.kernel.org/r/20260703-pgtable_lt_b4-v2-1-f14da6d4106d@collabora.com
> >
> > Changes in v2:
> > - Renamed new_raw() to new(), since the constructor is now safe.
> > - Link to v1: https://lore.kernel.org/rust-for-linux/20260702-pgtable_lt_v1-v1-1-18d9c9812a1a@collabora.com
> > ---
> > rust/kernel/iommu/pgtable.rs | 32 +++++++++-----------------------
> > 1 file changed, 9 insertions(+), 23 deletions(-)
>
> Acked-by: Joerg Roedel <joerg.roedel@amd.com>
Applied to drm-rust-next. Thanks!
prev parent reply other threads:[~2026-07-31 12:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-04 0:28 [PATCH v3] rust: iommu: add device lifetime to IoPageTable Deborah Brouwer
2026-07-06 7:07 ` Alice Ryhl
2026-07-09 15:00 ` Danilo Krummrich
2026-07-09 15:46 ` Alice Ryhl
2026-07-30 12:37 ` Joerg Roedel (AMD)
2026-07-31 12:48 ` Alice Ryhl [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=amyZkwWyyAVSgdYP@google.com \
--to=aliceryhl@google.com \
--cc=a.hindborg@kernel.org \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun@kernel.org \
--cc=boris.brezillon@collabora.com \
--cc=dakr@kernel.org \
--cc=daniel.almeida@collabora.com \
--cc=deborah.brouwer@collabora.com \
--cc=gary@garyguo.net \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=laura.nao@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=ojeda@kernel.org \
--cc=robin.murphy@arm.com \
--cc=rust-for-linux@vger.kernel.org \
--cc=samitolvanen@google.com \
--cc=tmgross@umich.edu \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox