From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=217.140.110.172 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795086631; b=kpOkTNezzWYF242zQFPDrKo4rfDkc6J0uuUfZhRGi+Ul6i20Y/wK17wP4xCDGk8mHh69 IHNNZXmZ8OGkt6/UoibykRJ3uHlmkJPFaNVKSFeVq5UySt0+t6WKztJSNMqpm4+CjUiWb 4vt5Ro6IwGD0/mVeo1QltTPHvYPERYmd+ySrpiSO7WgQhVFDJHb9vbq2KkJhsCLtBNJ6m CO/KMuArRNeDSUzxGwAdhvkkixuGqfOqXFU7pFEz2Ajyy2o8x9pgYGBw9wLpKs1WCoh+h 96Q4LLgyuYhKZyaghzeY29TZeIpkKA+/WezQNbydUFxPpi2ofUBWIgWjj9CrigV+HWw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795086631; h=DMARC-Filter:Received:Received:DKIM-Signature:Date:From:To:Cc: Subject:Message-ID:References:MIME-Version:Content-Type: Content-Disposition:Content-Transfer-Encoding:In-Reply-To; bh=5ytGgE5GZUr/psUPZbg0FpgA9hVlt3IvYR3bQr99uXI=; b=wQW3D0NDSPBxzKgsj0dqSoS5TREq5kv5uQqCLv8CJj5DRQxTKc4t264aOVEoHED1EIkQ hZ1JXJRQCUmcy5WjduQ1t7e+Yvoj9cxbp/mahkcb33QbwYR+ptKqrYhvb3yC96i53jmDh pS4d3Nhc4ylEETxu+wYRgUhNO1rSBvqqZKybCW/9MF5zNWVHP6+G2kpSDLapQfVdFfzms JdbBdOpPpA8+Ao0YfxuHXrjLK6tiiJ9MOAnPaNI/bYi8g+tVFPDS+tiLCFD0E8LF0ItK6 ia7VxmxrHM5X7ws3nFXfO+Zb8NX3EugkrWHeyMRnWyEA4OaAyL7a0gItmT+XNhtvIEg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=foss header.b=jyFqEFJn; arc=none smtp.remote-ip=217.140.110.172 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 86069606A32C for ; Thu, 19 Nov 2026 11:10:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 86069606A32C Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=foss header.b=jyFqEFJn Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0A8BA1AC1 for ; Thu, 19 Nov 2026 03:10:27 -0800 (PST) Received: from [192.168.0.1] (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id C04793F882 for ; Thu, 19 Nov 2026 03:10:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1795086630; bh=0vFrVGLPoOZ2lULqO3Q0WBMmFaK4e3iZvfwtZtTXdoE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jyFqEFJnQEFciMRRzqBx5K+01o+8koRaIajLqht0ZGnwcSVRBQ21r++nMmQLcwvhe XGG2vonS+slilg5UOHFAFG93L7q/kvVL3++7dZzzbUdZP5G8aogG+EreYq5dWX6Jp3 fN71tuiOUlAkz2S13IyFqF7Df3aNN2kSNacHRg5c= Date: Thu, 19 Nov 2026 11:10:15 +0000 From: Liviu Dudau To: Christian Gmeiner Cc: Boris Brezillon , Steven Price , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Daniel Almeida , Alice Ryhl , Lukas Zapolskas , Paul Toadere , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, Christian Gmeiner Subject: Re: [PATCH v2 0/3] drm/panthor: Report fault information to userspace Message-ID: References: <20261104-panthor-fault-info-v2-v2-0-673b31f3840c@igalia.com> X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20261104-panthor-fault-info-v2-v2-0-673b31f3840c@igalia.com> On Wed, Nov 04, 2026 at 08:52:38AM +0100, Christian Gmeiner wrote: > The Panthor CSF firmware and hardware report extra information when a > fault happens. Two kinds of faults matter here: > * faults raised at the address space level. These are fatal for every > group bound to that VM. > * fatal faults raised on one of the queues of a group. They stop > further submissions on that group. > > This series exposes that information to userspace, so the > VK_KHR_device_fault extension can be implemented on top of it. > > VM faults are reported through VM_GET_STATE. The VM keeps the raw > AS_FAULTSTATUS and AS_FAULTADDRESS of its last fault. Queue fatal > errors are reported through GROUP_GET_STATE. Each queue keeps its raw > CS_FATAL and CS_FATAL_INFO, and the ioctl returns them in an array > indexed by queue. The kernel does not decode the values, userspace > does. Nothing is allocated in the fault paths. > > Changes in v2: > - Report VM faults through VM_GET_STATE instead of copying them into > every group bound to the VM. > - Pass the raw register values to userspace instead of decoded fields. > - Keep one fatal slot per queue. A queue stops at its first fatal > error, so no allocation is needed. > - Store the uAPI structs directly in the kernel objects. > - Dropped the recoverable CS_FAULT reporting for now. > - Bump the driver version to 1.10 in a separate patch. > - Rebased on drm-misc-next. The queue fatal info is protected by > events_lock now that fatal events are processed under it. > > Link to v1: https://lore.kernel.org/r/20251215115457.2137485-1-lukas.zapolskas@arm.com > > Signed-off-by: Christian Gmeiner > --- > Christian Gmeiner (3): > drm/panthor: Report the last VM fault through VM_GET_STATE > drm/panthor: Report the CS fatal errors through GROUP_GET_STATE > drm/panthor: Bump the driver version to 1.10 > > drivers/gpu/drm/panthor/panthor_drv.c | 26 +++++++++++++++-- > drivers/gpu/drm/panthor/panthor_mmu.c | 33 +++++++++++++++++++-- > drivers/gpu/drm/panthor/panthor_mmu.h | 2 ++ > drivers/gpu/drm/panthor/panthor_sched.c | 32 +++++++++++++++++++- > drivers/gpu/drm/panthor/panthor_sched.h | 5 +++- > include/uapi/drm/panthor_drm.h | 52 +++++++++++++++++++++++++++++++++ > 6 files changed, 143 insertions(+), 7 deletions(-) > --- > base-commit: 6f7098738fff3ec7393f924343188cb8e6ebc5d2 > change-id: 20261014-panthor-fault-info-v2-330a9f771fd3 > > Best regards, > -- > Christian Gmeiner > Sorry for the delay! For the whole series: Reviewed-by: Liviu Dudau Best regards, Liviu -- ==================== | I would like to | | fix the world, | | but they're not | | giving me the | \ source code! / --------------- ¯\_(ツ)_/¯