From: John Hubbard <jhubbard@nvidia.com>
To: Alexandre Courbot <acourbot@nvidia.com>,
Alice Ryhl <aliceryhl@google.com>
Cc: Zhi Wang <zhiw@nvidia.com>,
rust-for-linux@vger.kernel.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org, dakr@kernel.org,
bhelgaas@google.com, kwilczynski@kernel.org, ojeda@kernel.org,
alex.gaynor@gmail.com, boqun.feng@gmail.com, gary@garyguo.net,
bjorn3_gh@protonmail.com, lossin@kernel.org,
a.hindborg@kernel.org, tmgross@umich.edu,
markus.probst@posteo.de, helgaas@kernel.org, cjia@nvidia.com,
smitra@nvidia.com, ankita@nvidia.com, aniketa@nvidia.com,
kwankhede@nvidia.com, targupta@nvidia.com, joelagnelf@nvidia.com,
zhiwang@kernel.org
Subject: Re: [PATCH v7 3/6] rust: io: factor common I/O helpers into Io trait
Date: Tue, 25 Nov 2025 11:19:25 -0800 [thread overview]
Message-ID: <b0715438-af4f-441a-84c0-8e4abc621df6@nvidia.com> (raw)
In-Reply-To: <DEHUVC6D60HX.CBJ6ZKGUMA8K@nvidia.com>
On 11/25/25 6:46 AM, Alexandre Courbot wrote:
> On Tue Nov 25, 2025 at 11:22 PM JST, Alice Ryhl wrote:
>> On Tue, Nov 25, 2025 at 3:15 PM Alexandre Courbot <acourbot@nvidia.com> wrote:
...
>> If you have IoInfallible depend on IoFallible, then you can place
>> `addr` on IoFallible.
>
> Indeed. Maybe we could even make `IoInfallible` automatically
> implemented, since it just needs to `unwrap_unchecked` the fallible
> implementation if the range is valid.
>
>> (And I still think you should rename IoFallible to Io and IoInfallible
>> to IoKnownSize.)
>
> Agreed, there are other reasons for I/O to fail than a bad index so this
> should not be part of the name of these traits.
Great! That neatly fixes the naming problem that was bothering me about
Io*, too.
thanks,
--
John Hubbard
next prev parent reply other threads:[~2025-11-25 19:19 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-19 11:21 [PATCH v7 0/6] rust: pci: add config space read/write support Zhi Wang
2025-11-19 11:21 ` [PATCH v7 1/6] samples: rust: rust_driver_pci: use "kernel vertical" style for imports Zhi Wang
2025-11-19 11:21 ` [PATCH v7 2/6] rust: devres: " Zhi Wang
2025-11-19 11:21 ` [PATCH v7 3/6] rust: io: factor common I/O helpers into Io trait Zhi Wang
2025-11-21 14:20 ` Alice Ryhl
2025-11-24 10:08 ` Zhi Wang
2025-11-24 10:20 ` Alice Ryhl
2025-11-24 13:32 ` Zhi Wang
2025-11-24 13:53 ` Alexandre Courbot
2025-11-25 13:44 ` Alexandre Courbot
2025-11-25 14:58 ` Alice Ryhl
2025-11-26 0:43 ` Alexandre Courbot
2025-11-26 7:52 ` Alexandre Courbot
2025-11-26 9:50 ` Alice Ryhl
2025-11-26 13:37 ` Alexandre Courbot
2025-11-26 13:39 ` Alexandre Courbot
2025-12-01 11:57 ` Alexandre Courbot
2025-12-01 12:23 ` Alice Ryhl
2025-12-03 13:32 ` Alexandre Courbot
2025-11-25 14:09 ` Alexandre Courbot
2025-11-25 14:14 ` Alexandre Courbot
2025-11-25 14:22 ` Alice Ryhl
2025-11-25 14:46 ` Alexandre Courbot
2025-11-25 19:19 ` John Hubbard [this message]
2025-11-19 11:21 ` [PATCH v7 4/6] rust: io: factor out MMIO read/write macros Zhi Wang
2025-11-19 11:21 ` [PATCH v7 5/6] rust: pci: add config space read/write support Zhi Wang
2025-11-25 14:20 ` Alexandre Courbot
2025-11-19 11:21 ` [PATCH v7 6/6] sample: rust: pci: add tests for config space routines Zhi Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b0715438-af4f-441a-84c0-8e4abc621df6@nvidia.com \
--to=jhubbard@nvidia.com \
--cc=a.hindborg@kernel.org \
--cc=acourbot@nvidia.com \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=aniketa@nvidia.com \
--cc=ankita@nvidia.com \
--cc=bhelgaas@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=cjia@nvidia.com \
--cc=dakr@kernel.org \
--cc=gary@garyguo.net \
--cc=helgaas@kernel.org \
--cc=joelagnelf@nvidia.com \
--cc=kwankhede@nvidia.com \
--cc=kwilczynski@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=markus.probst@posteo.de \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=smitra@nvidia.com \
--cc=targupta@nvidia.com \
--cc=tmgross@umich.edu \
--cc=zhiw@nvidia.com \
--cc=zhiwang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).