rust-for-linux.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dirk Behme <dirk.behme@de.bosch.com>
To: "Remo Senekowitsch" <remo@buenzli.dev>,
	"Rob Herring" <robh@kernel.org>,
	"Saravana Kannan" <saravanak@google.com>,
	"Miguel Ojeda" <ojeda@kernel.org>,
	"Alex Gaynor" <alex.gaynor@gmail.com>,
	"Boqun Feng" <boqun.feng@gmail.com>,
	"Gary Guo" <gary@garyguo.net>,
	"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
	"Benno Lossin" <lossin@kernel.org>,
	"Andreas Hindborg" <a.hindborg@kernel.org>,
	"Alice Ryhl" <aliceryhl@google.com>,
	"Trevor Gross" <tmgross@umich.edu>,
	"Danilo Krummrich" <dakr@kernel.org>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>
Cc: <linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<rust-for-linux@vger.kernel.org>
Subject: Re: [PATCH v7 0/9] More Rust bindings for device property reads
Date: Tue, 3 Jun 2025 07:10:49 +0200	[thread overview]
Message-ID: <b2225fa4-ffdb-4156-afb9-561484d6d78e@de.bosch.com> (raw)
In-Reply-To: <20250530192856.1177011-1-remo@buenzli.dev>

Hi Remo,

On 30/05/2025 21:28, Remo Senekowitsch wrote:
> changes in v7:
> * Fix a typo in a commit message.
> * Fix bug in `FwNode::display_path`. I took a slightly different
>   approach than the one suggested, using `Either` to handle the
>   owned and borrowed case. That also removes the conditional
>   `fwnode_handle_put` at the end.
> * Move `FwNode::from_raw` to the commit which first introduces the
>   `FwNode` abstraction. It is needed in an earlier commit than before
>   and I think it fits better there.
> 
> Best regards,
> Remo
> 
> Remo Senekowitsch (9):
>   rust: device: Create FwNode abstraction for accessing device
>     properties
>   rust: device: Enable accessing the FwNode of a Device
>   rust: device: Add property_present() to FwNode
>   rust: device: Enable printing fwnode name and path
>   rust: device: Introduce PropertyGuard
>   rust: device: Implement accessors for firmware properties
>   rust: device: Add child accessor and iterator
>   rust: device: Add property_get_reference_args
>   samples: rust: platform: Add property read examples
> 
>  MAINTAINERS                                  |   1 +
>  drivers/of/unittest-data/tests-platform.dtsi |   3 +
>  rust/helpers/helpers.c                       |   1 +
>  rust/helpers/property.c                      |   8 +
>  rust/kernel/device.rs                        |  17 +
>  rust/kernel/device/property.rs               | 590 +++++++++++++++++++
>  samples/rust/rust_driver_platform.rs         |  60 +-
>  7 files changed, 679 insertions(+), 1 deletion(-)
>  create mode 100644 rust/helpers/property.c
>  create mode 100644 rust/kernel/device/property.rs
I have tested this series with x86/Qemu running the sample. And the same
on real custom ARM64 hardware. Additionally, I ported a custom driver on
ARM64 to use this (well, it just uses the trivial
property_read().required_by()). So if it helps

Tested-by: Dirk Behme <dirk.behme@de.bosch.com>

for the whole series.

Btw, many thanks for working on this!

Dirk

      parent reply	other threads:[~2025-06-03  5:11 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-30 19:28 [PATCH v7 0/9] More Rust bindings for device property reads Remo Senekowitsch
2025-05-30 19:28 ` [PATCH v7 1/9] rust: device: Create FwNode abstraction for accessing device properties Remo Senekowitsch
2025-05-30 19:28 ` [PATCH v7 2/9] rust: device: Enable accessing the FwNode of a Device Remo Senekowitsch
2025-05-30 19:28 ` [PATCH v7 3/9] rust: device: Add property_present() to FwNode Remo Senekowitsch
2025-05-30 19:28 ` [PATCH v7 4/9] rust: device: Enable printing fwnode name and path Remo Senekowitsch
2025-05-30 19:28 ` [PATCH v7 5/9] rust: device: Introduce PropertyGuard Remo Senekowitsch
2025-06-05 15:08   ` Rob Herring
2025-06-05 16:16     ` Remo Senekowitsch
2025-05-30 19:28 ` [PATCH v7 6/9] rust: device: Implement accessors for firmware properties Remo Senekowitsch
2025-05-30 19:28 ` [PATCH v7 7/9] rust: device: Add child accessor and iterator Remo Senekowitsch
2025-05-30 19:28 ` [PATCH v7 8/9] rust: device: Add property_get_reference_args Remo Senekowitsch
2025-05-30 19:28 ` [PATCH v7 9/9] samples: rust: platform: Add property read examples Remo Senekowitsch
2025-05-30 19:56 ` [PATCH v7 0/9] More Rust bindings for device property reads Danilo Krummrich
2025-05-30 21:45   ` Remo Senekowitsch
2025-05-30 21:50     ` Danilo Krummrich
2025-06-05 15:21       ` Rob Herring
2025-06-03  5:10 ` Dirk Behme [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b2225fa4-ffdb-4156-afb9-561484d6d78e@de.bosch.com \
    --to=dirk.behme@de.bosch.com \
    --cc=a.hindborg@kernel.org \
    --cc=alex.gaynor@gmail.com \
    --cc=aliceryhl@google.com \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun.feng@gmail.com \
    --cc=dakr@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gary@garyguo.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lossin@kernel.org \
    --cc=ojeda@kernel.org \
    --cc=rafael@kernel.org \
    --cc=remo@buenzli.dev \
    --cc=robh@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=saravanak@google.com \
    --cc=tmgross@umich.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).