From: Andrew Lunn <andrew@lunn.ch>
To: FUJITA Tomonori <fujita.tomonori@gmail.com>
Cc: benno.lossin@proton.me, tmgross@umich.edu,
rust-for-linux@vger.kernel.org
Subject: Re: [RFC PATCH v1] rust: net::phy support to C45 registers access
Date: Fri, 31 May 2024 16:12:19 +0200 [thread overview]
Message-ID: <b376f314-e48e-4af0-a686-e208d129ed79@lunn.ch> (raw)
In-Reply-To: <20240530.145258.456915814420167538.fujita.tomonori@gmail.com>
> With updating this patch, I've started to think that it would be more
> consistent for the driver to use phy_read_mmd/phy_write_mmd rather
> than mdiobus_c45_read and mdiobus_c45_write (RegC45 than RegC45Direct
> in this patch). This is because the driver uses
> genphy_c45_read_status() helper for the read_status callback, which
> also lets phylib to choose an appropriate bus protocol.
genphy_c45_read_status() is a good point. We need to keep with the
normal way phylib works, otherwise all the helper functions will
break. So i think you need to implement the struct phy_driver
.read_mmd and .write_mmd ops to do direct C45 accesses. That is not
really how it should work, but that is a phylib problem, not a Rust
problem.
Andrew
next prev parent reply other threads:[~2024-05-31 14:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-27 1:46 [RFC PATCH v1] rust: net::phy support to C45 registers access FUJITA Tomonori
2024-05-27 21:57 ` Andrew Lunn
2024-05-27 23:03 ` FUJITA Tomonori
2024-05-28 0:18 ` Andrew Lunn
2024-05-30 5:52 ` FUJITA Tomonori
2024-05-31 14:12 ` Andrew Lunn [this message]
2024-05-30 8:05 ` Benno Lossin
2024-05-31 13:58 ` FUJITA Tomonori
2024-05-31 14:04 ` Benno Lossin
2024-06-01 4:51 ` FUJITA Tomonori
2024-05-30 8:02 ` Benno Lossin
2024-06-01 4:20 ` FUJITA Tomonori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b376f314-e48e-4af0-a686-e208d129ed79@lunn.ch \
--to=andrew@lunn.ch \
--cc=benno.lossin@proton.me \
--cc=fujita.tomonori@gmail.com \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).