From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3989C2EAF1
	for <rust-for-linux@vger.kernel.org>; Mon,  6 Nov 2023 22:17:02 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=proton.me header.i=@proton.me header.b="AhnJxO6x"
Received: from mail-4316.protonmail.ch (mail-4316.protonmail.ch [185.70.43.16])
	by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 24DE1183;
	Mon,  6 Nov 2023 14:17:01 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=proton.me;
	s=protonmail; t=1699309018; x=1699568218;
	bh=BNxWJUeheK6gz+So6VEqeeEFNOpFymOedNOxNufT0d0=;
	h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References:
	 Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:
	 Message-ID:BIMI-Selector;
	b=AhnJxO6x4c/fSu8ujTAjajj1x3Mu/Din++uRfo0kverW+MHLIWmWKx6WmTmU8yp9R
	 7FPjgfq3tlf+8MnWO8JaZ8okYOBh+tm9RngiZFaEjYZ9oqCfoOZGzHvsUixNPT7bhg
	 /lq0bX4cnwl1AJ31WUs623LDmb4n3yG/+kZLaBwmZTxLuEhT4+X+iDbvhlajZKeQUP
	 H1VbBmfHizNix7nj9LQ1usxSoPPXIpGzO9d8eqWjzO3DRyzuq5PowRaqKkeA/F5kDk
	 oAqZkk3KM0acDSjIfA/siNk4XHRWeV2SrznQn/25k6gS+WSgItnlvUG5ijFr2n5JsO
	 OPwBsbG6zf+ZQ==
Date: Mon, 06 Nov 2023 22:16:53 +0000
To: Gary Guo <gary@garyguo.net>, Miguel Ojeda <ojeda@kernel.org>, Alex Gaynor <alex.gaynor@gmail.com>, Wedson Almeida Filho <wedsonaf@gmail.com>, Boqun Feng <boqun.feng@gmail.com>, =?utf-8?Q?Bj=C3=B6rn_Roy_Baron?= <bjorn3_gh@protonmail.com>, Andreas Hindborg <a.hindborg@samsung.com>, Alice Ryhl <aliceryhl@google.com>, Martin Rodriguez Reboredo <yakoyoku@gmail.com>, Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
From: Benno Lossin <benno.lossin@proton.me>
Cc: Wedson Almeida Filho <walmeida@microsoft.com>, Vlastimil Babka <vbabka@suse.cz>, rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] rust: bindings: rename const binding using sed
Message-ID: <b73f01b8-1253-40df-8e22-06b6e3b6755d@proton.me>
In-Reply-To: <20231104145700.2495176-1-gary@garyguo.net>
References: <20231104145700.2495176-1-gary@garyguo.net>
Feedback-ID: 71780778:user:proton
Precedence: bulk
X-Mailing-List: rust-for-linux@vger.kernel.org
List-Id: <rust-for-linux.vger.kernel.org>
List-Subscribe: <mailto:rust-for-linux+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:rust-for-linux+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On 04.11.23 15:56, Gary Guo wrote:
> diff --git a/rust/Makefile b/rust/Makefile
> index a27f35f924ec..57f7f5e5a95d 100644
> --- a/rust/Makefile
> +++ b/rust/Makefile
> @@ -337,6 +337,8 @@ quiet_cmd_bindgen =3D BINDGEN $@
>=20
>   $(obj)/bindings/bindings_generated.rs: private bindgen_target_flags =3D=
 \
>       $(shell grep -Ev '^#|^$$' $(srctree)/$(src)/bindgen_parameters)
> +$(obj)/bindings/bindings_generated.rs: private bindgen_target_extra =3D =
; \
> +    sed -Ei 's/pub const RUST_CONST_HELPER_([a-zA-Z0-9_]*)/pub const \1/=
g' $@

I think I mentioned this before, but I think this should use `^`
to ensure that this is only replaced at the beginning of lines.

--=20
Cheers,
Benno