Re: [PATCH v9 00/31] gpu: nova-core: firmware: Hopper/Blackwell support

[John Hubbard <jhubbard@nvidia.com>]

On 4/7/26 6:51 PM, Alexandre Courbot wrote:
> On Thu Mar 26, 2026 at 10:38 AM JST, John Hubbard wrote:
...
> A few remarks on the ordering:
> 
> - Patches 2 and 3 should come first, so the code is reorganized before
>   we add the new architecture (and to reduce the overall diff). This
>   also allows us to apply these patches earlier, as they are valuable
>   regardless of Blackwell support.
> - Patch 26 looks like it is independent from the rest of the series - it
>   could have been merged earlier if it was placed at the beginning of
>   the series.
> - Same for patch 17, although the commit log mentions Blackwell (but not
>   the code).
> - The progression of the series is such that it adds new features that
>   remain unused until the final patch which exercices the FSP boot path.
>   We could avoid that by introducing `boot_via_fsp` early in the series
>   (making it just return `ENOPSUPP`), and completing it as the FSP
>   features become available. This removes a lot of `dead_code`s, and
>   also provides a logical order for the patches since it can follow the
>   flow of `boot_via_fsp`.
>

OK.

 
> I still want to dive in depth into the messaging parts, but I think I'll
> keep that for next respin to avoid giving too much feedback on a single
> revision. :) At least we can say that the overall structure seems to be
> converging.

Yes, and I'll also apply SizeConstants to the series, now that it's
available to us in this particular branch setup.

thanks,
-- 
John Hubbard