rust-for-linux.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: John Hubbard <jhubbard@nvidia.com>
To: Alexandre Courbot <acourbot@nvidia.com>,
	Joel Fernandes <joelagnelf@nvidia.com>,
	linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org,
	dri-devel@lists.freedesktop.org,
	Danilo Krummrich <dakr@kernel.org>
Cc: Alistair Popple <apopple@nvidia.com>,
	Miguel Ojeda <ojeda@kernel.org>,
	Alex Gaynor <alex.gaynor@gmail.com>,
	Boqun Feng <boqun.feng@gmail.com>, Gary Guo <gary@garyguo.net>,
	bjorn3_gh@protonmail.com, Benno Lossin <lossin@kernel.org>,
	Andreas Hindborg <a.hindborg@kernel.org>,
	Alice Ryhl <aliceryhl@google.com>,
	Trevor Gross <tmgross@umich.edu>,
	David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Timur Tabi <ttabi@nvidia.com>,
	joel@joelfernandes.org,
	Daniel Almeida <daniel.almeida@collabora.com>,
	nouveau@lists.freedesktop.org,
	Nouveau <nouveau-bounces@lists.freedesktop.org>
Subject: Re: [PATCH v5 00/13] nova-core: Complete GSP boot and begin RPC communication
Date: Sat, 15 Nov 2025 18:32:49 -0800	[thread overview]
Message-ID: <ba4da7b2-39f8-4d23-9a40-581ea94437f2@nvidia.com> (raw)
In-Reply-To: <DE9B0XPTIUC0.NKSRERTX9YI3@nvidia.com>

On 11/15/25 5:31 AM, Alexandre Courbot wrote:
> On Sat Nov 15, 2025 at 4:55 AM JST, Joel Fernandes wrote:
...
> Pushed to drm-rust-next with the changes I mentioned inline, thanks!
> 
> We will definitely want to make our interfaces evolves some more
> (notably the command queue), and there are still a few nits to address,
> but we have been kicking the can down the road for quite some time with
> this one and in its current shape it provides a good foundation for the
> next stuff to build upon.
> 
> The GSP is now initialized - not that it does anything beyond telling us
> its name, but it's a milestone nonetheless! :)

Yes, a wonderful milestone, congratulations to everyone involved!

And a special thanks to the many Rust for Linux reviewers (that includes Alex
Courbot here), who have been as patient as saints while our Nova team learns
Rust at the same time as writing the driver (!).

Here's the latest dmesg verbose output from today's drm-rust-next running on my
local test machine:

NovaCore 0000:e1:00.0: Probe Nova Core GPU driver.
NovaCore 0000:e1:00.0: NVIDIA (Chipset: GA104, Architecture: Ampere, Revision: a.1)
...
NovaCore 0000:e1:00.0: RISC-V active? true
NovaCore 0000:e1:00.0: GSP RPC: receive: seq# 0, function=Ok(GspRunCpuSequencer), length=0x18e8
NovaCore 0000:e1:00.0: Running CPU Sequencer commands
NovaCore 0000:e1:00.0: CPU Sequencer commands completed successfully
NovaCore 0000:e1:00.0: GSP RPC: receive: seq# 0, function=Ok(GspPostNoCat), length=0x50c
NovaCore 0000:e1:00.0: GSP RPC: receive: seq# 0, function=Ok(UcodeLibOsPrint), length=0x68
NovaCore 0000:e1:00.0: GSP RPC: receive: seq# 0, function=Ok(UcodeLibOsPrint), length=0x70
NovaCore 0000:e1:00.0: GSP RPC: receive: seq# 0, function=Ok(GspInitDone), length=0x50
NovaCore 0000:e1:00.0: GSP RPC: send: seq# 2, function=GET_GSP_STATIC_INFO, length=0x6c8
NovaCore 0000:e1:00.0: GSP RPC: receive: seq# 0, function=Ok(GetGspStaticInfo), length=0x6c8
NovaCore 0000:e1:00.0: GPU name: NVIDIA RTX A4000

Beautiful!

It is so great to finally see this emitted from a driver built from top of tree
drm-rust-next, at last. :)


thanks,
-- 
John Hubbard


      reply	other threads:[~2025-11-16  2:32 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-14 19:55 [PATCH v5 00/13] nova-core: Complete GSP boot and begin RPC communication Joel Fernandes
2025-11-14 19:55 ` [PATCH v5 01/13] gpu: nova-core: falcon: Move waiting until halted to a helper Joel Fernandes
2025-11-14 19:55 ` [PATCH v5 02/13] gpu: nova-core: falcon: Move start functionality into separate helper Joel Fernandes
2025-11-14 19:55 ` [PATCH v5 03/13] gpu: nova-core: falcon: Move mbox functionalities into helper Joel Fernandes
2025-11-15 11:27   ` Alexandre Courbot
2025-11-14 19:55 ` [PATCH v5 04/13] gpu: nova-core: falcon: Move dma_reset functionality " Joel Fernandes
2025-11-14 19:55 ` [PATCH v5 05/13] gpu: nova-core: gsp: Add support for checking if GSP reloaded Joel Fernandes
2025-11-14 19:55 ` [PATCH v5 06/13] gpu: nova-core: Add bindings required by GSP sequencer Joel Fernandes
2025-11-14 19:55 ` [PATCH v5 07/13] gpu: nova-core: Implement the " Joel Fernandes
2025-11-14 21:41   ` Lyude Paul
2025-11-14 22:04     ` Lyude Paul
2025-11-14 19:55 ` [PATCH v5 08/13] gpu: nova-core: sequencer: Add register opcodes Joel Fernandes
2025-11-14 21:55   ` Lyude Paul
2025-11-15 12:37     ` Alexandre Courbot
2025-11-14 19:55 ` [PATCH v5 09/13] gpu: nova-core: sequencer: Add delay opcode support Joel Fernandes
2025-11-14 21:56   ` Lyude Paul
2025-11-14 19:55 ` [PATCH v5 10/13] gpu: nova-core: sequencer: Implement basic core operations Joel Fernandes
2025-11-14 21:56   ` Lyude Paul
2025-11-14 19:55 ` [PATCH v5 11/13] gpu: nova-core: sequencer: Implement core resume operation Joel Fernandes
2025-11-14 21:58   ` Lyude Paul
2025-11-14 19:55 ` [PATCH v5 12/13] gpu: nova-core: gsp: Wait for gsp initialization to complete Joel Fernandes
2025-11-14 21:59   ` Lyude Paul
2025-11-14 19:55 ` [PATCH v5 13/13] gpu: nova-core: gsp: Retrieve GSP static info to gather GPU information Joel Fernandes
2025-11-14 22:06   ` Lyude Paul
2025-11-15 12:38   ` Alexandre Courbot
2025-11-15 21:03     ` John Hubbard
2025-11-15 13:31 ` [PATCH v5 00/13] nova-core: Complete GSP boot and begin RPC communication Alexandre Courbot
2025-11-16  2:32   ` John Hubbard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ba4da7b2-39f8-4d23-9a40-581ea94437f2@nvidia.com \
    --to=jhubbard@nvidia.com \
    --cc=a.hindborg@kernel.org \
    --cc=acourbot@nvidia.com \
    --cc=airlied@gmail.com \
    --cc=alex.gaynor@gmail.com \
    --cc=aliceryhl@google.com \
    --cc=apopple@nvidia.com \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun.feng@gmail.com \
    --cc=dakr@kernel.org \
    --cc=daniel.almeida@collabora.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gary@garyguo.net \
    --cc=joel@joelfernandes.org \
    --cc=joelagnelf@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lossin@kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=nouveau-bounces@lists.freedesktop.org \
    --cc=nouveau@lists.freedesktop.org \
    --cc=ojeda@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=simona@ffwll.ch \
    --cc=tmgross@umich.edu \
    --cc=ttabi@nvidia.com \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).