From: Abdiel Janulgue <abdiel.janulgue@gmail.com>
To: Alice Ryhl <aliceryhl@google.com>
Cc: rust-for-linux@vger.kernel.org, a.hindborg@kernel.org,
linux-kernel@vger.kernel.org, dakr@redhat.com,
airlied@redhat.com, miguel.ojeda.sandonis@gmail.com,
wedsonaf@gmail.com
Subject: Re: [PATCH 1/2] rust: error: Add EOVERFLOW
Date: Thu, 24 Oct 2024 09:09:32 +0300 [thread overview]
Message-ID: <bc15b5f4-9596-486e-a275-5cde82a92985@gmail.com> (raw)
In-Reply-To: <CAH5fLgj7zYc6jg3vyqKNc85vkAvfgD1yqrUWj2-NcyR3kDPCbQ@mail.gmail.com>
On 23/10/2024 14:39, Alice Ryhl wrote:
> On Wed, Oct 23, 2024 at 1:34 PM Abdiel Janulgue
> <abdiel.janulgue@gmail.com> wrote:
>>
>> Trivial addition for missing EOVERFLOW error.
>>
>> Signed-off-by: Abdiel Janulgue <abdiel.janulgue@gmail.com>
>> ---
>> rust/kernel/error.rs | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/rust/kernel/error.rs b/rust/kernel/error.rs
>> index 7cd3bbab52f2..92bfdaaedb02 100644
>> --- a/rust/kernel/error.rs
>> +++ b/rust/kernel/error.rs
>> @@ -63,6 +63,7 @@ macro_rules! declare_err {
>> declare_err!(EPIPE, "Broken pipe.");
>> declare_err!(EDOM, "Math argument out of domain of func.");
>> declare_err!(ERANGE, "Math result not representable.");
>> + declare_err!(EOVERFLOW, "Value too large for defined data type.");
>> declare_err!(ERESTARTSYS, "Restart the system call.");
>> declare_err!(ERESTARTNOINTR, "System call was interrupted by a signal and will be restarted.");
>> declare_err!(ERESTARTNOHAND, "Restart if no handler.");
>
> The commit message should explain why you're adding it. What will you
> use it for?
Yup I forgot to include the intent of the change, which is needed in the
next patch. But will fix in next update.
/Abdiel
next prev parent reply other threads:[~2024-10-24 6:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <gOYx0SWgtHGMFdeca-cxwYWFvr0hwCWCLCyLndrSSh8p9dU1wFSDL3ssAL-zaCfEbUyQ49dpsn8XaGfSamF-Sw==@protonmail.internalid>
2024-10-23 11:32 ` [PATCH 0/2] Add dma coherent allocator abstraction Abdiel Janulgue
2024-10-23 11:32 ` [PATCH 1/2] rust: error: Add EOVERFLOW Abdiel Janulgue
2024-10-23 11:39 ` Alice Ryhl
2024-10-24 6:09 ` Abdiel Janulgue [this message]
2024-10-23 11:32 ` [PATCH 2/2] rust: add dma coherent allocator abstraction Abdiel Janulgue
2024-10-28 7:51 ` Abdiel Janulgue
2024-10-28 15:38 ` Daniel Almeida
2024-10-31 9:45 ` Abdiel Janulgue
2024-11-11 12:14 ` [PATCH 0/2] Add " Andreas Hindborg
2024-11-11 12:54 ` Abdiel Janulgue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc15b5f4-9596-486e-a275-5cde82a92985@gmail.com \
--to=abdiel.janulgue@gmail.com \
--cc=a.hindborg@kernel.org \
--cc=airlied@redhat.com \
--cc=aliceryhl@google.com \
--cc=dakr@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=rust-for-linux@vger.kernel.org \
--cc=wedsonaf@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).