rust-for-linux.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Muhammad Usama Anjum <usama.anjum@collabora.com>
To: Laura Nao <laura.nao@collabora.com>,
	ojeda@kernel.org, alex.gaynor@gmail.com, wedsonaf@gmail.com
Cc: Muhammad Usama Anjum <usama.anjum@collabora.com>,
	boqun.feng@gmail.com, gary@garyguo.net, bjorn3_gh@protonmail.com,
	benno.lossin@proton.me, a.hindborg@samsung.com,
	aliceryhl@google.com, rust-for-linux@vger.kernel.org,
	kernel-linux@vger.kernel.org, dirk.behme@de.bosch.com,
	kernel@valentinobst.de, kernel@collabora.com
Subject: Re: [PATCH] docs: rust: Add instructions for the Rust kselftest
Date: Mon, 1 Apr 2024 17:48:24 +0500	[thread overview]
Message-ID: <bc3a91e5-d8a2-47cd-afb2-fde963e1cfac@collabora.com> (raw)
In-Reply-To: <20240329153025.150112-1-laura.nao@collabora.com>

On 3/29/24 8:30 PM, Laura Nao wrote:
> Add section describing how to build and run the Rust kselftest.
> 
> Signed-off-by: Laura Nao <laura.nao@collabora.com>
You can add following after fixing comments:
Reviewed-by: Muhammad Usama Anjum <usama.anjum@collabora.com>

> ---
>  Documentation/rust/testing.rst | 22 +++++++++++++++++++++-
>  1 file changed, 21 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/rust/testing.rst b/Documentation/rust/testing.rst
> index 6658998d1b6c..b5b99e625a01 100644
> --- a/Documentation/rust/testing.rst
> +++ b/Documentation/rust/testing.rst
> @@ -6,10 +6,11 @@ Testing
>  This document contains useful information how to test the Rust code in the
>  kernel.
>  
> -There are two sorts of tests:
> +There are three sorts of tests:
>  
>  - The KUnit tests.
>  - The ``#[test]`` tests.
> +- The Kselftest.
>  
>  The KUnit tests
>  ---------------
> @@ -133,3 +134,22 @@ Additionally, there are the ``#[test]`` tests. These can be run using the
>  This requires the kernel ``.config`` and downloads external repositories. It
>  runs the ``#[test]`` tests on the host (currently) and thus is fairly limited in
>  what these tests can test.
> +
> +The Kselftest
> +---------------------
The number of dashes are more than required. There should have been error
or warning while documentation building. It should be as following:

The Kselftest
-------------

> +
> +A Kselftest is also available, which verifies that the Rust sample modules
> +can be added and removed correctly.
> +
> +The kernel config options required for the test are listed in the
> +tools/testing/selftests/rust/config file and can be included with the aid
> +of the merge_config.sh script::
> +
> +	./scripts/kconfig/merge_config.sh .config tools/testing/selftests/rust/config
> +
> +To build and run the test, use::
> +
> +	make TARGETS="rust" kselftest
> +
> +Refer to Documentation/dev-tools/kselftest.rst for the general Kselftest
> +documentation.

-- 
BR,
Muhammad Usama Anjum

      parent reply	other threads:[~2024-04-01 12:47 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-29 15:30 [PATCH] docs: rust: Add instructions for the Rust kselftest Laura Nao
2024-03-29 16:47 ` Miguel Ojeda
2024-03-29 17:13 ` Valentin Obst
2024-04-01 12:48 ` Muhammad Usama Anjum [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bc3a91e5-d8a2-47cd-afb2-fde963e1cfac@collabora.com \
    --to=usama.anjum@collabora.com \
    --cc=a.hindborg@samsung.com \
    --cc=alex.gaynor@gmail.com \
    --cc=aliceryhl@google.com \
    --cc=benno.lossin@proton.me \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun.feng@gmail.com \
    --cc=dirk.behme@de.bosch.com \
    --cc=gary@garyguo.net \
    --cc=kernel-linux@vger.kernel.org \
    --cc=kernel@collabora.com \
    --cc=kernel@valentinobst.de \
    --cc=laura.nao@collabora.com \
    --cc=ojeda@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=wedsonaf@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).