From: Jocelyn Falempe <jfalempe@redhat.com>
To: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Cc: Andrei Lalaev <andrey.lalaev@gmail.com>,
Miguel Ojeda <ojeda@kernel.org>,
Christian Schrefl <chrisi.schrefl@gmail.com>,
Arnd Bergmann <arnd@arndb.de>,
Russell King <linux@armlinux.org.uk>,
Paolo Bonzini <pbonzini@redhat.com>,
rust-for-linux <rust-for-linux@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
Javier Martinez Canillas <javierm@redhat.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/panic: Add a u64 divide by 10 for arm32
Date: Fri, 27 Jun 2025 13:52:49 +0200 [thread overview]
Message-ID: <bc3cf135-5432-4cdb-8992-7c400e728a97@redhat.com> (raw)
In-Reply-To: <CANiq72=aiAnn3n7ADgmKUNNSp7HfBjRc1ftG2qSD4EFUkS3jqw@mail.gmail.com>
On 27/06/2025 13:44, Miguel Ojeda wrote:
> On Fri, Jun 27, 2025 at 11:41 AM Jocelyn Falempe <jfalempe@redhat.com> wrote:
>>
>> +/// On arm32 architecture, dividing an u64 by a constant will generate a call
>> +/// to __aeabi_uldivmod which is not present in the kernel.
>> +/// So use the multiply by inverse method for this architecture.
>
> This sounds more like a normal comment instead of function docs, no?
Yes, I think I'm still confused between // and ///, so I will replace
with //.
>
> By the way, formatting:
>
> `u64`
> `__aeabi_uldivmod`
ok, I will do that in v2.
>
> Thanks for fixing this! It is nice seeing 32-bit arm taking shape.
Thank you for your reactivity
>
> Cheers,
> Miguel
>
--
Jocelyn
prev parent reply other threads:[~2025-06-27 11:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-27 9:40 [PATCH] drm/panic: Add a u64 divide by 10 for arm32 Jocelyn Falempe
2025-06-27 11:36 ` Alice Ryhl
2025-06-27 11:41 ` Miguel Ojeda
2025-06-27 11:47 ` Jocelyn Falempe
2025-06-27 11:44 ` Miguel Ojeda
2025-06-27 11:52 ` Jocelyn Falempe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc3cf135-5432-4cdb-8992-7c400e728a97@redhat.com \
--to=jfalempe@redhat.com \
--cc=airlied@gmail.com \
--cc=andrey.lalaev@gmail.com \
--cc=arnd@arndb.de \
--cc=chrisi.schrefl@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=javierm@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=maarten.lankhorst@linux.intel.com \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=mripard@kernel.org \
--cc=ojeda@kernel.org \
--cc=pbonzini@redhat.com \
--cc=rust-for-linux@vger.kernel.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).