From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mout02.posteo.de (mout02.posteo.de [185.67.36.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B96EA3806A6 for ; Sun, 13 Sep 2026 16:24:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.67.36.66 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789316658; cv=none; b=u0Ak9uHa6ZpMxEWPHr2KnnOYTnvhhvX6GUs0M5NZ+WgvvWCRBUw3+DTNLTxJ9rawevSmdSBh2kkPpKmOiC7d98E0qn0L0grFEjIxifiBYcnwU2RFJibKSogu1wkJwc+MPu16AepdfwyI/buhN6Mgsmtg1g3Dn7R3qeLIQtXEZG4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789316658; c=relaxed/simple; bh=yymUnlFMbFRaI+zM6TZ1QhF7FtNy1mLIdFau2Q5EO9Q=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=CRBIagEMeeXO6LV3Q8gQM4RRC6kzQxZECKra5JFKBWH7Bo0Jxh4AjKVpycA6+iQwwE6Lvq+517GtsCg/U1QPgZnk6Fd20pfwK6SXHIO+npMT3seuVsu2MAUbsOdoKuiMhIlVidS62nh6gsZFs+yYOr6+aGauacf25dkGeJJY5mU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=posteo.de; spf=pass smtp.mailfrom=posteo.de; dkim=pass (2048-bit key) header.d=posteo.de header.i=@posteo.de header.b=CmeI1HTQ; arc=none smtp.client-ip=185.67.36.66 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=posteo.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=posteo.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=posteo.de header.i=@posteo.de header.b="CmeI1HTQ" Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 2374D240105 for ; Sun, 13 Sep 2026 18:24:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=posteo.de; s=1984.8680eb; t=1789316649; bh=BR/kOTPy8WlHRCwmQBBq1dgGLlhcCxn5wBHj3AWf0ds=; h=Message-ID:Subject:From:To:Cc:Date:Autocrypt:Content-Type: MIME-Version:OpenPGP:From; b=CmeI1HTQXWsoeMbKl3FUmjpTMxqn6piWiDlnd9yKalMXWdhPOwQE9nN058QRnUCIh nAC4yhrx1O1h5N+slqlPSIMF3wN+v+sBeoc1vQta4I6VFaP0AzpLhNuVfL+mZOtKlv DYvfubdeWf9lnzc5+FqG60n3/EVbq/WODnhYJC4pImEkZ+DFYpBhOdIUrguJhyflWI rmfdZ6vJpARiQU2HyuxFsgrwYeovhVvGZf12UVKmvWbPQT8wBhCbzHTaVqk6lznFKz +xYmPfkUwRynQI4bcF4dNt3ltWsHEEMBuMfEjbM89xpdt1/GNINcmQO7sJUEklOzBO ZEjEvOtaeSJrw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4hjYWT2yTJz9rxK; Sun, 13 Sep 2026 18:24:05 +0200 (CEST) Message-ID: Subject: Re: [PATCH v25 2/4] rust: leds: add Mode trait From: Markus Probst To: Lee Jones , Pavel Machek , Greg Kroah-Hartman , Dave Ertman , Leon Romanovsky , Miguel Ojeda , Alex Gaynor , Gary Guo , =?ISO-8859-1?Q?Bj=F6rn?= Roy Baron , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , "Rafael J. Wysocki" , Bjorn Helgaas , Krzysztof =?UTF-8?Q?Wilczy=C5=84ski?= , Boqun Feng , Daniel Almeida , Tamir Duberstein , Alexandre Courbot , Onur =?ISO-8859-1?Q?=D6zkan?= , Ira Weiny Cc: rust-for-linux@vger.kernel.org, linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org Date: Sun, 13 Sep 2026 16:24:07 +0000 In-Reply-To: <20260913-rust_leds-v25-2-1a10371d78c3@posteo.de> References: <20260913-rust_leds-v25-0-1a10371d78c3@posteo.de> <20260913-rust_leds-v25-2-1a10371d78c3@posteo.de> Autocrypt: addr=markus.probst@posteo.de; prefer-encrypt=mutual; keydata=mQINBGiDvXgBEADAXUceKafpl46S35UmDh2wRvvx+UfZbcTjeQOlSwKP7YVJ4JOZrVs93 qReNLkOWguIqPBxR9blQ4nyYrqSCV+MMw/3ifyXIm6Pw2YRUDg+WTEOjTixRCoWDgUj1nOsvJ9tVA m76Ww+/pAnepVRafMID0rqEfD9oGv1YrfpeFJhyE2zUw3SyyNLIKWD6QeLRhKQRbSnsXhGLFBXCqt 9k5JARhgQof9zvztcCVlT5KVvuyfC4H+HzeGmu9201BVyihJwKdcKPq+n/aY5FUVxNTgtI9f8wIbm fAjaoT1pjXSp+dszakA98fhONM98pOq723o/1ZGMZukyXFfsDGtA3BB79HoopHKujLGWAGskzClwT jRQxBqxh/U/lL1pc+0xPWikTNCmtziCOvv0KA0arDOMQlyFvImzX6oGVgE4ksKQYbMZ3Ikw6L1Rv1 J+FvN0aNwOKgL2ztBRYscUGcQvA0Zo1fGCAn/BLEJvQYShWKeKqjyncVGoXFsz2AcuFKe1pwETSsN 6OZncjy32e4ktgs07cWBfx0v62b8md36jau+B6RVnnodaA8++oXl3FRwiEW8XfXWIjy4umIv93tb8 8ekYsfOfWkTSewZYXGoqe4RtK80ulMHb/dh2FZQIFyRdN4HOmB4FYO5sEYFr9YjHLmDkrUgNodJCX CeMe4BO4iaxUQARAQABtCdNYXJrdXMgUHJvYnN0IDxtYXJrdXMucHJvYnN0QHBvc3Rlby5kZT6JAl QEEwEIAD4CGwMFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AWIQSCdBjE9KxY53IwxHM0dh/4561 D0gUCaIZ9HQIZAQAKCRA0dh/4561D0pKmD/92zsCfbD+SrvBpNWtbit7J9wFBNr9qSFFm2n/65qen NNWKDrCzDsjRbALMHSO8nigMWzjofbVjj8Nf7SDcdapRjrMCnidS0DuW3pZBo6W0sZqV/fLx+AzgQ 7PAr6jtBbUoKW/GCGHLLtb6Hv+zjL17KGVO0DdQeoHEXMa48mJh8rS7VlUzVtpbxsWbb1wRZJTD88 ALDOLTWGqMbCTFDKFfGcqBLdUT13vx706Q29wrDiogmQhLGYKc6fQzpHhCLNhHTl8ZVLuKVY3wTT+ f9TzW1BDzFTAe3ZXsKhrzF+ud7vr6ff9p1Zl+Nujz94EDYHi/5Yrtp//+N/ZjDGDmqZOEA86/Gybu 6XE/v4S85ls0cAe37WTqsMCJjVRMP52r7Y1AuOONJDe3sIsDge++XFhwfGPbZwBnwd4gEVcdrKhnO ntuP9TvBMFWeTvtLqlWJUt7n8f/ELCcGoO5acai1iZ59GC81GLl2izObOLNjyv3G6hia/w50Mw9MU dAdZQ2MxM6k+x4L5XeysdcR/2AydVLtu2LGFOrKyEe0M9XmlE6OvziWXvVVwomvTN3LaNUmaINhr7 pHTFwDiZCSWKnwnvD2+jA1trKq1xKUQY1uGW9XgSj98pKyixHWoeEpydr+alSTB43c3m0351/9rYT TTi4KSk73wtapPKtaoIR3rOFHLQXbWFya3VzLnByb2JzdEBwb3N0ZW8uZGWJAlEEEwEIADsWIQSCd BjE9KxY53IwxHM0dh/4561D0gUCaIO9eAIbAwULCQgHAgIiAgYVCgkICwIEFgIDAQIeBwIXgAAKCR A0dh/4561D0oHZEACEmk5Ng9+OXoVxJJ+c9slBI2lYxyBO84qkWjoJ/0GpwoHk1IpyL+i+kF1Bb7y Hx9Tiz8ENYX7xIPTZzS8hXs1ksuo76FQUyD6onA/69xZIrYZ0NSA5HUo62qzzMSZL7od5e12R6OPR lR0PIuc4ecOGCEq3BLRPfZSYrL54tiase8HubXsvb6EBQ8jPI8ZUlr96ZqFEwrQZF/3ihyV6LILLk geExgwlTzo5Wv3piOXPTITBuzuFhBJqEnT25q2j8OumGQ+ri8oVeAzx24g1kc11pwpR0sowfa5MvZ WrrBcaIL7uJfR/ig7FyGnTQ1nS3btf3p0v8A3fc4eUu/K2No3l2huJp3+LHhCmpmeykOhSB63Mj3s 3Q87LD0HE0HBkTEMwp+sD97ZRpO67H5shzJRanUaDTb/mREfzpJmRT1uuec0X2zItL7a6itgMJvYI KG29aJLX3fTzzVzFGPgzVZYEdhu4y53p0qEGrrC1JtKR6DRPE1hb/OdWOkjmJ75+PPLD9U5IuRd6y sHJWsEBR1F0wkMPkEofWsvMYJzWXx/rvTWO8N4D6HigTgBXAXNgbc3IHpHlkvKoBJptv6DRVRtIrz 0G0cfBY0Sm7he4N2IYDWWdGnPBZ3rlLSdj5EiBU2YWgIgtLrb8ZNJ3ZlhYluGnBJDGRqy2jC9s1jY 66sLA9rQZMHhJTzMyIDwweGlvMzJAcG9zdGVvLmV1PokCbQQTAQgAVxYhBIJ0GMT0rFjncjDEczR2 H/jnrUPSBQJpa71VGxSAAAAAAAQADm1hbnUyLDIuNSsxLjExLDIsMgIbAwULCQgHAgIiAgYVCgkIC wIEFgIDAQIeBwIXgAAKCRA0dh/4561D0gKJD/9uOQKYlsDoQX65Gd0LiMT0C+5vXgr3VI0PHDOwcv 51fJ3A1vNyPZRFPGrz8+mDEXUQOF/INfnz5Tu1QHwf+iYcWcTGAN/FHgVR6ET6VBNU2hJaKhu+Ggo kjYyJTOvyX+3yNRUfSny0GjTjIPuPTErjqmHF+BtjXslpgwqnNMznf3lRIuUjRORupos6p3k1DndE 5vzUTmXSvMyXyOD2KhBl/kL76k0bHYyAQytZPag12pltrtFbA/r2phDGN2si8PooDT99bSTJjaM45 MTAAHbHKJfvgfK41bNFD5mMtpWpL195XRtS0Nrxdg3PaYBxN5gtTG0RyZfpYRlkdEhm+jj/8RxuSG i/qdhRdbiI7K2IELWeQVHSNDi9JabR/UzlR4NSnhfAjRIVlRM+eFbUl8XwxwVrAkojF5IraH2qRvg VCmuFsHUW07FUlrDrzpjXsD73cKppoFGDCdDR0BHJepXbFLS9+AqkT+guRJlnCTg2p+TQtnbwPgKp Vj98JixovCl99zRYTsL2bRNU5+q8iET65VMJ1ydyNanvLd5vI/NqDkXhlXLsGmdaDTtu4R21PkToX dQNGrZ91M9nlIBKw8Y7c7xZ4098qX2b8JX/CxD+gC1r4C8vuA3GkhFLx+KlkON7LyiJPkrePp6Qky jfGillcaQOqFZ3WwVqyzG1BUfTow== Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-OaxUqTEkTo+BhzyBoF/J" Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 OpenPGP: url=https://posteo.de/keys/markus.probst@posteo.de.asc; preference=encrypt --=-OaxUqTEkTo+BhzyBoF/J Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sun, 2026-09-13 at 16:15 +0000, Markus Probst wrote: > Add the `led::Mode` trait to allow for other types of led class devices > in `led::LedOps`. >=20 > Signed-off-by: Markus Probst > --- > rust/kernel/led.rs | 37 ++++++++++++++++++++++++++----------- > rust/kernel/led/normal.rs | 12 ++++++++++-- > 2 files changed, 36 insertions(+), 13 deletions(-) >=20 > diff --git a/rust/kernel/led.rs b/rust/kernel/led.rs > index deda8cc548a8..7cd8f0504649 100644 > --- a/rust/kernel/led.rs > +++ b/rust/kernel/led.rs > @@ -4,11 +4,7 @@ > //! > //! C header: [`include/linux/leds.h`](srctree/include/linux/leds.h) > =20 > -use core::{ > - marker::PhantomData, > - mem::transmute, > - ptr::NonNull, // > -}; > +use core::{marker::PhantomData, mem::transmute, ops::Deref, ptr::NonNull= }; supposed to be vertical. Thanks - Markus Probst --=-OaxUqTEkTo+BhzyBoF/J Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- iQJPBAABCAA5FiEEgnQYxPSsWOdyMMRzNHYf+OetQ9IFAmqmziQbFIAAAAAABAAO bWFudTIsMi41KzEuMTIsMiwyAAoJEDR2H/jnrUPSGAsQAJKm37JDmgYQ7+ndKdPv Jjf+780GMAfSCqHfM8Y1bEZZBXfUBlQvN6Pnx50NBlK9xDlDOBrdq1ji7u1gxSUu j+crXgluVMYgAcgOkRovg5a2qTer6/xDDyuEkk49ps4jaCuupDKw2rjSMc8x+AQ4 Kr/wrN7uqy4oZijv06lMGu3pih6l+SYy+BTjX1ptzE9/8tSPozbn46Ho8TbtkcHW s6fgsSSFyXauW0otO4dfJpn6X/OIo1utIsxsQN9m//aQ5OdxUmhd7z2uO2WgjrTL +lbhWTUNl1tyIgd7pV6xDQcdGNwCyBJA+E34YeflcNxs1vQfsqwIcBn0pye++mjp PFPad08ClzgDQ4Fi307a3Ja+L63UZbtJdJSHdIrFpAlbnRPhhTE3NiLeV+tnNlvT VEtY4EKm/90ZbWHQ9nNspCNR21ILHnDYqM1ZAvAqJVBjsFla6tHvTiqPGXj2PcY8 tfu1Wg+QkOKYi0xnXOjBPtEkM3UVAfIR2Nth4b4NE5o6ldNvMmO5YRUptZVVU0fS oE3iq9UDstB346JlK72QL1uy30il/BO2NaQxdnEFOyUMJQZnQdxsUfxwC3NVtUIG WNfMigdBpnW1fLuouhtRkZcmPkEbLD6H5jvfV92OBZqvOIVN/kEyGgucAvCuK09x bJT1hzRNamyhVVe6B7EMQqVc =pH62 -----END PGP SIGNATURE----- --=-OaxUqTEkTo+BhzyBoF/J--