From: Danilo Krummrich <dakr@kernel.org>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: "Igor Korotin" <igor.korotin.linux@gmail.com>,
"Daniel Almeida" <daniel.almeida@collabora.com>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
rust-for-linux@vger.kernel.org,
"Wolfram Sang" <wsa+renesas@sang-engineering.com>
Subject: Re: [PATCH v3 1/3] rust: i2c: add basic I2C device and driver abstractions
Date: Fri, 15 Aug 2025 19:16:13 +0200 [thread overview]
Message-ID: <be2b524e-4b1d-451c-b2f6-999ef0a368a5@kernel.org> (raw)
In-Reply-To: <2025081514-filter-unfunded-e312@gregkh>
On 8/15/25 7:04 PM, Greg KH wrote:
> I would try to keep them matching the same as the C side, as
> i2c_client_device and i2c_adapter_device wouldn't make much sense there
> either.
Another option would be separate modules, i.e. i2c::client::Device and
i2c::adapter::Device.
But I guess just i2c::Client and i2c::Adapter are fine too.
The former would fit a bit better into the existing Rust naming scheme, the
latter matches a bit better with the C code.
next prev parent reply other threads:[~2025-08-15 17:16 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-01 15:37 [PATCH v3 0/3] rust: i2c: Add basic I2C driver abstractions Igor Korotin
2025-08-01 15:40 ` [PATCH v3 1/3] rust: i2c: add basic I2C device and " Igor Korotin
2025-08-01 17:14 ` Daniel Almeida
2025-08-02 0:22 ` Danilo Krummrich
2025-08-04 14:16 ` Igor Korotin
2025-08-02 0:00 ` Danilo Krummrich
2025-08-02 9:07 ` Wolfram Sang
2025-08-02 10:51 ` Danilo Krummrich
2025-08-02 12:14 ` Wolfram Sang
2025-08-02 12:41 ` Danilo Krummrich
2025-08-04 14:58 ` Igor Korotin
2025-08-04 15:17 ` Danilo Krummrich
2025-08-04 15:24 ` Miguel Ojeda
2025-08-04 15:40 ` Igor Korotin
2025-08-04 16:11 ` Wolfram Sang
2025-08-04 17:15 ` Danilo Krummrich
2025-08-04 22:01 ` Wolfram Sang
2025-08-05 8:37 ` Igor Korotin
2025-08-05 9:28 ` Wolfram Sang
2025-08-05 12:40 ` Daniel Almeida
2025-08-04 17:26 ` Igor Korotin
2025-08-04 17:46 ` Miguel Ojeda
2025-08-04 21:57 ` Wolfram Sang
2025-08-15 15:40 ` Igor Korotin
2025-08-15 16:03 ` Danilo Krummrich
2025-08-15 17:04 ` Greg KH
2025-08-15 17:16 ` Danilo Krummrich [this message]
2025-08-01 15:44 ` [PATCH v3 2/3] rust: i2c: add manual I2C device creation abstractions Igor Korotin
2025-08-01 17:59 ` Daniel Almeida
2025-08-02 0:26 ` Danilo Krummrich
2025-08-04 14:38 ` Igor Korotin
2025-08-02 0:12 ` Danilo Krummrich
2025-08-01 15:45 ` [PATCH v3 3/3] samples: rust: add Rust I2C sample driver Igor Korotin
2025-08-01 18:09 ` Daniel Almeida
2025-08-04 14:43 ` Igor Korotin
2025-08-04 14:58 ` Daniel Almeida
2025-08-02 0:18 ` Danilo Krummrich
2025-08-07 8:42 ` kernel test robot
2025-08-04 15:07 ` [PATCH v3 0/3] rust: i2c: Add basic I2C driver abstractions Daniel Almeida
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be2b524e-4b1d-451c-b2f6-999ef0a368a5@kernel.org \
--to=dakr@kernel.org \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=daniel.almeida@collabora.com \
--cc=gary@garyguo.net \
--cc=gregkh@linuxfoundation.org \
--cc=igor.korotin.linux@gmail.com \
--cc=lossin@kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).